Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,6 @@ describe('SharesPanel', () => {
...defaultPlugins({ piniaOptions: { sharesState: { loading: sharesLoading } } })
],
provide: {
activePanel: null,
displayedItem: {},
displayedSpace: {},
spaceMembers: { value: [] }
Expand Down
2 changes: 0 additions & 2 deletions packages/web-pkg/src/components/SideBar/FileSideBar.vue
Original file line number Diff line number Diff line change
Expand Up @@ -417,6 +417,4 @@ provide(
'versionsLoading',
computed(() => loadVersionsTask.isRunning)
)
/** @deprecated use from useSideBar instead */
provide('activePanel', activePanel)
</script>
33 changes: 1 addition & 32 deletions packages/web-pkg/src/composables/piniaStores/sideBar.ts
Original file line number Diff line number Diff line change
@@ -1,19 +1,9 @@
import { defineStore } from 'pinia'
import { computed, nextTick, ref, unref } from 'vue'
import { eventBus } from '../../services/eventBus'
import { useLocalStorage } from '../localStorage'
import { useEmbedMode } from '../embedMode'
import { useIsMobile } from '@opencloud-eu/design-system/composables'

/** @deprecated use exposed methods from useSideBar instead */
export enum SideBarEventTopics {
open = 'sidebar.open',
close = 'sidebar.close',
toggle = 'sidebar.toggle',
openWithPanel = 'sidebar.openWithPanel',
setActivePanel = 'sidebar.setActivePanel'
}

export const useSideBar = defineStore('sideBar', () => {
const { isEnabled: isEmbedModeEnabled } = useEmbedMode()
const isSideBarOpenLocalStorage = useLocalStorage(`oc_sideBarOpen`, false)
Expand Down Expand Up @@ -74,31 +64,13 @@ export const useSideBar = defineStore('sideBar', () => {
sideBarActivePanel.value = panelName
}

eventBus.subscribe(SideBarEventTopics.toggle, toggleSideBar)
eventBus.subscribe(SideBarEventTopics.close, closeSideBar)
eventBus.subscribe(SideBarEventTopics.open, openSideBar)
eventBus.subscribe(SideBarEventTopics.openWithPanel, openSideBarPanel)
eventBus.subscribe(SideBarEventTopics.setActivePanel, setActiveSideBarPanel)

const onInitialLoad = () => {
if (unref(isMobile)) {
// close sidebar on mobile devices on initial load because it's a bottom drawer
isSideBarOpen.value = false
}
}

const onPanelActive = (name: string, callback: (string: string) => void) => {
eventBus.subscribe(SideBarEventTopics.setActivePanel, (panelName: string) => {
if (name !== panelName) {
return
}
// acount for threshold
setTimeout(() => {
callback(panelName)
}, 100)
})
}

return {
isSideBarOpen,
sideBarActivePanel,
Expand All @@ -108,10 +80,7 @@ export const useSideBar = defineStore('sideBar', () => {
closeSideBar,
openSideBar,
openSideBarPanel,
setActiveSideBarPanel,

/** @deprecated */
onPanelActive
setActiveSideBarPanel
}
})

Expand Down
7 changes: 0 additions & 7 deletions packages/web-pkg/src/constants.ts
Original file line number Diff line number Diff line change
@@ -1,10 +1,3 @@
/** @deprecated use from design-system instead */
export const EVENT_TROW_MOUNTED = 'rowMounted'
/** @deprecated use from design-system instead */
export const EVENT_FILE_DROPPED = 'fileDropped'
/** @deprecated use from design-system instead */
export const EVENT_TROW_CONTEXTMENU = 'contextmenuClicked'

export abstract class ImageDimension {
static readonly Thumbnail: [number, number] = [36, 36]
static readonly Tile: [number, number] = [1000, 1000]
Expand Down
1 change: 0 additions & 1 deletion packages/web-pkg/src/helpers/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,6 @@ export * from './filesize'
export * from './fuse'
export * from './locale'
export * from './path'
export * from './statusIndicators'
export * from './store'
export * from './binary'
export * from './platform'
Expand Down
19 changes: 0 additions & 19 deletions packages/web-pkg/src/helpers/statusIndicators.ts

This file was deleted.