Create README for disable-peer-as-filter by sachendras · Pull Request #5116 · openconfig/featureprofiles

sachendras · 2026-02-20T19:24:52Z

New FNT for disable-peer-as-filter.

gemini-code-assist · 2026-02-20T19:25:05Z

Summary of Changes

Hello @sachendras, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces essential documentation for a new feature test (FNT) focused on the BGP disable-peer-as-filter functionality. The added README.md provides a clear and structured guide for verifying how BGP handles AS-PATH filtering in transit scenarios, particularly when an eBGP peer's AS is present in the AS-PATH, ensuring proper route advertisement and reception.

Highlights

New Feature Test Documentation: Added a comprehensive README.md file detailing the test plan for the BGP disable-peer-as-filter feature. This includes the test summary, network topology, detailed test procedures (baseline, disable-peer-as-filter=TRUE, and originating peer AS scenarios), canonical OpenConfig, and covered OpenConfig paths and RPCs.

Changelog

feature/bgp/otg_tests/bgp_disable_peer_as_filter_test/README.md
- Added detailed documentation for the BGP disable-peer-as-filter feature test.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	`/gemini review`	Performs a code review for the current pull request in its current state.
Pull Request Summary	`/gemini summary`	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	`/gemini help`	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

OpenConfigBot · 2026-02-20T19:25:31Z

Pull Request Functional Test Report for #5116 / `7d4eeed`

Virtual Devices

Device	Test Documentation	Job	Raw Log
Arista cEOS	RT-1.71: BGP Disable Peer AS Filter (`disable-peer-as-filter`)	f0eb7b84	Log
Cisco 8000E	RT-1.71: BGP Disable Peer AS Filter (`disable-peer-as-filter`)	3f1899bc	Log
Cisco XRd	RT-1.71: BGP Disable Peer AS Filter (`disable-peer-as-filter`)	1c0fcafa	Log
Juniper ncPTX	RT-1.71: BGP Disable Peer AS Filter (`disable-peer-as-filter`)	cbb9cee6	Log
Nokia SR Linux	RT-1.71: BGP Disable Peer AS Filter (`disable-peer-as-filter`)	c861e1d6	Log
Openconfig Lemming	RT-1.71: BGP Disable Peer AS Filter (`disable-peer-as-filter`)	b19590e7	Log

Hardware Devices

Device	Test	Test Documentation	Raw Log
Arista 7808		RT-1.71: BGP Disable Peer AS Filter (`disable-peer-as-filter`)
Cisco 8808		RT-1.71: BGP Disable Peer AS Filter (`disable-peer-as-filter`)
Juniper PTX10008		RT-1.71: BGP Disable Peer AS Filter (`disable-peer-as-filter`)
Nokia 7250 IXR-10e		RT-1.71: BGP Disable Peer AS Filter (`disable-peer-as-filter`)

Help

Correction to the Summary

gemini-code-assist

Code Review

The added README.md for the BGP disable-peer-as-filter test follows the general structure but requires several adjustments to fully comply with the repository's test plan template and network assignment guidelines. Specifically, mandatory sections like Testbed type and Test environment setup are missing, and the ASN and IPv4 ranges used do not follow the RFC-compliant blocks specified in the style guide. All original comments are retained as they do not contradict the provided rule.

Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>

Updated test to accommodate corrected ASNs and IP addresses

Correcting formatting errors

Correct description in the metadata file

sachendras · 2026-02-21T01:35:59Z

/gcbrun

Update to the Metadata.proto

sachendras · 2026-02-21T02:13:03Z

/gcbrun

Addressing review comment for use of different v4 & v6 peering as well as for updates.

Addressing the review comments to add a scenario for private ASN

sachendras · 2026-03-09T14:39:00Z

/gcbrun

* Create README.md New FNT for disable-peer-as-filter. * Update README.md Correction to the Summary * Update feature/bgp/otg_tests/bgp_disable_peer_as_filter_test/README.md Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com> * Update feature/bgp/otg_tests/bgp_disable_peer_as_filter_test/README.md Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com> * Update feature/bgp/otg_tests/bgp_disable_peer_as_filter_test/README.md Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com> * Update feature/bgp/otg_tests/bgp_disable_peer_as_filter_test/README.md Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com> * Update feature/bgp/otg_tests/bgp_disable_peer_as_filter_test/README.md Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com> * Update README.md Updated test to accommodate corrected ASNs and IP addresses * Add mandatory metadata.textproto for RT-1.71 * Update README.md Correcting formatting errors * Update metadata.textproto Correct description in the metadata file * Fix proto-file path and add metadata for RT-1.71 * Update metadata.textproto Update to the Metadata.proto * Update README.md Addressing review comment for use of different v4 & v6 peering as well as for updates. * Update README.md Addressing the review comments to add a scenario for private ASN --------- Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>

Create README.md

7065e61

New FNT for disable-peer-as-filter.

sachendras requested a review from a team as a code owner February 20, 2026 19:24

Update README.md

4f7476f

Correction to the Summary

gemini-code-assist Bot reviewed Feb 20, 2026

View reviewed changes

sachendras and others added 6 commits February 20, 2026 11:39

Update feature/bgp/otg_tests/bgp_disable_peer_as_filter_test/README.md

06f44e1

Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>

Update feature/bgp/otg_tests/bgp_disable_peer_as_filter_test/README.md

5db7c04

Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>

Update feature/bgp/otg_tests/bgp_disable_peer_as_filter_test/README.md

382adca

Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>

Update feature/bgp/otg_tests/bgp_disable_peer_as_filter_test/README.md

cc058aa

Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>

Update feature/bgp/otg_tests/bgp_disable_peer_as_filter_test/README.md

9accff3

Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>

Update README.md

81e798c

Updated test to accommodate corrected ASNs and IP addresses

sachendras changed the title ~~Create README.md~~ Create README for disable-peer-as-filter Feb 20, 2026

sachendras and others added 3 commits February 20, 2026 19:47

Add mandatory metadata.textproto for RT-1.71

97c5ce5

Update README.md

59293bb

Correcting formatting errors

Update metadata.textproto

37f8092

Correct description in the metadata file

sachendras and others added 2 commits February 20, 2026 21:10

Fix proto-file path and add metadata for RT-1.71

c6c073b

Update metadata.textproto

fc9af54

Update to the Metadata.proto

ksgireesha assigned ram-mac Feb 21, 2026

sachendras requested a review from mellowdrifter February 21, 2026 06:59

ram-mac requested changes Feb 25, 2026

View reviewed changes

Comment thread feature/bgp/otg_tests/bgp_disable_peer_as_filter_test/README.md

Comment thread feature/bgp/otg_tests/bgp_disable_peer_as_filter_test/README.md Outdated

sachendras added 3 commits February 25, 2026 15:56

Merge branch 'main' into sachendras-patch-30

54f5dae

Update README.md

6a1b02a

Addressing review comment for use of different v4 & v6 peering as well as for updates.

Update README.md

1bb3c3b

Addressing the review comments to add a scenario for private ASN

sachendras requested a review from ram-mac March 9, 2026 00:05

sachendras added 2 commits March 8, 2026 17:07

Merge branch 'main' into sachendras-patch-30

2000e1c

Merge branch 'main' into sachendras-patch-30

d6a34e2

Merge branch 'main' into sachendras-patch-30

2523195

ram-mac approved these changes Mar 10, 2026

View reviewed changes

Merge branch 'main' into sachendras-patch-30

7d4eeed

sachendras merged commit 3235dc2 into main Mar 10, 2026
18 checks passed

sachendras deleted the sachendras-patch-30 branch March 10, 2026 22:22

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Create README for disable-peer-as-filter#5116

Create README for disable-peer-as-filter#5116
sachendras merged 20 commits intomainfrom
sachendras-patch-30

sachendras commented Feb 20, 2026

Uh oh!

gemini-code-assist Bot commented Feb 20, 2026

Uh oh!

OpenConfigBot commented Feb 20, 2026 •

edited

Loading

Uh oh!

gemini-code-assist Bot left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

sachendras commented Feb 21, 2026

Uh oh!

sachendras commented Feb 21, 2026

Uh oh!

Uh oh!

Uh oh!

sachendras commented Mar 9, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

sachendras commented Feb 20, 2026

Uh oh!

gemini-code-assist Bot commented Feb 20, 2026

Summary of Changes

Highlights

Footnotes

Uh oh!

OpenConfigBot commented Feb 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Pull Request Functional Test Report for #5116 / 7d4eeed

Virtual Devices

Hardware Devices

Uh oh!

gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

sachendras commented Feb 21, 2026

Uh oh!

sachendras commented Feb 21, 2026

Uh oh!

Uh oh!

Uh oh!

sachendras commented Mar 9, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

OpenConfigBot commented Feb 20, 2026 •

edited

Loading

Pull Request Functional Test Report for #5116 / `7d4eeed`