Skip to content

Update testregistry.textproto#5117

Merged
dplore merged 5 commits intomainfrom
sachendras-patch-32
Mar 10, 2026
Merged

Update testregistry.textproto#5117
dplore merged 5 commits intomainfrom
sachendras-patch-32

Conversation

@sachendras
Copy link
Copy Markdown
Contributor

Defining a new test RT-1.71

Defining a new test RT-1.71
@sachendras sachendras requested a review from a team as a code owner February 21, 2026 06:56
@gemini-code-assist
Copy link
Copy Markdown
Contributor

Summary of Changes

Hello @sachendras, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces a new test definition into the existing test registry. The primary purpose is to register a specific BGP-related test, making it discoverable and trackable within the system. This ensures that the new test for disabling peer AS filters is formally recognized.

Highlights

  • New Test Definition: A new test entry with ID "RT-1.71" has been added to the testregistry.textproto file. This test is described as "BGP Disable Peer AS Filter (disable-peer-as-filter)".
Changelog
  • testregistry.textproto
    • Added a new test entry for "RT-1.71".
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@OpenConfigBot
Copy link
Copy Markdown

OpenConfigBot commented Feb 21, 2026

Pull Request Functional Test Report for #5117 / f9e97ec

No tests identified for validation.

Help

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

The pull request adds a new test entry RT-1.71 to the registry. The primary feedback concerns the sorting of the new entry, which deviates from the numeric sorting pattern established in the file, and the use of empty placeholders for documentation links.

Comment thread testregistry.textproto Outdated
Comment thread testregistry.textproto Outdated
- Add the url for the test (
test: {
  id: "RT-1.71"
  description: "BGP Disable Peer AS Filter (disable-peer-as-filter)"
  readme: "https://github.com/openconfig/featureprofiles/blob/main/feature/bgp/bgp_disable_peer_as_filter_test/README.md"
  exec: " "
})

-- Also changed the order of the test definition and placed it after RT-1.66
@dplore
Copy link
Copy Markdown
Member

dplore commented Mar 9, 2026

there's a conflict to resolve, but otherwise LGTM

Copy link
Copy Markdown
Contributor

@ram-mac ram-mac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dplore
Copy link
Copy Markdown
Member

dplore commented Mar 10, 2026

There's an error in the file:

2026/03/10 15:33:05 Failed parsing ./testregistry.textproto: unmarshal failure: proto: (line 941:3): non-repeated field "id" is repeated

Here is the problem:

test: {
  id: "RT-1.71"
  description: "BGP Disable Peer AS Filter (disable-peer-as-filter)"
  readme: "https://github.com/openconfig/featureprofiles/blob/main/feature/bgp/bgp_disable_peer_as_filter_test/README.md"
  id: "RT-1.67"
  description: "IPv4 and IPv6 Static Route using Vlan Interface"
  readme: "https://github.com/openconfig/featureprofiles/blob/main/feature/staticroute/otg_tests/static_route_with_vlan_interface/README.md"
  exec: " "
}

@sachendras
Copy link
Copy Markdown
Contributor Author

/gcbrun

@sachendras
Copy link
Copy Markdown
Contributor Author

There's an error in the file:

2026/03/10 15:33:05 Failed parsing ./testregistry.textproto: unmarshal failure: proto: (line 941:3): non-repeated field "id" is repeated

Here is the problem:

test: {
  id: "RT-1.71"
  description: "BGP Disable Peer AS Filter (disable-peer-as-filter)"
  readme: "https://github.com/openconfig/featureprofiles/blob/main/feature/bgp/bgp_disable_peer_as_filter_test/README.md"
  id: "RT-1.67"
  description: "IPv4 and IPv6 Static Route using Vlan Interface"
  readme: "https://github.com/openconfig/featureprofiles/blob/main/feature/staticroute/otg_tests/static_route_with_vlan_interface/README.md"
  exec: " "
}

ack, corrected thanks!

@dplore dplore merged commit e9c6fc1 into main Mar 10, 2026
18 checks passed
@dplore dplore deleted the sachendras-patch-32 branch March 10, 2026 23:27
ampattan pushed a commit to nokia/featureprofiles that referenced this pull request Apr 1, 2026
* Update testregistry.textproto

Defining a new test RT-1.71

* Update testregistry.textproto

- Add the url for the test (
test: {
  id: "RT-1.71"
  description: "BGP Disable Peer AS Filter (disable-peer-as-filter)"
  readme: "https://github.com/openconfig/featureprofiles/blob/main/feature/bgp/bgp_disable_peer_as_filter_test/README.md"
  exec: " "
})

-- Also changed the order of the test definition and placed it after RT-1.66

* Update testregistry.textproto

Fixing error as per comment openconfig#5117
nsadhasivam pushed a commit to nsadhasivam/featureprofiles that referenced this pull request Apr 6, 2026
* Update testregistry.textproto

Defining a new test RT-1.71

* Update testregistry.textproto

- Add the url for the test (
test: {
  id: "RT-1.71"
  description: "BGP Disable Peer AS Filter (disable-peer-as-filter)"
  readme: "https://github.com/openconfig/featureprofiles/blob/main/feature/bgp/bgp_disable_peer_as_filter_test/README.md"
  exec: " "
})

-- Also changed the order of the test definition and placed it after RT-1.66

* Update testregistry.textproto

Fixing error as per comment openconfig#5117
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants