Conversation
Defining a new test RT-1.71
Summary of ChangesHello @sachendras, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request introduces a new test definition into the existing test registry. The primary purpose is to register a specific BGP-related test, making it discoverable and trackable within the system. This ensures that the new test for disabling peer AS filters is formally recognized. Highlights
Changelog
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
The pull request adds a new test entry RT-1.71 to the registry. The primary feedback concerns the sorting of the new entry, which deviates from the numeric sorting pattern established in the file, and the use of empty placeholders for documentation links.
- Add the url for the test (
test: {
id: "RT-1.71"
description: "BGP Disable Peer AS Filter (disable-peer-as-filter)"
readme: "https://github.com/openconfig/featureprofiles/blob/main/feature/bgp/bgp_disable_peer_as_filter_test/README.md"
exec: " "
})
-- Also changed the order of the test definition and placed it after RT-1.66
|
there's a conflict to resolve, but otherwise LGTM |
|
There's an error in the file: 2026/03/10 15:33:05 Failed parsing ./testregistry.textproto: unmarshal failure: proto: (line 941:3): non-repeated field "id" is repeated Here is the problem: |
Fixing error as per comment #5117
|
/gcbrun |
ack, corrected thanks! |
* Update testregistry.textproto
Defining a new test RT-1.71
* Update testregistry.textproto
- Add the url for the test (
test: {
id: "RT-1.71"
description: "BGP Disable Peer AS Filter (disable-peer-as-filter)"
readme: "https://github.com/openconfig/featureprofiles/blob/main/feature/bgp/bgp_disable_peer_as_filter_test/README.md"
exec: " "
})
-- Also changed the order of the test definition and placed it after RT-1.66
* Update testregistry.textproto
Fixing error as per comment openconfig#5117
* Update testregistry.textproto
Defining a new test RT-1.71
* Update testregistry.textproto
- Add the url for the test (
test: {
id: "RT-1.71"
description: "BGP Disable Peer AS Filter (disable-peer-as-filter)"
readme: "https://github.com/openconfig/featureprofiles/blob/main/feature/bgp/bgp_disable_peer_as_filter_test/README.md"
exec: " "
})
-- Also changed the order of the test definition and placed it after RT-1.66
* Update testregistry.textproto
Fixing error as per comment openconfig#5117
Defining a new test RT-1.71