Skip to content

Add READMEs for gRIBI full scale tests T1 and T2#5122

Merged
gggsmith merged 7 commits intoopenconfig:mainfrom
gggsmith:gribi-scaling
Mar 12, 2026
Merged

Add READMEs for gRIBI full scale tests T1 and T2#5122
gggsmith merged 7 commits intoopenconfig:mainfrom
gggsmith:gribi-scaling

Conversation

@gggsmith
Copy link
Copy Markdown
Contributor

Please reach out for the reference to workstream internally

@gggsmith gggsmith requested a review from a team as a code owner February 23, 2026 11:48
@gemini-code-assist
Copy link
Copy Markdown
Contributor

Summary of Changes

Hello @gggsmith, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces detailed documentation for two new gRIBI full-scale tests, T1 and T2. These README files provide essential information regarding the test setup, including network topology, VRF configurations, detailed procedures for installing NextHops and NextHopGroups, and a comprehensive suite of test cases to validate gRIBI scaling requirements. The addition of these documents will facilitate the implementation and execution of these critical scaling validation tests.

Highlights

  • New gRIBI Full Scale Test T1 Documentation: Added a comprehensive README.md for gribi_full_scale_t1, detailing the topology, VRF configuration, step-by-step procedure, and extensive test cases for validating gRIBI scaling requirements (Target T1).
  • New gRIBI Full Scale Test T2 Documentation: Introduced a README.md for gribi_full_scale_t2, outlining the scaling adjustments for Target T2 based on the TE-14.3.1 topology, specifically modifying NextHopGroup granularities and total counts for NHGs and NHs.
Changelog
  • feature/gribi/otg_tests/gribi_full_scale_t1/README.md
    • Added a new README file detailing the gRIBI full scale test T1, including topology, VRF setup, procedure, and test cases.
  • feature/gribi/otg_tests/gribi_full_scale_t2/README.md
    • Added a new README file for gRIBI full scale test T2, specifying scaling adjustments relative to test T1.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@gggsmith gggsmith self-assigned this Feb 23, 2026
@OpenConfigBot
Copy link
Copy Markdown

OpenConfigBot commented Feb 23, 2026

@gggsmith gggsmith removed their assignment Feb 23, 2026
@gggsmith gggsmith assigned gggsmith and nikki-blr and unassigned gggsmith Feb 23, 2026
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

The pull request introduces two new README files for gRIBI full-scale tests T1 and T2. These READMEs outline the summary, topology, baseline configuration, procedure, and test cases for validating gRIBI scaling requirements. The T1 README provides a detailed configuration for VRF selection policy and various gRIBI entry setups, while the T2 README specifies adjustments to the scale parameters based on T1. All original comments have been kept as they do not contradict the provided rule regarding duplicating lists of paths in README files.

Comment thread feature/gribi/otg_tests/gribi_full_scale_t1/README.md
Comment thread feature/gribi/otg_tests/gribi_full_scale_t1/README.md
Comment thread feature/gribi/otg_tests/gribi_full_scale_t1/README.md
Comment thread feature/gribi/otg_tests/gribi_full_scale_t1/README.md Outdated
Comment thread feature/gribi/otg_tests/gribi_full_scale_t2/README.md Outdated
@gggsmith gggsmith force-pushed the gribi-scaling branch 4 times, most recently from 12cf3b3 to 5f80012 Compare February 24, 2026 12:00
@gggsmith gggsmith requested review from a team and dplore February 24, 2026 12:02
@gggsmith gggsmith assigned dplore and unassigned nikki-blr Feb 24, 2026
@gggsmith gggsmith requested a review from rohit-rp February 25, 2026 16:48
@gggsmith gggsmith assigned rohit-rp and unassigned dplore Feb 26, 2026
Comment thread feature/gribi/otg_tests/gribi_full_scale_t1/README.md Outdated
Comment thread feature/gribi/otg_tests/gribi_full_scale_t1/README.md Outdated
Comment thread feature/gribi/otg_tests/gribi_full_scale_t1/README.md Outdated
Comment thread feature/gribi/otg_tests/gribi_full_scale_t1/README.md
Comment thread feature/gribi/otg_tests/gribi_full_scale_t1/README.md Outdated
Comment thread feature/gribi/otg_tests/gribi_full_scale_t1/README.md
Comment thread feature/gribi/otg_tests/gribi_full_scale_t1/README.md Outdated
Comment thread feature/gribi/otg_tests/gribi_full_scale_t1/README.md
Comment thread feature/gribi/otg_tests/gribi_full_scale_t1/metadata.textproto Outdated
Comment thread feature/gribi/otg_tests/gribi_full_scale_t1/metadata.textproto
@gggsmith gggsmith force-pushed the gribi-scaling branch 2 times, most recently from 5449d74 to 0c6e28d Compare February 27, 2026 22:16
@gggsmith gggsmith assigned ram-mac and unassigned rohit-rp Mar 9, 2026
@gggsmith gggsmith force-pushed the gribi-scaling branch 2 times, most recently from 161ec33 to 34ddabf Compare March 11, 2026 10:31
Copy link
Copy Markdown
Contributor

@ram-mac ram-mac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gggsmith gggsmith merged commit 5b1e555 into openconfig:main Mar 12, 2026
15 checks passed
ampattan pushed a commit to nokia/featureprofiles that referenced this pull request Apr 1, 2026
nsadhasivam pushed a commit to nsadhasivam/featureprofiles that referenced this pull request Apr 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants