Updating the golden tcam configuration for Arista#5124
Updating the golden tcam configuration for Arista#5124ram-mac merged 4 commits intoopenconfig:mainfrom
Conversation
Summary of ChangesHello @ram-mac, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request updates the golden TCAM configuration for Arista devices, reflecting recent changes in the golden configuration file. The modifications primarily involve expanding the supported packet types for hardware TCAM, specifically adding GUE MPLS decap for IPv4 and IPv6, and enhancing IPv6 traffic policy by incorporating a destination port key field. Additionally, new hardware counter features have been enabled to provide more granular monitoring capabilities. Highlights
Changelog
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request updates the golden TCAM configuration for Arista devices within the aristaNGPRTcamProfile string. The changes include adding support for GUE/MPLS decap packets in QoS features, including dst-port in the key fields for IPv6 traffic policies, and enabling several hardware counters. The updates appear to be in line with the goal of evolving the device configuration. I have one suggestion to improve formatting consistency within the configuration string, aligning with the repository's guideline to maintain consistent code patterns.
* Updating the golden tcam configuration for Arista * fix formating * adding hop-limit to the policy
* Updating the golden tcam configuration for Arista * fix formating * adding hop-limit to the policy
The golden tcam configuration file for Arista has been change. b/476134024
Hence making changes