Fixing qos_basic_test for Arista

[ram-mac]

The qos_basic_test failure is caused by the Arista device failing to support the TransmitPkts state path.
-To fix this we need to enable the qos_get_state_path_unsupported deviation for Arista and update the test to skip DUT-side QoS counter checks when this deviation is active.
-Traffic verification via ATE will still be performed.

[gemini-code-assist]

Summary of Changes

Hello @ram-mac, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses a recurring failure in the "qos_basic_test" on Arista devices. The fix involves introducing a deviation to account for Arista's lack of support for the "TransmitPkts" state path, allowing the test to conditionally skip device-under-test (DUT) side QoS counter checks. This ensures the test can pass on Arista platforms while still validating traffic flow via ATE.

Highlights

• Arista QoS Test Fix: Enabled the "qos_get_state_path_unsupported" deviation specifically for Arista devices in the "qos_basic_test" metadata.
• Conditional QoS Counter Checks: Modified "qos_basic_test.go" to bypass DUT-side QoS counter verification (TransmitPkts, TransmitOctets, DroppedPkts, DroppedOctets) when the "qos_get_state_path_unsupported" deviation is active.
• ATE Traffic Verification: Ensured that traffic verification using ATE (Automated Test Equipment) remains active and is not affected by the changes, guaranteeing traffic flow integrity.

Changelog

• feature/qos/otg_tests/qos_basic_test/metadata.textproto
  • Added "qos_get_state_path_unsupported: true" to the deviations for Arista.
• feature/qos/otg_tests/qos_basic_test/qos_basic_test.go
  • Wrapped the initial QoS egress packet counter retrieval (before traffic) in a conditional block checking "!deviations.QosGetStatePathUnsupported(dut)".
  • Wrapped the QoS egress packet counter retrieval (after traffic) in a conditional block checking "!deviations.QosGetStatePathUnsupported(dut)".
  • Wrapped the QoS egress packet counter verification logic in a conditional block checking "!deviations.QosGetStatePathUnsupported(dut)".
  • Updated the "SkipSamplingQosCounters" check to also include "!deviations.QosGetStatePathUnsupported(dut)".

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[OpenConfigBot]

Pull Request Functional Test Report for #5126 / 92cccff

Virtual Devices

Device	Test	Test Documentation	Job	Raw Log
Arista cEOS		DP-1.14: QoS basic test	cd359d87	Log
Cisco 8000E		DP-1.14: QoS basic test	16daa640	Log
Cisco XRd		DP-1.14: QoS basic test	617d187e	Log
Juniper ncPTX		DP-1.14: QoS basic test	33eb1d32	Log
Nokia SR Linux		DP-1.14: QoS basic test	e966f709	Log
Openconfig Lemming		DP-1.14: QoS basic test	50418f36	Log

Hardware Devices

Device	Test	Test Documentation	Raw Log
Arista 7808		DP-1.14: QoS basic test
Cisco 8808		DP-1.14: QoS basic test
Juniper PTX10008		DP-1.14: QoS basic test
Nokia 7250 IXR-10e		DP-1.14: QoS basic test

Help

[gemini-code-assist]

Code Review

This pull request correctly addresses a test failure on Arista devices by introducing the qos_get_state_path_unsupported deviation. The changes in qos_basic_test.go appropriately use this deviation to conditionally skip DUT-side QoS counter checks, which is the correct approach. The implementation is sound.