Skip to content

Update test ID for TE-9.1#5135

Merged
AmrNJ merged 7 commits intomainfrom
AmrNJ-patch-2
Feb 27, 2026
Merged

Update test ID for TE-9.1#5135
AmrNJ merged 7 commits intomainfrom
AmrNJ-patch-2

Conversation

@AmrNJ
Copy link
Copy Markdown
Contributor

@AmrNJ AmrNJ commented Feb 25, 2026

Update test ID for TE-9.1 to match test_registry.textproto

@gemini-code-assist
Copy link
Copy Markdown
Contributor

Summary of Changes

Hello @AmrNJ, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on standardizing the test identifiers for the gRIBI MPLS compliance test suite. The changes ensure that the test IDs in the documentation and metadata files are consistent with the TE-9.1 designation, improving clarity and alignment with the test registry. This update primarily involves renumbering existing test cases to fit a more granular identification scheme.

Highlights

  • Test ID Standardization: The primary test ID for gRIBI MPLS Compliance has been updated from TE-9 to TE-9.1 across relevant files.
  • Sub-Test Renaming: All sub-tests within the MPLS compliance suite have been renumbered to follow the TE-9.1.x format, ensuring consistent identification.
  • Metadata Alignment: The plan_id in the metadata.textproto file was adjusted to reflect the new TE-9.1 identifier, matching the test_registry.textproto.
Changelog
  • feature/gribi/otg_tests/mpls_compliance/README.md
    • Updated the main test ID from TE-9 to TE-9.1 in the title.
    • Renamed sub-test TE-9.1 to TE-9.1.1.
    • Renamed sub-test TE-9.2 to TE-9.1.2.
    • Renamed sub-test TE-9.3 to TE-9.1.3.
    • Renamed sub-test TE-9.4 to TE-9.1.4.
    • Renamed sub-test TE-9.5 to TE-9.1.5.
  • feature/gribi/otg_tests/mpls_compliance/metadata.textproto
    • Updated the plan_id field from TE-9 to TE-9.1.
Activity
  • No activity has occurred on this pull request since its creation.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@OpenConfigBot
Copy link
Copy Markdown

OpenConfigBot commented Feb 25, 2026

Pull Request Functional Test Report for #5135 / 7064b53

Virtual Devices

Device Test Test Documentation Job Raw Log
Arista cEOS status
TE-9.1: gRIBI MPLS Compliance
1fb6b99f Log
Cisco 8000E status
TE-9.1: gRIBI MPLS Compliance
c0f0aca0 Log
Cisco XRd status
TE-9.1: gRIBI MPLS Compliance
3ed13529 Log
Juniper ncPTX status
TE-9.1: gRIBI MPLS Compliance
54acd629 Log
Nokia SR Linux status
TE-9.1: gRIBI MPLS Compliance
44160198 Log
Openconfig Lemming status
TE-9.1: gRIBI MPLS Compliance
eb441fd0 Log

Hardware Devices

Device Test Test Documentation Raw Log
Arista 7808 status
TE-9.1: gRIBI MPLS Compliance
Cisco 8808 status
TE-9.1: gRIBI MPLS Compliance
Juniper PTX10008 status
TE-9.1: gRIBI MPLS Compliance
Nokia 7250 IXR-10e status
TE-9.1: gRIBI MPLS Compliance

Help

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the test ID for TE-9.1 in the README.md and metadata.textproto files. The changes are consistent with the goal of the PR. However, the subtest names in the corresponding Go test file, gribi_mpls_compliance_test.go, were not updated to reflect these changes, creating an inconsistency with the test plan defined in the README.md. I've left a comment with details on the required changes to align the test code with the documentation.

Comment thread feature/gribi/otg_tests/mpls_compliance/README.md
@AmrNJ AmrNJ marked this pull request as ready for review February 25, 2026 16:22
@AmrNJ AmrNJ requested a review from a team as a code owner February 25, 2026 16:22
Copy link
Copy Markdown
Contributor

@ram-mac ram-mac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, this is needed to sync the testregistry.textproto

@AmrNJ AmrNJ merged commit 62b8e61 into main Feb 27, 2026
17 checks passed
@AmrNJ AmrNJ deleted the AmrNJ-patch-2 branch February 27, 2026 16:37
ampattan pushed a commit to nokia/featureprofiles that referenced this pull request Apr 1, 2026
* Update metadata.textproto

* Update README.md

* Update README.md

* Update gribi_mpls_compliance_test.go
nsadhasivam pushed a commit to nsadhasivam/featureprofiles that referenced this pull request Apr 6, 2026
* Update metadata.textproto

* Update README.md

* Update README.md

* Update gribi_mpls_compliance_test.go
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants