Conversation
kolyshkin
left a comment
There was a problem hiding this comment.
lgtm (with or without the freebsd pr)
b564385 to
2e3ca4f
Compare
|
@tianon @thaJeztah @dqminh PTAL |
tianon
left a comment
There was a problem hiding this comment.
I do wish we'd waited a little longer on FreeBSD, but it's good enough; LGTM
thaJeztah
left a comment
There was a problem hiding this comment.
🙈 sorry, thought I LGTM'd already, but had the tab still open 😆
LGTM
|
🎉 The release requirements have been met. 9/11 |
Signed-off-by: Akihiro Suda <akihiro.suda.cz@hco.ntt.co.jp>
Signed-off-by: Akihiro Suda <akihiro.suda.cz@hco.ntt.co.jp>
2e3ca4f to
9d0d4bc
Compare
|
Rebased to include |
|
I guess that's fine but technically according to GOVERNANCE the release request is for a specific commit so maybe let's avoid doing that in the future? (It also says that we need to do votes by email, we should probably update that...) Did you want to prepare the release artefacts @AkihiroSuda? |
It seems an "example" "usually" Lines 66 to 68 in 6acd32d Lines 55 to 73 in 6acd32d
Can we relax this rule?
"SHOULD", not "MUST" Line 11 in 6acd32d
Yes |
We can definitely have a discussion about it, but in my view the reason for the rule is to:
If we feel that these are not practical problems then we can relax this rule, but then it's not clear to me what purpose the 2/3rd majority would serve -- yes, if maintainers object to a release happening at all then it will be blocked, but if they agree to a release then you only need 2 LGTMs to merge something else and rebase the PR. In that case we might as well just only require 2 LGTMs for releases (like we do in runc now) and simply provide an opportunity for other maintainers to voice concerns before we release. Personally I think the spec repos should be more strict about governance rules than repos like runc and umoci, purely because once we ship something in a spec it is far more permanent than in software projects. But again, I don't think anyone would object to #1304 being included, this is more of a meta-point about the process.
Sure, and I don't mind doing it on GitHub instead but (again) the general flow is meant to be that we have a specific commit we are voting on -- while this information is theoretically provided by GitHub we don't make use of the "dismiss stale reviews" feature in this repo. Obviously if we drop this requirement then this doesn't matter either. |
|
Agreed/seconded that #1304 is fine and that we should avoid that in the future without resetting the vote. |
|
BTW, who's going to handle preparing the release blog post? |
Shall I write it, or is anybody interested in? |
|
I'm busy this month because I have my wedding 🙏 I might do the next release. |
Congratulations ㊗️ |
|
Merging to unblock runc v1.4 and will draft the blog ASAP. |
Fix #1295
This release requires a two-thirds majority maintainers vote (8 of 11).
The voting will close at Tue Nov 4 05:00:00 UTC 2025.