config: Require hook support on Linux and Solaris#870
Merged
crosbymichael merged 2 commits intoopencontainers:masterfrom Jun 1, 2017
Merged
config: Require hook support on Linux and Solaris#870crosbymichael merged 2 commits intoopencontainers:masterfrom
crosbymichael merged 2 commits intoopencontainers:masterfrom
Conversation
Not all hooks are run after creation. In fact, there are currently no postcreate hooks (prestart hooks are called "after the start operation is called but before the user-specified program command is executed". Fixing 28e8f68 (Hooks to linux,solaris and doc clarification, 2017-05-24, opencontainers#855), which pulled the broken line in from a Go comment [1]. [1]: opencontainers#855 (comment) Signed-off-by: W. Trevor King <wking@tremily.us>
Clarifying the language from 28e8f68 (Hooks to linux,solaris and doc clarification, 2017-05-24, opencontainers#855), which did not say which platforms support hooks and which don't. Without something like this commit, there's no clear way for config authors to know if their runtime will support hooks or not, and there was previous agreement that that sort of ambiguity was not helpful [1]. This also gives normative Markdown grounding for the Go platform tag added in 28e8f68. [1]: opencontainers#472 (comment) Signed-off-by: W. Trevor King <wking@tremily.us>
Member
|
LGTM |
1 similar comment
Contributor
|
LGTM |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This builds on #869, so review that one first.
Clarifying the language from #855 according to this comment. Without something like this commit, there's no clear way for config authors to know if their runtime will support hooks or not, and there was previous agreement that that sort of ambiguity was not helpful. This also gives normative Markdown grounding for the Go platform tag added in 28e8f68.