config-linux: add SHOULD to linux.namespaces.type#931
config-linux: add SHOULD to linux.namespaces.type#931zhouhao3 wants to merge 2 commits intoopencontainers:masterfrom
Conversation
Signed-off-by: zhouhao <zhouhao@cn.fujitsu.com>
| The following parameters can be specified to set up namespaces: | ||
|
|
||
| * **`type`** *(string, REQUIRED)* - namespace type. The following namespace types are supported: | ||
| * **`type`** *(string, REQUIRED)* - namespace type. The following namespace types SHOULD be supported: |
There was a problem hiding this comment.
In the runtime-spec PR, you're claiming a config validation, but the "supported" language here sounds like it targets the runtime. How about:
Configuration SHOULD use, and runtimes SHOULD support, the following types:
Personally, I'd prefer MUSTing runtime support (more in #813), but even SHOULD would better than the current lack of RFC 2119 language.
|
house keeping: I think the current vague language is being leveraged to not require certain kernel versions and features. Making this into RFC language LGTM |
|
LGTM ... however, this is conflicting now and needs a rebase 😞 |
|
i've just messed this PR up, by trying to "fix" the commit within github .... |
|
see #1025 |
4 participants
In the opencontainers/runtime-tools#486 appeared in this problem, I think this will be better to modify.
Signed-off-by: zhouhao zhouhao@cn.fujitsu.com