config: Dedent root paragraphs, since they aren't a list entry#936
Merged
crosbymichael merged 1 commit intoopencontainers:masterfrom Nov 10, 2017
Merged
config: Dedent root paragraphs, since they aren't a list entry#936crosbymichael merged 1 commit intoopencontainers:masterfrom
crosbymichael merged 1 commit intoopencontainers:masterfrom
Conversation
I'd broken this in 2022e3e (config: Bump Hyper-V condition from root.path to root itself, 2017-05-18, opencontainers#838), where I'd misread the initial bolding ** as a list bullet or something. The extra indents don't cause a problem for the first paragraph, but they cause the "On all other platforms..." paragraph to be interpreted as a <pre> block. Signed-off-by: W. Trevor King <wking@tremily.us>
Contributor
|
LGTM |
1 similar comment
Member
|
LGTM |
Closed
wking
added a commit
to wking/opencontainer-runtime-spec
that referenced
this pull request
Dec 1, 2017
Like 5d9bbad (config: Dedent root paragraphs, since they aren't a list entry, 2017-11-08, opencontainers#936). Ma Shimiao pointed out that there may be more instances of this [1], and this commit fixes all instances turned up with: $ git grep -B1 '^ [^ ]' | grep -A1 '[:-]\*\*' [1]: opencontainers#934 (comment) Signed-off-by: W. Trevor King <wking@tremily.us>
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'd broken this in 2022e3e (#838), where I'd misread the initial bolding
**as a list bullet or something :/. The extra indents don't cause a problem for the first paragraph, but they cause the “On all other platforms…” paragraph to be interpreted as a<pre>block.