Add RUNTIME_TOOLS_LINK in Makefile#262
Merged
vbatts merged 1 commit intoopencontainers:masterfrom Nov 3, 2016
Merged
Conversation
So we can build runtime_tools project anyway. Signed-off-by: Qiang Huang <h.huangqiang@huawei.com>
hqhq
force-pushed
the
add_runtime_tools_link
branch
from
18b7cfd to
a597474
Compare
wking
reviewed
Oct 29, 2016
Makefile
Outdated
| rm -f $(RUNTIME_TOOLS_LINK) | ||
|
|
||
| $(RUNTIME_TOOLS_LINK): | ||
| ln -sfn $(CURDIR) $(RUNTIME_TOOLS_LINK) |
Contributor
There was a problem hiding this comment.
-n is not in POSIX. Do we really need it to support this use-case?
Contributor
|
This feels sort of like opencontainers/image-tools#52. runtime-tools
builds fine as it stands if you've checked it out to an appropriate
location in your $GOPATH.
|
hqhq
force-pushed
the
add_runtime_tools_link
branch
from
a597474 to
12c0532
Compare
Contributor
Author
|
@wking It's ok we don't use It makes it more convenient like what we did in runc. |
wking
reviewed
Oct 30, 2016
| BINDIR ?= $(DESTDIR)/usr/bin | ||
|
|
||
| BUILDTAGS= | ||
| RUNTIME_TOOLS_LINK := $(CURDIR)/Godeps/_workspace/src/github.com/opencontainers/runtime-tools |
Contributor
There was a problem hiding this comment.
Does this approach confuse godep save, godep update and such? Maybe it would be better to setup a second tree:
LOCAL_GOPATH := $(CURDIR)/_workspace
RUNTIME_TOOLS_LINK := $(LOCAL_GOPATH)/src/github.com/opencontainers/runtime-tools
export GOPATH:=$(LOCAL_GOPATH):$(CURDIR)/Godeps/_workspace:$(GOPATH)
Contributor
|
LGTM |
Contributor
|
LGTM |
1 similar comment
Member
|
LGTM |
Member
|
@caniszczyk FYI @mrunalp's LGTM did not trigger pullapprove |
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
So we can build runtime_tools project anyway.
Signed-off-by: Qiang Huang h.huangqiang@huawei.com