Form: require user opt-in, and present the user with a summary of, browser/device info collection#24
Merged
jayaddison merged 9 commits intomainfrom Apr 6, 2026
Conversation
This is required because the HTML DOM of the `Form` page contents is cleared before the `data()` function is called. If we do not store the element in a long-lived variable, then when we run a query to find the `#browser-info-consent` HTML element before the form is submitted, then we will not find it.
…2/browser-data-require-opt-in Conflicts: dist/feedback.js dist/feedback.min.js src/pages/Form.js
… from non-EN locales The fallback logic in the `i18n` module should handle selection of the default (EN) version when a string is not present in other locales.
…2/browser-data-require-opt-in Conflicts: dist/feedback.js dist/feedback.min.js src/pages/Form.js
Member
Author
|
Member
Author
This functionality is now included; at the review stage, the user is presented with the message text that they provided (if any), the browser-info collected (hidden by default, but expandable inside a See below for an example of this review stage where browser information is included: 
|
Base automatically changed from
issue-21/configurable-browser-info-fields
to
main
April 6, 2026 15:36
jayaddison
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe the reason for these changes and the problem that they solve
As described in #22, it is preferable to inform users about collection of information from their web browser environment before including it with their form submission, and the default should be that that information is not collected unless they consent/agree to doing that.
Briefly summarize the changes
Formpage in the feedback collection workflow.How have the changes been tested?
Screenshots
List any issues that this change relates to
Resolves #22.
Builds-upon pull request #23.