feat: History log in content library components and containers [FC-0123]#2948
feat: History log in content library components and containers [FC-0123]#2948ChrisChV wants to merge 6 commits intoopenedx:masterfrom
Conversation
|
Thanks for the pull request, @ChrisChV! This repository is currently maintained by Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review. 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. DetailsWhere can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources: When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2948 +/- ##
==========================================
+ Coverage 95.47% 95.48% +0.01%
==========================================
Files 1383 1387 +4
Lines 32642 32838 +196
Branches 7498 7309 -189
==========================================
+ Hits 31165 31356 +191
- Misses 1408 1426 +18
+ Partials 69 56 -13 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| import { ComponentAdvancedInfo } from './ComponentAdvancedInfo'; | ||
| import { ComponentUsage } from './ComponentUsage'; | ||
| import messages from './messages'; | ||
| import { HistoryComponentLog } from '../generic/history-log/HistoryLog'; |
There was a problem hiding this comment.
nit
| import { HistoryComponentLog } from '../generic/history-log/HistoryLog'; | |
| import { HistoryComponentLog } from '@src/generic/history-log/HistoryLog'; |
There was a problem hiding this comment.
This would not be correct; it's the generic for library-authoring, not the generic for src.
| )} | ||
| {creationEntry && ( | ||
| <HistoryCreatedLogGroup | ||
| user={creationEntry.changedBy.username} |
There was a problem hiding this comment.
@ChrisChV I have some components that crash as changeBy is undefined for them, is this expected? We should probably have a placeholder avatar and user in this case no?
625d241 to
0ad4c1a
Compare
Description
See openedx/openedx-platform#38178 to understand the Pre-Verawood and Post-Verawood logic.
HistoryCreatedLogGroup: Group for the create event.HistoryDraftLogGroup: Group and entries for draft changes (collapsible).HistoryPublishLogGroup: Group and entries for published changes (lazy-loaded on expand).HistoryComponentLog: Renders the full history for a library component.HistoryContainerLog: Renders the full history for a library container (unit/section/subsection).ContainerDetails: New "Details" tab in the container sidebar that shows the container history log.Supporting information
history logapi functions [FC-0123] openedx-core#501Testing instructions
Follow the instructions in order:
Pre-Verawood setup
mainbranch.Test Components: Pre-Verawood
history logapi functions [FC-0123] openedx-core#501git revert 2d5a17b. Reinstall the repo in your instance.Detailstab of the sidebar.** Test Containers: Pre-Verawood**
Detailstab of the sidebar.Post-Verawood setup
Test Components: Post-Verawood
Detailstab of the sidebar.Test Containers: Post-Verawood
Detailstab of the sidebar.To test with more contributors
Other information
Missing features
Note: The basics have been implemented to meet the Verawood cut on time.
Best Practices Checklist
We're trying to move away from some deprecated patterns in this codebase. Please
check if your PR meets these recommendations before asking for a review:
.ts,.tsx).propTypesanddefaultPropsin any new or modified code.src/testUtils.tsx(specificallyinitializeMocks)apiHooks.tsin this repo for examples.messages.tsfiles have adescriptionfor translators to use.../in import paths. To import from parent folders, use@src, e.g.import { initializeMocks } from '@src/testUtils';instead offrom '../../../../testUtils'