Skip to content

feanil/update w claude#39

Open
feanil wants to merge 2 commits intomainfrom
feanil/update_w_claude
Open

feanil/update w claude#39
feanil wants to merge 2 commits intomainfrom
feanil/update_w_claude

Conversation

@feanil
Copy link
Contributor

@feanil feanil commented Mar 24, 2026

  • feat: Run the backstage upgrade.
  • fix: Restore GitHub sign-in requirement after frontend architecture upgrade

feanil and others added 2 commits March 24, 2026 15:22
…pgrade

The upgrade to Backstage 1.49.x migrated the frontend from the legacy
`@backstage/app-defaults` architecture to the new declarative frontend
system using `@backstage/frontend-defaults`. As part of that migration,
App.tsx was reduced from ~109 lines to 7, and the explicit GitHub
sign-in page configuration was dropped along with the old boilerplate.

In the old system, the sign-in page was overridden via the `components`
option of `createApp` (see the pre-upgrade App.tsx):

  https://github.com/openedx/openedx-backstage/blob/e66d00a/packages/app/src/App.tsx#L38-L50

  components: {
    SignInPage: props => <SignInPage {...props} auto providers={[githubProvider]} />
  }

In the new declarative frontend system this override is done via a
`SignInPageBlueprint` extension from `@backstage/plugin-app-react`:

  https://backstage.io/docs/frontend-system/architecture/extensions

Without this, the new system fell back to attempting guest sign-in,
which fails because guest is explicitly disabled in app-config.yaml
(`guest: null`). The error was:

  "You cannot sign in as a guest, you must either enable the legacy
   guest token or configure the auth backend to support guest sign in."

The fix creates a `signInPage` extension in `modules/nav/SignIn.tsx`
using `SignInPageBlueprint` with `githubAuthApiRef` (now exported from
`@backstage/frontend-plugin-api` rather than `@backstage/core-plugin-api`)
requiring openedx org membership, and registers it in `navModule`
alongside `SidebarContent`.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@feanil feanil requested a review from e0d March 24, 2026 19:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant