feat: add authz permission for the course authoring list#38199
feat: add authz permission for the course authoring list#38199dwong2708 wants to merge 8 commits intoopenedx:masterfrom
Conversation
|
Thanks for the pull request, @dwong2708! This repository is currently maintained by Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review. 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. DetailsWhere can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources: When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
25142ea to
96b100a
Compare
rodmgwgu
left a comment
There was a problem hiding this comment.
It's looking good so far, just some comments
| COURSES_VIEW_COURSE.identifier | ||
| ) | ||
|
|
||
| authz_keys = { |
There was a problem hiding this comment.
We will need to update this once openedx/openedx-authz#225 is merged to support org level scopes (OrgGlobData).
Please create a Github issue for this if it's not already there.
| # user has global access so no need to get courses from django groups | ||
| courses, in_process_course_actions = _accessible_courses_summary_iter(request) | ||
| user = request.user | ||
| is_staff_user = GlobalStaff().has_user(user) or user.is_superuser |
There was a problem hiding this comment.
Isn't GlobalStaff().has_user(user) already checking for user.is_superuser?
| # and defer fetching the full course objects until after filtering by access | ||
| candidate_keys = CourseOverview.get_all_courses().values_list("id", flat=True) | ||
| # Compute actions once for staff users since they have access to all courses | ||
| in_process_actions = get_in_process_course_actions(request) |
There was a problem hiding this comment.
I see that get_in_process_course_actions is validating internally with user_has_course_permission,
But if we already know it's a staff user, do we need to do that?
Or are we using get_in_process_course_actions elsewhere and don't want to break something?
78bf785 to
3cba95e
Compare
Refactor course access listing to single-pass hybrid AuthZ + legacy approach
Summary
This PR refactors get_courses_accessible_to_user to improve performance, readability, and maintainability by introducing a single-pass hybrid access evaluation model.
Instead of splitting courses into separate AuthZ and legacy pipelines and merging results afterward, this implementation evaluates access per course in a single pass, then performs a single batched query to retrieve the final course list.
Key Improvements
Single-pass access evaluation
-
user_has_course_permission(...)Scoped full scan to staff users only
Deferred object fetching
Centralized filtering and ordering
Improved readability and maintainability
Testing Notes
Deadline
Verawood
Other information
Resolves: openedx/openedx-authz#190