Skip to content

Decode bundle images on demand #2042

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Tutez64 wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

Decode bundle images on demand #2042

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
97a9eef
Decode bundle images on demand
Tutez64 Mar 23, 2026
7266556
Use dedicated cache for on-demand bundle image bytes
Tutez64 Apr 18, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 16 additions & 6 deletions src/lime/utils/AssetLibrary.hx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,7 @@ class AssetLibrary
@:noCompletion private var cachedAudioBuffers = new Map<String, AudioBuffer>();
@:noCompletion private var cachedBytes = new Map<String, Bytes>();
@:noCompletion private var cachedFonts = new Map<String, Font>();
@:noCompletion private var cachedImageBytes = new Map<String, Bytes>();
@:noCompletion private var cachedImages = new Map<String, Image>();
@:noCompletion private var cachedText = new Map<String, String>();
@:noCompletion private var classTypes = new Map<String, Class<Dynamic>>();
Expand Down Expand Up @@ -273,6 +274,13 @@ class AssetLibrary
{
return cachedImages.get(id);
}
else if (cachedImageBytes.exists(id))
{
var image = Image.fromBytes(cachedImageBytes.get(id));
cachedImageBytes.remove(id);
cachedImages.set(id, image);
return image;
}
else if (classTypes.exists(id))
{
#if flash
Expand Down Expand Up @@ -337,11 +345,11 @@ class AssetLibrary
return switch (cast(type, AssetType))
{
case null:
cachedBytes.exists(id) || cachedText.exists(id) || cachedImages.exists(id)
cachedBytes.exists(id) || cachedText.exists(id) || cachedImageBytes.exists(id) || cachedImages.exists(id)
|| cachedAudioBuffers.exists(id) || cachedFonts.exists(id);

case IMAGE:
cachedImages.exists(id);
cachedImages.exists(id) || cachedImageBytes.exists(id);

case MUSIC, SOUND:
cachedAudioBuffers.exists(id);
Expand Down Expand Up @@ -568,11 +576,11 @@ class AssetLibrary
{
return Future.withValue(Type.createInstance(classTypes.get(id), []));
}
else if (cachedBytes.exists(id))
else if (cachedImageBytes.exists(id))
{
return Image.loadFromBytes(cachedBytes.get(id)).then(function(image)
return Image.loadFromBytes(cachedImageBytes.get(id)).then(function(image)
{
cachedBytes.remove(id);
cachedImageBytes.remove(id);
cachedImages.set(id, image);
return Future.withValue(image);
});
Expand Down Expand Up @@ -616,12 +624,14 @@ class AssetLibrary
#if haxe4
cachedBytes.clear();
cachedFonts.clear();
cachedImageBytes.clear();
cachedImages.clear();
cachedAudioBuffers.clear();
cachedText.clear();
#else
cachedBytes = new Map<String, Bytes>();
cachedFonts = new Map<String, Font>();
cachedImageBytes = new Map<String, Bytes>();
cachedImages = new Map<String, Image>();
cachedText = new Map<String, String>();
classTypes = new Map<String, Class<Dynamic>>();
Expand Down Expand Up @@ -692,7 +702,7 @@ class AssetLibrary
{
#if !web
case IMAGE:
cachedImages.set(id, Image.fromBytes(data));
cachedImageBytes.set(id, data);
case MUSIC, SOUND:
cachedAudioBuffers.set(id, AudioBuffer.fromBytes(data));
case FONT:
Expand Down
Loading