Fix Safari name label blurriness by avoiding scaled text transforms#3115
Fix Safari name label blurriness by avoiding scaled text transforms#3115Aotumuri wants to merge 1 commit intoopenfrontio:mainfrom
Conversation
|
|
WalkthroughThis change adds Safari browser detection and a crisp text rendering mode to NameLayer.ts. It enables pixel-snapped text rendering in Safari by adjusting container positioning, tracking scale changes, and applying per-element transforms conditionally based on the browser. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~12 minutes Possibly related issues
Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Important Action Needed: IP Allowlist UpdateIf your organization protects your Git platform with IP whitelisting, please add the new CodeRabbit IP address to your allowlist:
Reviews will stop working after February 8, 2026 if the new IP is not added to your allowlist. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Is there a performance impact like in a previous PR and how does it do compared to baseline? |
@VariableVince That said, I don’t believe this PR introduces a performance regression like the one discussed in #1990. |
|
i dont like having browser specific solutions, will cause problems later. |
Yes but this is a specific Safari thing by how they handle things. Would there be a better approach to this? |
Description:
Safari only: render name labels in screen space with scaled font sizes instead of CSS scale(), improving text sharpness
Keep non‑Safari behavior unchanged
before

after

Please complete the following:
Please put your Discord username so you can be contacted if a bug or regression is found:
aotumuri