8240908: RetransformClass does not know about MethodParameters attribute

[jpbempel]

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• JDK-8240908 needs maintainer approval

Issue

• JDK-8240908: RetransformClass does not know about MethodParameters attribute (Bug - P3 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/4265/head:pull/4265
$ git checkout pull/4265

Update a local copy of the PR:
$ git checkout pull/4265
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/4265/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 4265

View PR using the GUI difftool:
$ git pr show -t 4265

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/4265.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back jpbempel! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@jpbempel This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8240908: RetransformClass does not know about MethodParameters attribute

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 59 new commits pushed to the master branch:

• 76fd33a: 8373869: Refactor java/net/httpclient/ThrowingPushPromises*.java tests to use JUnit5
• 43b64a0: 8373807: test/jdk/java/net/httpclient/websocket/DummyWebSocketServer.java getURI() uses "localhost"
• 41fc4b3: 8334928: Test sun/security/ssl/SSLSocketImpl/ReuseAddr.java failed: java.net.BindException: Address already in use
• ... and 56 more: https://git.openjdk.org/jdk17u-dev/compare/a6a89d91088c53110b5f4736d8815098b6a34554...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[openjdk]

This backport pull request has now been updated with issue from the original commit.

[mlbridge]

Webrevs

• 00: Full (ac6c0f65)

[openjdk]

⚠️ @jpbempel This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

[GoeLin]

Hi @jpbempel
can you please do dependent pull request for the follow-up issues?
I ran your change through our testing and the new test fails.
Thanks.

[kriegaex]

@GoeLin, I am just an interested spectator here, I hope it is OK to ask some questions:

1. Where can I see the results of your failed tests to find out what exactly went wrong? The build checks here seem to indicate no errors.
2. Why a "dependent pull request", whatever that may mean to you? Is it not easier to just update this PR by either force-pushing an improved version or just committing fixes on top of it?

[jpbempel]

Hi @jpbempel can you please do dependent pull request for the follow-up issues? I ran your change through our testing and the new test fails. Thanks.

I ran locally tier1 and only this test is failing: java/util/Locale/PreserveTagCase.java
But it fails without my change on master.
Please provide more information on fail tests on your side

[GoeLin]

Hi @jpbempel
The JBS issue lists as related issuee JDK-8281243 Test java/lang/instrument/RetransformWithMethodParametersTest.java is failing
You need to backport that on top of this change, a so called "dependend pull request":
check out origin/pr/4265, make a new branch backport_8281243 on top, push that branch and compare to 4265 in the PR.

[jpbempel]

@GoeLin made the dependent PR here: #4300

[GoeLin]

Hi @jpbempel
I think you can now request approval for this and the follow-up. I will approve them.

[jpbempel]

/approval 8240908 request

[openjdk]

@jpbempel
8240908: The approval request has been created successfully.

[jpbempel]

/integrate

[openjdk]

@jpbempel
Your change (at version ac6c0f6) is now ready to be sponsored by a Committer.

[phohensee]

/sponsor

[openjdk]

Going to push as commit ccd93e9.
Since your change was applied there have been 60 commits pushed to the master branch:

• dd0f81f: 8377678: G1: Heap Dumping crashes with -UseClassUnloading
• 76fd33a: 8373869: Refactor java/net/httpclient/ThrowingPushPromises*.java tests to use JUnit5
• 43b64a0: 8373807: test/jdk/java/net/httpclient/websocket/DummyWebSocketServer.java getURI() uses "localhost"
• ... and 57 more: https://git.openjdk.org/jdk17u-dev/compare/a6a89d91088c53110b5f4736d8815098b6a34554...master

Your commit was automatically rebased without conflicts.

[openjdk]

@phohensee @jpbempel Pushed as commit ccd93e9.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.