8378519: [lworld] Fold fieldDescriptor / ResolvedFieldEntry checks into the FlatFieldPayload constructor

[xmas92]

Right now some of the call sites assets that ResolvedFieldEntry corresponds to the correct fieldDescriptor, and that these fields are in fact flattened. It was suggested that this would be more robust if this was folded into the construction of the FlatFieldPayload construction.

I moved these asserts up the construction hierarchy so that we also verify the unsafe flat field access. Because these can access nested flat values, some extra utility was added to find nested flat fields from an offset.

After this change the FlatFieldPayload check that the fieldDescriptor* constructor and the ResolvedFieldEntry* is a valid non-nested flat field in the containing object.

And the FlatValuePayload::construct_from_parts verifies that there is an field at that offset of of the correct InlineKlass. (Either a direct field or array element, or a nested flat field inside an flat field or array element)

Also the unsafe access logging was missing a ResourceMark, and changed it so it does not assert on bad offset, as I moved the assertions into the FlatValuePayload construction.

Testing:

• Running tier 1 - 4 with --enable-preview
• Running all Valhalla tests

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed (1 review required, with at least 1 Committer)

Issue

• JDK-8378519: [lworld] Fold fieldDescriptor / ResolvedFieldEntry checks into the FlatFieldPayload constructor (Enhancement - P4)

Reviewers

• Frederic Parain (@fparain - Committer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/valhalla.git pull/2186/head:pull/2186
$ git checkout pull/2186

Update a local copy of the PR:
$ git checkout pull/2186
$ git pull https://git.openjdk.org/valhalla.git pull/2186/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2186

View PR using the GUI difftool:
$ git pr show -t 2186

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/valhalla/pull/2186.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back aboldtch! A progress list of the required criteria for merging this PR into lworld will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@xmas92 This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8378519: [lworld] Fold fieldDescriptor / ResolvedFieldEntry checks into the FlatFieldPayload constructor

Reviewed-by: fparain

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 125 new commits pushed to the lworld branch:

• 4b6a580: 8379328: [lworld] [BACKOUT] JNI NewWeakGlobalRef should throw IdentityException for value types
• a2f9166: 8379007: [lworld] JNI NewWeakGlobalRef should throw IdentityException for value types
• 9c53e9a: 8378184: [lworld] JDK - Cleanup accidental diffs with master - step 1
• ... and 122 more: https://git.openjdk.org/valhalla/compare/c5277c485daa0a83de4be6b70c5c1c79a5e0015a...lworld

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the lworld branch, type /integrate in a new comment.

[mlbridge]

Webrevs

• 01: Full - Incremental (a313cba8)
• 00: Full (1f90c232)

[fparain]

Looks good to me.

[xmas92]

Thanks for the review. Re-ran tests with the latests lworld merged.
/integrate

[openjdk]

Going to push as commit f9799f4.
Since your change was applied there have been 230 commits pushed to the lworld branch:

• adb1cb8: 8379592: [lworld] EA3 version flick
• d1b73f7: Merge
• a3b468c: 8379119: G1: Move NoteStartOfMarkHRClosure out of global namespace
• ... and 227 more: https://git.openjdk.org/valhalla/compare/c5277c485daa0a83de4be6b70c5c1c79a5e0015a...lworld

Your commit was automatically rebased without conflicts.

[openjdk]

@xmas92 Pushed as commit f9799f4.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.