Skip to content

8378523: [lworld] Remove post-barriers from CardTableBarrierSet value_store_null_in_heap#2199

Closed
xmas92 wants to merge 1 commit intoopenjdk:lworldfrom
xmas92:JDK-8378523
Closed

8378523: [lworld] Remove post-barriers from CardTableBarrierSet value_store_null_in_heap#2199
xmas92 wants to merge 1 commit intoopenjdk:lworldfrom
xmas92:JDK-8378523

Conversation

@xmas92
Copy link
Copy Markdown
Member

@xmas92 xmas92 commented Mar 5, 2026

Remove the post barriers when clearing a flat field / element. All contained oops will be null, no cards need to be dirtied.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed (1 review required, with at least 1 Committer)

Issue

  • JDK-8378523: [lworld] Remove post-barriers from CardTableBarrierSet value_store_null_in_heap (Enhancement - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/valhalla.git pull/2199/head:pull/2199
$ git checkout pull/2199

Update a local copy of the PR:
$ git checkout pull/2199
$ git pull https://git.openjdk.org/valhalla.git pull/2199/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2199

View PR using the GUI difftool:
$ git pr show -t 2199

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/valhalla/pull/2199.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link
Copy Markdown

bridgekeeper Bot commented Mar 5, 2026

👋 Welcome back aboldtch! A progress list of the required criteria for merging this PR into lworld will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link
Copy Markdown

openjdk Bot commented Mar 5, 2026

@xmas92 This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8378523: [lworld] Remove post-barriers from CardTableBarrierSet value_store_null_in_heap

Reviewed-by: stefank

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 128 new commits pushed to the lworld branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the lworld branch, type /integrate in a new comment.

@openjdk openjdk Bot added the rfr Pull request is ready for review label Mar 5, 2026
@mlbridge
Copy link
Copy Markdown

mlbridge Bot commented Mar 5, 2026

Webrevs

@openjdk openjdk Bot added the ready Pull request is ready to be integrated label Mar 5, 2026
@xmas92
Copy link
Copy Markdown
Member Author

xmas92 commented Mar 9, 2026

Thanks for the review.
/integrate

@openjdk
Copy link
Copy Markdown

openjdk Bot commented Mar 9, 2026

Going to push as commit 677ef96.
Since your change was applied there have been 131 commits pushed to the lworld branch:

Your commit was automatically rebased without conflicts.

@openjdk openjdk Bot added the integrated Pull request has been integrated label Mar 9, 2026
@openjdk openjdk Bot closed this Mar 9, 2026
@openjdk openjdk Bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Mar 9, 2026
@openjdk
Copy link
Copy Markdown

openjdk Bot commented Mar 9, 2026

@xmas92 Pushed as commit 677ef96.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

2 participants