8378521: [lworld] Completely remove pre-barriers in CardTableBarrierSet when IS_DEST_UNINITIALIZED for value stores

[xmas92]

For IS_DEST_UNINITIALIZED it would never be valid for the CardTableBarrierSet to do a pre-barrier. Currently value_copy_in_heap and value_store_null_in_heap both iterates the oops and virtually calls into the barriers sets pre barriers (of which all implementations are no-ops for uninitialized values).

Remove this as part of the CardTableBarrierSet interface. After this is integrated I will upstream the relevant changes of this patch to mainline.

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed (1 review required, with at least 1 Committer)

Issue

• JDK-8378521: [lworld] Completely remove pre-barriers in CardTableBarrierSet when IS_DEST_UNINITIALIZED for value stores (Enhancement - P4)

Reviewers

• Stefan Karlsson (@stefank - Committer) ⚠️ Review applies to 5aa91dde

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/valhalla.git pull/2200/head:pull/2200
$ git checkout pull/2200

Update a local copy of the PR:
$ git checkout pull/2200
$ git pull https://git.openjdk.org/valhalla.git pull/2200/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2200

View PR using the GUI difftool:
$ git pr show -t 2200

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/valhalla/pull/2200.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back aboldtch! A progress list of the required criteria for merging this PR into lworld will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@xmas92 This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8378521: [lworld] Completely remove pre-barriers in CardTableBarrierSet when IS_DEST_UNINITIALIZED for value stores

Reviewed-by: stefank

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the lworld branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the lworld branch, type /integrate in a new comment.

[mlbridge]

Webrevs

• 02: Full (005fcfd6)
• 01: Full - Incremental (5aa91dde)
• 00: Full (f3461723)

[stefank]

Thanks for doing this change! I have a style thought below:

[stefank]

Looks good. Thanks.

[xmas92]

Thanks for the review.
/integrate

[openjdk]

Going to push as commit 9024b8e.
Since your change was applied there have been 2 commits pushed to the lworld branch:

• fe20cb7: 8375357: [lworld] compiler/valhalla/inlinetypes/TestLWorld.java subtests fail with Method not compilable
• 150bc81: 8378086: [lworld] duplication between ObjArrayKlass and refined classes

Your commit was automatically rebased without conflicts.

[openjdk]

@xmas92 Pushed as commit 9024b8e.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.