8379365: [lworld] Add new JNI method IsValueObject(jobject value)

[dholmes-ora]

This PR adds a new JNI IsValueObject method so that native code can query is an object is an instance of a value class.

This will require a bump of the JNI version number once we are out of preview.

Added a simple functional test.

Manually tested with -Xcheck:jni as well

tiers 1-3 sanity testing

Thanks

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed (1 review required, with at least 1 Committer)

Issue

• JDK-8379365: [lworld] Add new JNI method IsValueObject(jobject value) (Enhancement - P3)

Reviewers

• Paul Hübner (@Arraying - Committer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/valhalla.git pull/2203/head:pull/2203
$ git checkout pull/2203

Update a local copy of the PR:
$ git checkout pull/2203
$ git pull https://git.openjdk.org/valhalla.git pull/2203/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2203

View PR using the GUI difftool:
$ git pr show -t 2203

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/valhalla/pull/2203.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back dholmes! A progress list of the required criteria for merging this PR into lworld will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@dholmes-ora This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8379365: [lworld] Add new JNI method IsValueObject(jobject value)

Reviewed-by: phubner

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 108 new commits pushed to the lworld branch:

• 12012cc: 8378862: [lworld] flatArrayKlass::copy_array is missing a memory barrier when copying from flat array to non-flat array
• 432870d: 8379184: [lworld] Cleanup fieldLayoutBuilder.cpp to remove get_size_and_alignment
• f9799f4: 8378519: [lworld] Fold fieldDescriptor / ResolvedFieldEntry checks into the FlatFieldPayload constructor
• ... and 105 more: https://git.openjdk.org/valhalla/compare/4b6a580c6961df385e86689288745d0ed0bcf0b5...lworld

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the lworld branch, type /integrate in a new comment.

[mlbridge]

Webrevs

• 03: Full - Incremental (c3ee772f)
• 02: Full - Incremental (c7a5746f)
• 01: Full - Incremental (bfe45d71)
• 00: Full (b60731dc)

[dholmes-ora]

Reverted the version change as that comes after the preview cycle.
Added test case files.
Added DTrace probes

[Arraying]

Thanks for the work! The test and change looks good, I left a question to make sure that we are considering the correct semantics.

[Arraying]

Looks good! Sorry for the confusion.

[dholmes-ora]

/integrate

[openjdk]

Going to push as commit b9a1691.
Since your change was applied there have been 112 commits pushed to the lworld branch:

• 31b780b: 8379803: [lworld] Clean up redundant diffs in langtool tests - 1
• 56caf4a: 8379355: [lworld] Improve test coverage of fields layouts and substitutability test with randomly generated classes
• f81526c: 8378531: [lworld] Remove obj_at(int) from objArrayOopDesc and flatArrayOopDesc
• ... and 109 more: https://git.openjdk.org/valhalla/compare/4b6a580c6961df385e86689288745d0ed0bcf0b5...lworld

Your commit was automatically rebased without conflicts.

[openjdk]

@dholmes-ora Pushed as commit b9a1691.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.