8378662: [lworld] Failure in building Valhalla with UBSAN

[xmas92]

Verified that we now can build with ubsan intstrumentation in Valhalla. Have not tested ubsan beyond building images.

Testing

• GHA

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed (1 review required, with at least 1 Committer)

Issue

• JDK-8378662: [lworld] Failure in building Valhalla with UBSAN (Bug - P3)

Reviewers

• Paul Hübner (@Arraying - Committer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/valhalla.git pull/2206/head:pull/2206
$ git checkout pull/2206

Update a local copy of the PR:
$ git checkout pull/2206
$ git pull https://git.openjdk.org/valhalla.git pull/2206/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2206

View PR using the GUI difftool:
$ git pr show -t 2206

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/valhalla/pull/2206.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back aboldtch! A progress list of the required criteria for merging this PR into lworld will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@xmas92 This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8378662: [lworld] Failure in building Valhalla with UBSAN

Reviewed-by: phubner

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 119 new commits pushed to the lworld branch:

• dde95fd: 8379514: [lworld] Cleanups of array klasses
• 3c48db9: 8378560: [lworld] Reflective construction of value object triggers assert in C2
• db5c187: 8379791: [lworld] C2: Blackhole wrongly treated as subclass of MemBar in NodeClasses enum
• ... and 116 more: https://git.openjdk.org/valhalla/compare/a2f9166fc80b4708d3c854e1d86c069968aa2b7d...lworld

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the lworld branch, type /integrate in a new comment.

[mlbridge]

Webrevs

• 01: Full - Incremental (c986c268)
• 00: Full (1ef453d8)

[Arraying]

Thanks. Left my opinion in the existing thread.

[xmas92]

Thanks for the reviews, I'll go ahead and integrate this now. If there were any additional style changes we wanted we can fix that in a separate RFE.
/integrate

[openjdk]

Going to push as commit 045cb4b.
Since your change was applied there have been 247 commits pushed to the lworld branch:

• a7ecceb: 8379559: [lworld] Avoid using new ClassFileFormatVersion for preview access flags
• 2e98a4d: 8375051: [lworld] debugging methods should provide more Valhalla related information
• 2701ce2: 8380191: [lworld] [BACKOUT] OptimizePtrCompare is too conservative
• ... and 244 more: https://git.openjdk.org/valhalla/compare/a2f9166fc80b4708d3c854e1d86c069968aa2b7d...lworld

Your commit was automatically rebased without conflicts.

[openjdk]

@xmas92 Pushed as commit 045cb4b.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.