Skip to content

Use local variable to avoid attribute lookup in form_rxn_matrix loop #3884

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
paulromano merged 2 commits into from
Apr 4, 2026
+7 −3
Merged

Use local variable to avoid attribute lookup in form_rxn_matrix loop #3884

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e4be93c
cache rate index out of hot loop
yrrepy Mar 18, 2026
f5f57c4
Merge branch 'develop' into pr/shimwell/3884
paulromano Apr 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions openmc/deplete/chain.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -701,15 +701,19 @@ def setval(i, j, val):
if fission_yields is None:
fission_yields = self.get_default_fission_yields()

# Save local variables to avoid attribute lookups in loop
index_nuc = rates.index_nuc
index_rx = rates.index_rx

for i, nuc in enumerate(self.nuclides):
if nuc.name not in rates.index_nuc:
if nuc.name not in index_nuc:
continue

nuc_ind = rates.index_nuc[nuc.name]
nuc_ind = index_nuc[nuc.name]
nuc_rates = rates[nuc_ind, :]

for r_type, target, _, br in nuc.reactions:
r_id = rates.index_rx[r_type]
r_id = index_rx[r_type]
path_rate = nuc_rates[r_id]

# Loss term -- make sure we only count loss once for
Expand Down
Loading