Skip to content

Add from_bounding_box classmethod to structured mesh classes#3903

Merged
paulromano merged 5 commits intoopenmc-dev:developfrom
bessemoa:add-from-bounding-box
Apr 2, 2026
Merged

Add from_bounding_box classmethod to structured mesh classes#3903
paulromano merged 5 commits intoopenmc-dev:developfrom
bessemoa:add-from-bounding-box

Conversation

@bessemoa
Copy link
Copy Markdown
Contributor

@bessemoa bessemoa commented Mar 26, 2026

Description

Implemented a factorization of the code adding from_bounding_box classmethod to structured mesh classes

Fixes #3871

Checklist

  • I have performed a self-review of my own code
  • I have run clang-format (version 18) on any C++ source files (if applicable)
  • I have followed the style guidelines for Python source files (if applicable)
  • I have made corresponding changes to the documentation (if applicable) (@paulromano)
  • I have added tests that prove my fix is effective or that my feature works (if applicable)

@GuySten GuySten marked this pull request as ready for review April 2, 2026 20:12
@GuySten GuySten marked this pull request as draft April 2, 2026 20:12
@paulromano paulromano marked this pull request as ready for review April 2, 2026 21:58
@paulromano paulromano changed the title Add from_bounding_box classmethod to structured mesh classes (Issue #3871) Add from_bounding_box classmethod to structured mesh classes Apr 2, 2026
Copy link
Copy Markdown
Contributor

@paulromano paulromano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@paulromano paulromano enabled auto-merge (squash) April 2, 2026 21:59
@bessemoa
Copy link
Copy Markdown
Contributor Author

bessemoa commented Apr 2, 2026

Thank you for pushing those fixes. I still need to complete the three last points of the checklist.

@paulromano paulromano merged commit df985e1 into openmc-dev:develop Apr 2, 2026
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Mesh.from_bounding_box method

2 participants