Make plot generation asynchronous to keep the UI responsive #171
+321
−55
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
This is really nice. Being able to interact with the app window while plots are being generated is a huge plus. I like the status indicator and status bar text idea, though the status bar indicator was a little subtle to me, particularly on a wider monitor. I tried combining the two into an overlay in the plot image area. What do you think? Screencast.from.2026-02-05.15-23-34.webm |
Contributor
Author
|
@pshriwise Interesting, can you throw that on another branch for me to play around with? If I like it, I'll merge it into the branch here |
Collaborator
Contributor
Author
|
I do indeed like your version better and merged it in; thanks! I made a few more small updates -- let me know what you think now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change makes plot generation asynchronous so the UI stays responsive during potentially expensive calls into
openmc.lib. It introduces a background worker thread forid_map/property_map, queues plot updates, and updates the view when results are ready. Astatus‑bar busy indicatortranslucent overlay on the plot provides feedback while plots are generating. Let me know what you think!