Open
Conversation
Author
|
NB: waiting on approval to run the CI workflow. |
Collaborator
|
@EpigeneMax Could you update your branch to the latest main commit? |
Author
Done. |
mumichae
requested changes
Aug 29, 2025
mumichae
reviewed
Sep 25, 2025
mumichae
reviewed
Sep 25, 2025
|
|
||
| print("Read input", flush=True) | ||
| adata = read_anndata( | ||
| par["input"], X="layers/normalized", obs="obs", var="var", uns="uns" |
Collaborator
There was a problem hiding this comment.
@rcannood Could you confirm if this is the correct way to read the counts layer, given that preferred_normalization: counts. I haven't seen any example where preferred_normalization is accessed in the script
Collaborator
|
Once it's confirmed that the counts are read correctly, this method can be merged |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your changes
This PR adds a ComBat-Seq component, based on inmoose implementation.
ComBat-Seq is a state-of-the-art tool for batch correction in bulk RNA-Seq data.
It draws inspiration from ComBat algorithm and adapts it to RNA-Seq.
ComBat is already integrated as a component on this task, adding ComBat-Seq seems quite legitimate.
Checklist before requesting a review
I have performed a self-review of my code
Check the correct box. Does this PR contain:
Proposed changes are described in the CHANGELOG.md
CI Tests succeed and look good!