Skip to content

Comments

(INF-3292) Move xdmod rsync cron image#304

Open
williamnswanson wants to merge 4 commits intoopensciencegrid:mainfrom
williamnswanson:INF-3292.xdmod-rsync-cron-image
Open

(INF-3292) Move xdmod rsync cron image#304
williamnswanson wants to merge 4 commits intoopensciencegrid:mainfrom
williamnswanson:INF-3292.xdmod-rsync-cron-image

Conversation

@williamnswanson
Copy link

Copied from https://github.com/jasoncpatton/xdmod-ospool-fetch into the images repo.

Also add the --delete flag to the generated cron's rsync command for mirroring.

@jasoncpatton, I think I put it in the right spot, can you confirm?

@brianhlin
Copy link
Member

@williamnswanson can you create a build-config.json like https://github.com/opensciencegrid/images/blob/main/opensciencegrid/central-syslog/build-config.json? Something like the following:

{
    "standard_build": true,
    "repo_build": false,
    "base_os": ["el9"],
    "osg_series": ["25"],
    "base_repo": ["release"]
  }

(I don't think the standard_build or repo_build do anything...)

Copy link
Contributor

@jasoncpatton jasoncpatton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM, I think the --delete is correct per the man page. Feel free to change/remove the LICENSE to have it fall under the rest of the images repo.

cat >/etc/cron.d/rsync-ospool-logs.cron <<EOF
SHELL=/bin/bash
PATH=/usr/sbin:/usr/bin:/sbin:/bin
${RSYNC_CRON_MINUTE:-30} ${RSYNC_CRON_HOUR:-8} * * * root rsync -ave --delete ssh ${RSYNC_SOURCE} ${RSYNC_TARGET} >>/var/log/rsync-ospool-logs.log 2>&1
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems correct to me, per the rsync man page (emphasis added):

--delete delete extraneous files from **dest** dirs

@@ -0,0 +1,21 @@
MIT License

Copyright (c) 2024 Jason Patton
Copy link
Contributor

@jasoncpatton jasoncpatton Feb 17, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I give permission to change the ©️ here or remove the LICENSE entirely since it's going into a organization-owned repo.

@jasoncpatton
Copy link
Contributor

And thanks for moving this over here!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants