Conversation
znichollscr
left a comment
There was a problem hiding this comment.
Nice. I'll post the changelog entries to add, then we're good to merge
There was a problem hiding this comment.
@mzecc can you undo the changes to this file before merging please (git fetch origin && git checkout origin/main pyproject.toml && git commit -m "Revert changes to pyproject.toml"). I think I made these changes by mistake
There was a problem hiding this comment.
I reverted the changes of the pyproject.toml. Could it be that tests are failing because of it?
There was a problem hiding this comment.
Yes but not for the reason we think. I missed that you were working in a fork, so we got the version of pyproject.toml which is in your fork's main branch, not https://github.com/openscm/gcages's main branch. See mzecc#3 for fixes
There was a problem hiding this comment.
(You can see that things haven't worked as expected because there are still changes to pyproject.toml in this PR, when there shouldn't be any if you grab the latest version that is in main)
|
CHANGELOG entries to add |
|
Ok @mzecc good to merge |
Description
Made hash check optional for historical emissions. Swapped hashes between Windows and the others.
Checklist
Please confirm that this pull request has done the following:
changelog/