Skip to content

add reproduction test case for dynamic template bug#1929

Open
rursprung wants to merge 3 commits intoopensearch-project:mainfrom
rursprung:add-test-for-dynamic-templates-bug
Open

add reproduction test case for dynamic template bug#1929
rursprung wants to merge 3 commits intoopensearch-project:mainfrom
rursprung:add-test-for-dynamic-templates-bug

Conversation

@rursprung
Copy link
Contributor

this adds a test case to reproduce #1513
essentially this is a port of opensearch-project/spring-data-opensearch#443 which purely uses the opensearch-java APIs rather than going through the Spring APIs.

this does not attempt to fix the bug, it just adds an ignored test case which will make it easier to reproduce & fix the bug.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

CC @reta: i ported your PR

this adds a test case to reproduce opensearch-project#1513
essentially this is a port of opensearch-project/spring-data-opensearch#443
which purely uses the `opensearch-java` APIs rather than going through
the Spring APIs.

this does not attempt to fix the bug, it just adds an ignored test case
which will make it easier to reproduce & fix the bug.

Signed-off-by: Ralph Ursprung <Ralph.Ursprung@avaloq.com>
@rursprung
Copy link
Contributor Author

the changelog is intentionally not updated as this doesn't change anything in the client itself, please add the skip changelog label

@reta
Copy link
Collaborator

reta commented Mar 12, 2026

the changelog is intentionally not updated as this doesn't change anything in the client itself, please add the skip changelog label

Thanks @rursprung , I will remove @Ignore from the test case so we could possibly come up with the fix

Signed-off-by: Andriy Redko <drreta@gmail.com>
Signed-off-by: Andriy Redko <drreta@gmail.com>
@rursprung
Copy link
Contributor Author

Thanks @rursprung , I will remove @Ignore from the test case so we could possibly come up with the fix

but then we can't merge the PR because the tests fail, right? my hope was that the PR can be merged so that the test is there and shows that something is amiss. otherwise it'll suffer the same fate as your PR original: it'll just hang around as a stale PR and eventually run into merge conflicts.

@reta
Copy link
Collaborator

reta commented Mar 12, 2026

but then we can't merge the PR because the tests fail, right? my hope was that the PR can be merged so that the test is there and shows that something is amiss. otherwise it'll suffer the same fate as your PR original: it'll just hang around as a stale PR and eventually run into merge conflicts.

Thanks @rursprung , I believe we need to fix the issue, the test will be "dead body", plus those are new files - there is no risk of any merge conflicts

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants