Add profiling support to unified query API#5268
Open
dai-chen wants to merge 1 commit intoopensearch-project:mainfrom
Open
Add profiling support to unified query API#5268dai-chen wants to merge 1 commit intoopensearch-project:mainfrom
dai-chen wants to merge 1 commit intoopensearch-project:mainfrom
Conversation
Contributor
|
Failed to generate code suggestions for PR |
dai-chen
force-pushed
the
feature/unified-query-profiling
branch
from
c85370d to
a4ea219
Compare
Contributor
|
Failed to generate code suggestions for PR |
dai-chen
force-pushed
the
feature/unified-query-profiling
branch
from
a4ea219 to
6749914
Compare
Contributor
|
Failed to generate code suggestions for PR |
dai-chen
force-pushed
the
feature/unified-query-profiling
branch
from
6749914 to
2f645f3
Compare
Contributor
|
Failed to generate code suggestions for PR |
dai-chen
force-pushed
the
feature/unified-query-profiling
branch
from
2f645f3 to
4a1cbef
Compare
Contributor
|
Failed to generate code suggestions for PR |
dai-chen
force-pushed
the
feature/unified-query-profiling
branch
from
4a1cbef to
5d88254
Compare
Contributor
|
Failed to generate code suggestions for PR |
dai-chen
force-pushed
the
feature/unified-query-profiling
branch
from
5d88254 to
c8f6055
Compare
Contributor
|
Failed to generate code suggestions for PR |
Add query profiling infrastructure that measures time spent in each query phase (analyze, optimize, execute, format). Profiling is opt-in via UnifiedQueryContext.builder().profiling(true) and uses thread-local context to avoid passing profiling state through every method. Key changes: - QueryProfiling/ProfileContext for thread-local profiling lifecycle - UnifiedQueryContext.measure() API for timing arbitrary phases - Auto-profiling in UnifiedQueryPlanner (analyze) and compiler (optimize) - UnifiedQueryTestBase shared test fixture for unified query tests - Comprehensive profiling tests with non-flaky >= 0 timing assertions Signed-off-by: Chen Dai <daichen@amazon.com>
dai-chen
force-pushed
the
feature/unified-query-profiling
branch
from
c8f6055 to
45b666c
Compare
Contributor
|
Failed to generate code suggestions for PR |
dai-chen
requested review from
LantaoJin,
Swiddis,
acarbonetto,
anirudha,
joshuali925,
mengweieric,
noCharger,
penghuo,
ps48,
vamsimanohar and
ykmr1224
as code owners
dai-chen
requested review from
RyanL1997,
ahkcs,
qianheng-aws,
songkant-aws and
yuancu
as code owners
ahkcs
approved these changes
Mar 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR enables profiling capability in the unified query API so external consumers (OpenSearch, Spark, CLI) can collect per-phase timing metrics without depending on the REST-specific
QueryContextlayer.Implementation Notes
profile=truein the REST API, but hides the internal profiling abstraction behindUnifiedQueryContext.measure()API outside: Each unified query component auto-profiles its phase and provide measure API for code outside unified query components, e.g.,PreparedStatement.executeQuery(), response formatting.Related Issues
Part of #5248
Check List
--signoffor-s.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.