Add unified query parser API#5274
Draft
dai-chen wants to merge 1 commit intoopensearch-project:mainfrom
Draft
Conversation
Contributor
|
Failed to generate code suggestions for PR |
dai-chen
force-pushed
the
feature/unified-query-parser
branch
from
0676f32 to
9ed26fe
Compare
Contributor
|
Failed to generate code suggestions for PR |
dai-chen
force-pushed
the
feature/unified-query-parser
branch
from
9ed26fe to
eb41b88
Compare
Contributor
|
Failed to generate code suggestions for PR |
Extract parsing logic from UnifiedQueryPlanner into a UnifiedQueryParser interface with language-specific implementations: PPLQueryParser (returns UnresolvedPlan) and CalciteSqlQueryParser (returns SqlNode). UnifiedQueryContext owns the parser instance, created eagerly by the builder which has direct access to query type and future SQL config. Each implementation receives only its required dependencies: PPLQueryParser takes Settings, CalciteSqlQueryParser takes CalcitePlanContext. UnifiedQueryPlanner.CustomVisitorStrategy now obtains the parser from the context via the interface type. Signed-off-by: Chen Dai <daichen@amazon.com>
dai-chen
force-pushed
the
feature/unified-query-parser
branch
from
eb41b88 to
0fc6009
Compare
Contributor
|
Failed to generate code suggestions for PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Extract parsing logic from UnifiedQueryPlanner into a
UnifiedQueryParser<R>interface with language-specific implementations:PPLQueryParser(returnsUnresolvedPlan) andCalciteSqlQueryParser(returnsSqlNode).Implementation Notes
UnifiedQueryContextcreates and owns the parser, ensuring consistent configuration across all components.parse(query, visitor)was explored but deferred. PPL's custom AST and Calcite's SqlNode tree have fundamentally different node structures. Until this tension resolves, callers use native visitors on the typedparse(query)result.Related Issues
Part of #5248
Check List
--signoffor-s.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.