OCPEDGE-2276: Add TNA arbiter topology support to kcli deployment + general improvements #50
Conversation
openshift-ci-robot
added
the
jira/valid-reference
|
@vimauro: This pull request references OCPEDGE-2276 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.22.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/hold |
openshift-ci
bot
added
the
do-not-merge/hold
deploy/openshift-clusters/roles/dev-scripts/install-dev/files/config_arbiter_example.sh
Show resolved
Hide resolved
deploy/openshift-clusters/roles/kcli/kcli-install/tasks/validate.yml
Outdated
Show resolved
Hide resolved
fonta-rh
left a comment
fonta-rh
left a comment
There was a problem hiding this comment.
Great addition! Added a few considerations. Specially the random-suffix for CloudFormation stack seems a bit dangerous to me, I'd like to hear more about the need for that
| @echo "" | ||
| @echo "Instance Lifecycle Management:" | ||
| @echo " deploy - Create, initialize, and update inventory for new EC2 instance" | ||
| @echo " deploy <cluster-type>- Deploy EC2 instance AND deploy the specified cluster type" |
There was a problem hiding this comment.
I like where you're going with this, but there is no "cluster-type" explanation in the help. To combine this, I would leave the "OpenShift Cluster Management" section just for cluster handling commands, and move the cluster types into a "OpenShift Cluster Deployment" with all the cluster types. Then you can reference that "OpenShift Cluster Deployment" section here for the valid values
There was a problem hiding this comment.
Sounds good. I have changed this section a bit, let me know what you think about it!
There was a problem hiding this comment.
I don't know if the "Valid types" echo was there before and I missed it, but it's exactly what was needed. Looking good!
There was a problem hiding this comment.
seems it wasn't there 😄
I added also a variable VALID_CLUSTER_TYPES so that we can also check for any inconsistency early on in the deployment process. I made a typo couple of times and got an error 15 minutes later, that's why I added it 😆
There was a problem hiding this comment.
That's the best reason to do it 🤣
openshift-merge-robot
added
the
needs-rebase
openshift-merge-robot
removed
the
needs-rebase
fonta-rh
left a comment
fonta-rh
left a comment
There was a problem hiding this comment.
Awesome work cleaning up at the same time new features are added. I think you might need a rebase because a couple PRs merged this morning, I'll re-lgtm after that
| @echo "" | ||
| @echo "Instance Lifecycle Management:" | ||
| @echo " deploy - Create, initialize, and update inventory for new EC2 instance" | ||
| @echo " deploy <cluster-type>- Deploy EC2 instance AND deploy the specified cluster type" |
There was a problem hiding this comment.
I don't know if the "Valid types" echo was there before and I missed it, but it's exactly what was needed. Looking good!
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: fonta-rh, vimauro The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
5 participants
Summary
arbiter-kclideployments alongside existingfencing-kclideploy-arbiter-ipi.sh, deploy-arbiter-agent.sh, deploy-fencing-ipi.sh, deploy-fencing-agent.sh) into a single unifieddeploy-cluster.shscript with--topologyand--methodargumentsarbiter-kcliandfencing-kclifor kcli-based deploymentsNote:
arbiter-kclitopology