CORENET-6097: Open BGP port 179 for no-overlay mode#1880
CORENET-6097: Open BGP port 179 for no-overlay mode#1880zhaozhanqi wants to merge 1 commit intoopenshift-metal3:masterfrom
Conversation
Add firewall rule to open port 179/tcp in the libvirt zone during host configuration. This port is required for BGP routing when no-overlay mode is enabled for the default network.
|
Hi @zhaozhanqi. Thanks for your PR. I'm waiting for a openshift-metal3 member to verify that this patch is reasonable to test. If it is, they should reply with Regular contributors should join the org to skip this step. Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@mkowalski Hi, could you help take a look this? we need this patch to setup no-overlay cluster in our CI. thanks. |
|
/ok-to-test |
|
/retest |
|
@zhaozhanqi: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
@dtantsur Thanks for helping add the test label |
| configure_chronyd | ||
|
|
||
| # Open BGP port for no-overlay mode enabled for default network | ||
| sudo firewall-cmd --zone=libvirt --add-port=179/tcp |
There was a problem hiding this comment.
I don't like the fact it does not persist the reboot but I checked and seems like almost everyone is doing it non-persistent way here (https://github.com/search?q=repo%3Aopenshift-metal3%2Fdev-scripts%20firewall-cmd&type=code)
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mkowalski The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/test e2e-metal-ipi-serial-ipv4-1of2 |
Add firewall rule to open port 179/tcp in the libvirt zone during host configuration. This port is required for BGP routing when no-overlay mode is enabled for the default network.