Skip to content

CORENET-6097: Open BGP port 179 for no-overlay mode#1880

Open
zhaozhanqi wants to merge 1 commit intoopenshift-metal3:masterfrom
zhaozhanqi:open-bgp-port-179
Open

CORENET-6097: Open BGP port 179 for no-overlay mode#1880
zhaozhanqi wants to merge 1 commit intoopenshift-metal3:masterfrom
zhaozhanqi:open-bgp-port-179

Conversation

@zhaozhanqi
Copy link
Copy Markdown

Add firewall rule to open port 179/tcp in the libvirt zone during host configuration. This port is required for BGP routing when no-overlay mode is enabled for the default network.

Add firewall rule to open port 179/tcp in the libvirt zone during
host configuration. This port is required for BGP routing when
no-overlay mode is enabled for the default network.
@openshift-ci openshift-ci bot requested review from bfournie and sadasu April 2, 2026 11:41
@openshift-ci
Copy link
Copy Markdown

openshift-ci bot commented Apr 2, 2026

Hi @zhaozhanqi. Thanks for your PR.

I'm waiting for a openshift-metal3 member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work.

Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-ci openshift-ci bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Apr 2, 2026
@zhaozhanqi zhaozhanqi changed the title Open BGP port 179 for no-overlay mode CORENET-6097: Open BGP port 179 for no-overlay mode Apr 2, 2026
@zhaozhanqi
Copy link
Copy Markdown
Author

@mkowalski Hi, could you help take a look this? we need this patch to setup no-overlay cluster in our CI. thanks.

@zhaozhanqi
Copy link
Copy Markdown
Author

@bfournie @sadasu Would you like to help review this? thanks

@dtantsur
Copy link
Copy Markdown
Member

dtantsur commented Apr 7, 2026

/ok-to-test

@openshift-ci openshift-ci bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Apr 7, 2026
@zhaozhanqi
Copy link
Copy Markdown
Author

/retest

@openshift-ci
Copy link
Copy Markdown

openshift-ci bot commented Apr 8, 2026

@zhaozhanqi: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-metal-ipi-bm-bond 17388a9 link false /test e2e-metal-ipi-bm-bond

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@zhaozhanqi
Copy link
Copy Markdown
Author

@dtantsur Thanks for helping add the test label
Could you help check this can be approved? I don't think the failed job is not related the changes

configure_chronyd

# Open BGP port for no-overlay mode enabled for default network
sudo firewall-cmd --zone=libvirt --add-port=179/tcp
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't like the fact it does not persist the reboot but I checked and seems like almost everyone is doing it non-persistent way here (https://github.com/search?q=repo%3Aopenshift-metal3%2Fdev-scripts%20firewall-cmd&type=code)

@mkowalski
Copy link
Copy Markdown
Member

/approve

@openshift-ci
Copy link
Copy Markdown

openshift-ci bot commented Apr 8, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mkowalski

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 8, 2026
@mkowalski
Copy link
Copy Markdown
Member

/test e2e-metal-ipi-serial-ipv4-1of2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. ok-to-test Indicates a non-member PR verified by an org member that is safe to test.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants