MGMT-22517: Change amd gpu operator namespace to openshift-amd-gpu by pastequo · Pull Request #10007 · openshift/assisted-service

pastequo · 2026-03-13T08:45:21Z

Changing amd gpu operator namespace to "openshift-amd-gpu" to be aligned with the certified workflow and enable monitoring

List all the issues related to this PR

What environments does this code impact?

Automation (CI, tools, etc)
Cloud
Operator Managed Deployments
None

How was this code tested?

assisted-test-infra environment
dev-scripts environment
Reviewer's test appreciated
Waiting for CI to do a full test run
Manual (Elaborate on how it was tested)
No tests needed

Checklist

Title and description added to both, commit and PR.
Relevant issues have been associated (see CONTRIBUTING guide)
This change does not require a documentation update (docstring, docs, README, etc)
Does this change include unit-tests (note that code changes require unit-tests)

Reviewers Checklist

Are the title and description (in both PR and commit) meaningful and clear?
Is there a bug required (and linked) for this change?
Should this PR be backported?

Summary by CodeRabbit

Release Notes

Chores
- Updated AMD GPU operator namespace configuration to use dynamic templating, improving flexibility in deployment scenarios.

openshift-ci-robot · 2026-03-13T08:45:24Z

coderabbitai · 2026-03-13T08:45:37Z

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository: openshift/coderabbit/.coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 7be5036e-0f78-4c0c-af81-b8796017e630

📥 Commits

Reviewing files that changed from the base of the PR and between 89897ad and 35a6288.

📒 Files selected for processing (2)

internal/operators/amdgpu/amd_gpu_operator.go
internal/operators/amdgpu/templates/custom/deviceconfig.yaml

Walkthrough

Updates the AMD GPU operator's namespace configuration from "kube-amd-gpu" to "openshift-amd-gpu" in the operator definition and makes the device configuration template parameterized to reference the operator's namespace dynamically.

Changes

Cohort / File(s)	Summary
AMD GPU Operator Namespace Configuration `internal/operators/amdgpu/amd_gpu_operator.go`, `internal/operators/amdgpu/templates/custom/deviceconfig.yaml`	Updates namespace from hardcoded "kube-amd-gpu" to "openshift-amd-gpu" and converts the template's namespace reference from a static value to a dynamic template variable `{{ .Operator.Namespace }}`.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly and specifically describes the main change: updating the AMD GPU operator namespace to openshift-amd-gpu, and includes the relevant issue reference (MGMT-22517).
Description check	✅ Passed	The description includes the required summary, states the motivation (alignment with certified workflow and monitoring), follows the template structure, and completes all essential checklist items. All required sections are present and adequately filled.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Stable And Deterministic Test Names	✅ Passed	The PR modifies only non-test files (amd_gpu_operator.go and deviceconfig.yaml) and does not add or modify any Ginkgo test files.
Test Structure And Quality	✅ Passed	This PR modifies only configuration and template files for AMD GPU operator namespace changes. No Ginkgo test code or test files were added, modified, or removed.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests
Post copyable unit tests in a comment

📝 Coding Plan

Generate coding plan for human review comments

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

Tip

CodeRabbit can approve the review once all CodeRabbit's comments are resolved.

Enable the reviews.request_changes_workflow setting to automatically approve the review once all CodeRabbit's comments are resolved.

openshift-ci · 2026-03-13T08:46:20Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pastequo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [pastequo]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci-robot · 2026-03-13T08:49:47Z

codecov · 2026-03-13T09:23:38Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 47.91%. Comparing base (89897ad) to head (35a6288).
⚠️ Report is 51 commits behind head on master.

Additional details and impacted files

@@            Coverage Diff             @@
##           master   #10007      +/-   ##
==========================================
+ Coverage   44.08%   47.91%   +3.82%     
==========================================
  Files         415      416       +1     
  Lines       72258    78100    +5842     
==========================================
+ Hits        31855    37419    +5564     
- Misses      37521    37670     +149     
- Partials     2882     3011     +129

Files with missing lines	Coverage Δ
internal/operators/amdgpu/amd_gpu_operator.go	`46.61% <ø> (ø)`

... and 27 files with indirect coverage changes

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

pastequo · 2026-03-16T13:21:45Z

/retest

pastequo · 2026-03-18T13:49:22Z

/retest

pastequo · 2026-03-19T08:24:51Z

/retest

pastequo · 2026-03-23T08:44:18Z

/retest

pastequo · 2026-03-23T14:43:59Z

/retest

pastequo · 2026-03-24T08:47:26Z

/retest

pastequo · 2026-03-26T10:24:45Z

/override ci/prow/e2e-agent-compact-ipv4-iso-no-registry ci/prow/edge-e2e-ai-operator-ztp ci/prow/edge-e2e-metal-assisted-virtualization-4-21

openshift-ci · 2026-03-26T10:25:36Z

@pastequo: Overrode contexts on behalf of pastequo: ci/prow/e2e-agent-compact-ipv4-iso-no-registry, ci/prow/edge-e2e-ai-operator-ztp, ci/prow/edge-e2e-metal-assisted-virtualization-4-21

Details

In response to this:

/override ci/prow/e2e-agent-compact-ipv4-iso-no-registry ci/prow/edge-e2e-ai-operator-ztp ci/prow/edge-e2e-metal-assisted-virtualization-4-21

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

bluesort · 2026-03-27T16:54:42Z

LGTM

bluesort · 2026-03-27T16:55:24Z

/lgtm

openshift-ci-robot · 2026-03-27T19:04:33Z

/retest-required

Remaining retests: 0 against base HEAD acc8646 and 2 for PR HEAD 35a6288 in total

openshift-ci-robot · 2026-03-27T21:04:24Z

/retest-required

Remaining retests: 0 against base HEAD d59c041 and 1 for PR HEAD 35a6288 in total

pastequo · 2026-03-27T22:44:34Z

/retest

openshift-ci-robot · 2026-03-30T12:30:02Z

/retest-required

Remaining retests: 0 against base HEAD 86cd2ee and 0 for PR HEAD 35a6288 in total

pastequo · 2026-03-30T15:42:22Z

/override ci/prow/edge-e2e-metal-assisted-virtualization-4-21

openshift-ci · 2026-03-30T15:42:41Z

@pastequo: Overrode contexts on behalf of pastequo: ci/prow/edge-e2e-metal-assisted-virtualization-4-21

Details

In response to this:

/override ci/prow/edge-e2e-metal-assisted-virtualization-4-21

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

openshift-ci-robot · 2026-03-30T20:30:33Z

/hold

Revision 35a6288 was retested 3 times: holding

pastequo · 2026-03-31T08:15:35Z

/unhold

pastequo · 2026-03-31T08:16:08Z

/retest

openshift-ci-robot · 2026-03-31T11:06:27Z

/retest-required

Remaining retests: 0 against base HEAD 6287494 and 2 for PR HEAD 35a6288 in total

openshift-ci-robot · 2026-03-31T21:18:13Z

/retest-required

Remaining retests: 0 against base HEAD ba89549 and 1 for PR HEAD 35a6288 in total

pastequo · 2026-04-02T07:31:27Z

/override ci/prow/edge-e2e-metal-assisted-virtualization-4-21

openshift-ci · 2026-04-02T07:31:41Z

@pastequo: Overrode contexts on behalf of pastequo: ci/prow/edge-e2e-metal-assisted-virtualization-4-21

Details

In response to this:

/override ci/prow/edge-e2e-metal-assisted-virtualization-4-21

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

openshift-merge-bot · 2026-04-02T09:21:23Z

/retest-required

Remaining retests: 0 against base HEAD 26e9439 and 0 for PR HEAD 35a6288 in total

openshift-merge-bot · 2026-04-02T11:22:34Z

/hold

Revision 35a6288 was retested 3 times: holding

pastequo · 2026-04-02T15:18:59Z

/override ci/prow/e2e-agent-compact-ipv4 ci/prow/edge-e2e-metal-assisted-virtualization-4-21

pastequo · 2026-04-02T15:19:10Z

/unhold

openshift-ci · 2026-04-02T15:19:26Z

@pastequo: Overrode contexts on behalf of pastequo: ci/prow/e2e-agent-compact-ipv4, ci/prow/edge-e2e-metal-assisted-virtualization-4-21

Details

In response to this:

/override ci/prow/e2e-agent-compact-ipv4 ci/prow/edge-e2e-metal-assisted-virtualization-4-21

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

openshift-ci · 2026-04-02T15:19:30Z

@pastequo: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

MGMT-22517: Change amd gpu operator namespace to openshift-amd-gpu

35a6288

openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Mar 13, 2026

openshift-ci Bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Mar 13, 2026

openshift-ci Bot requested review from danmanor and omertuc March 13, 2026 08:46

openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 13, 2026

openshift-ci Bot assigned bluesort Mar 27, 2026

openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Mar 27, 2026

openshift-ci Bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 30, 2026

openshift-ci Bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 31, 2026

openshift-ci Bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 2, 2026

openshift-ci Bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 2, 2026

openshift-merge-bot Bot merged commit 19a2f27 into openshift:master Apr 2, 2026
24 checks passed

Conversation

pastequo commented Mar 13, 2026 • edited by coderabbitai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

List all the issues related to this PR

What environments does this code impact?

How was this code tested?

Checklist

Reviewers Checklist

Summary by CodeRabbit

Release Notes

Uh oh!

openshift-ci-robot commented Mar 13, 2026 • edited by openshift-ci Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

List all the issues related to this PR

What environments does this code impact?

How was this code tested?

Checklist

Reviewers Checklist

Uh oh!

coderabbitai Bot commented Mar 13, 2026 • edited by openshift-ci Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Estimated code review effort

Uh oh!

openshift-ci Bot commented Mar 13, 2026

Uh oh!

openshift-ci-robot commented Mar 13, 2026 • edited by openshift-ci Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

List all the issues related to this PR

What environments does this code impact?

How was this code tested?

Checklist

Reviewers Checklist

Summary by CodeRabbit

Release Notes

Uh oh!

codecov Bot commented Mar 13, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

pastequo commented Mar 16, 2026

Uh oh!

pastequo commented Mar 18, 2026

Uh oh!

pastequo commented Mar 19, 2026

Uh oh!

pastequo commented Mar 23, 2026

Uh oh!

pastequo commented Mar 23, 2026

Uh oh!

pastequo commented Mar 24, 2026

Uh oh!

pastequo commented Mar 26, 2026

Uh oh!

openshift-ci Bot commented Mar 26, 2026

Uh oh!

bluesort commented Mar 27, 2026

Uh oh!

bluesort commented Mar 27, 2026

Uh oh!

openshift-ci-robot commented Mar 27, 2026

Uh oh!

openshift-ci-robot commented Mar 27, 2026

Uh oh!

pastequo commented Mar 27, 2026

Uh oh!

openshift-ci-robot commented Mar 30, 2026

Uh oh!

pastequo commented Mar 30, 2026

Uh oh!

openshift-ci Bot commented Mar 30, 2026

Uh oh!

openshift-ci-robot commented Mar 30, 2026

Uh oh!

pastequo commented Mar 31, 2026

Uh oh!

pastequo commented Mar 31, 2026

Uh oh!

openshift-ci-robot commented Mar 31, 2026

pastequo commented Mar 13, 2026 •

edited by coderabbitai Bot

Loading

openshift-ci-robot commented Mar 13, 2026 •

edited by openshift-ci Bot

Loading

coderabbitai Bot commented Mar 13, 2026 •

edited by openshift-ci Bot

Loading

openshift-ci-robot commented Mar 13, 2026 •

edited by openshift-ci Bot

Loading

codecov Bot commented Mar 13, 2026 •

edited

Loading