NO-ISSUE: [master] Bump OCP versions: 4.19, 4.17#10026
NO-ISSUE: [master] Bump OCP versions: 4.19, 4.17#10026danmanor wants to merge 1 commit intoopenshift:masterfrom
Conversation
|
@danmanor: This pull request explicitly references no jira issue. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
openshift-ci-robot
added
the
jira/valid-reference
WalkthroughOpenShift release image versions are updated across three configuration files: version 4.17.50 is bumped to 4.17.51 and version 4.19.25 is bumped to 4.19.26, applied uniformly across x86_64, arm64, and multi architecture variants. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes ✨ Finishing Touches🧪 Generate unit tests (beta)
📝 Coding Plan
Comment |
openshift-ci
Bot
added
the
size/S
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: danmanor The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
Bot
added
the
approved
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
🧹 Nitpick comments (1)
data/default_release_images.json (1)
155-237: Reduce drift risk by generating mirroredRELEASE_IMAGESblobs from this source.The same release-image list is manually duplicated across this JSON and embedded YAML strings in other touched files; that is a recurring maintainability hazard during bumps. Consider making this file the source of truth and generating the YAML-embedded JSON values from it.
As per coding guidelines, "Focus on major issues impacting performance, readability, maintainability and security. Avoid nitpicks and avoid verbosity."
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@data/default_release_images.json` around lines 155 - 237, The repo is duplicating release-image lists (the RELEASE_IMAGES blobs) in JSON and embedded YAML strings causing drift; make data/default_release_images.json the single source of truth by adding a small generator that reads that file and writes the embedded JSON into the YAML consumers instead of maintaining hand-copied blobs. Implement a script (e.g., scripts/generate_release_images) that loads data/default_release_images.json and replaces the RELEASE_IMAGES placeholders in the affected YAML/templating files (the places currently containing the embedded JSON blobs), update any consumers or build/CI targets to run this generator (or load the file at runtime), and remove the duplicated hard-coded JSON blobs so the only authoritative data is in default_release_images.json.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Nitpick comments:
In `@data/default_release_images.json`:
- Around line 155-237: The repo is duplicating release-image lists (the
RELEASE_IMAGES blobs) in JSON and embedded YAML strings causing drift; make
data/default_release_images.json the single source of truth by adding a small
generator that reads that file and writes the embedded JSON into the YAML
consumers instead of maintaining hand-copied blobs. Implement a script (e.g.,
scripts/generate_release_images) that loads data/default_release_images.json and
replaces the RELEASE_IMAGES placeholders in the affected YAML/templating files
(the places currently containing the embedded JSON blobs), update any consumers
or build/CI targets to run this generator (or load the file at runtime), and
remove the duplicated hard-coded JSON blobs so the only authoritative data is in
default_release_images.json.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 897de643-84d0-4ef7-8043-98d6a589559f
📒 Files selected for processing (3)
data/default_release_images.jsondeploy/podman/configmap.ymlopenshift/template.yaml
|
/retest |
1 similar comment
|
/retest |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #10026 +/- ##
==========================================
- Coverage 44.09% 44.08% -0.01%
==========================================
Files 415 415
Lines 72258 72258
==========================================
- Hits 31860 31855 -5
- Misses 37518 37521 +3
- Partials 2880 2882 +2 🚀 New features to boost your workflow:
|
|
/test edge-subsystem-kubeapi-aws |
|
@danmanor: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
Closing as duplicate of #10037 |
4 participants
OpenShift updates: 4.19.25 -> 4.19.26, 4.19.25-multi -> 4.19.26-multi, 4.17.50-multi -> 4.17.51-multi, 4.17.50 -> 4.17.51
RHCOS updates:
/test edge-e2e-metal-assisted-4-19 edge-e2e-metal-assisted-4-17
/cc @rccrdpccl @gamli75