SPLAT-2672: e2e/ote/ccm-aws: moving binary cccmo project#437
Open
mtulio wants to merge 5 commits intoopenshift:mainfrom
Open
SPLAT-2672: e2e/ote/ccm-aws: moving binary cccmo project#437mtulio wants to merge 5 commits intoopenshift:mainfrom
mtulio wants to merge 5 commits intoopenshift:mainfrom
Conversation
openshift-ci-robot
added
the
jira/valid-reference
|
@mtulio: This pull request references SPLAT-2672 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.22.0" version, but no target version was set. DetailsIn response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
openshift-ci
bot
added
the
do-not-merge/work-in-progress
Contributor
|
Skipping CI for Draft Pull Request. |
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
WalkthroughAdds a new AWS CCM E2E test extension for OpenShift: build artifacts (.dockerignore, Dockerfile, Makefile), a Go module with dependencies, a CLI entrypoint (main.go), and E2E tests plus AWS/OpenShift helpers (loadbalancer and helper packages). Total additions: ~1,165 lines across 7 new files. Changes
Estimated code review effort🎯 4 (Complex) | ⏱️ ~45 minutes Important Pre-merge checks failedPlease resolve all errors before merging. Addressing warnings is optional. ❌ Failed checks (1 error, 1 warning)
✅ Passed checks (3 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
📝 Coding Plan
Warning There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure. 🔧 golangci-lint (2.11.3)Error: can't load config: unsupported version of the configuration: "" See https://golangci-lint.run/docs/product/migration-guide for migration instructions Comment |
|
@mtulio: This pull request references SPLAT-2672 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.22.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
Contributor
Author
|
/testwith openshift/cluster-cloud-controller-manager-operator/main/e2e-aws openshift/origin/#30864 |
Contributor
|
@mtulio, |
Contributor
Author
|
/testwith openshift/cluster-cloud-controller-manager-operator/main/e2e-aws openshift/origin#30864 |
Contributor
|
@mtulio, |
Contributor
Author
|
/test ? |
Contributor
Author
|
/testwith openshift/cluster-cloud-controller-manager-operator/main/pull-ci-openshift-cloud-provider-aws-main-e2e-aws-ovn openshift/origin#30864 |
Contributor
|
@mtulio, |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 6
🧹 Nitpick comments (5)
Makefile (2)
40-40: Consider declaringbuildas.PHONY.The static analysis tool flagged that the
buildtarget should be declared as PHONY since it doesn't produce a file named "build". This ensures the target always runs regardless of file system state.♻️ Proposed fix
+.PHONY: build build: operator config-sync-controllers azure-config-credentials-injector cloud-controller-manager-aws-tests-ext🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@Makefile` at line 40, The Makefile's build target ("build: operator config-sync-controllers azure-config-credentials-injector cloud-controller-manager-aws-tests-ext") should be declared phony so it always runs; add a .PHONY declaration that includes build (e.g., add ".PHONY: build" alongside any other phony targets) so the make tool doesn't treat "build" as a real file and will always execute the recipe.
51-56: Missingpopdafterpushdin shell command.The
pushdcommand changes the directory, but there's no correspondingpopdto restore the original directory. While Make targets typically run in subshells (so the effect is limited), it's good practice to pairpushdwithpopdfor clarity and to avoid issues if the command is expanded later.♻️ Proposed fix
cloud-controller-manager-aws-tests-ext: pushd cmd/cloud-controller-manager-aws-tests-ext && \ GO111MODULE=on CGO_ENABLED=0 GOOS=$(GOOS) GOARCH=$(GOARCH) GOPROXY=$(GOPROXY) go build \ -trimpath \ -ldflags="$(LDFLAGS)" \ - -o=../../bin/cloud-controller-manager-aws-tests-ext . - + -o=../../bin/cloud-controller-manager-aws-tests-ext . && \ + popd🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@Makefile` around lines 51 - 56, The target cloud-controller-manager-aws-tests-ext uses pushd to change directories but never restores the original directory; update the shell recipe so pushd cmd/cloud-controller-manager-aws-tests-ext is paired with a corresponding popd after the go build step (e.g., ensure the sequence ends with popd or chain commands so popd always runs even on failure) to restore the working directory.cmd/cloud-controller-manager-aws-tests-ext/main.go (2)
173-177: Typo in comment."leding" should be "leading".
📝 Proposed fix
// After reading all flags, this will configure the test context, and need to be // called once by framework to avoid re-configuring the test context, and leding - // to issues in Ginkgo phases (PhaseBuildTopLevel, PhaseBuildTree, PhaseRun), + // leading to issues in Ginkgo phases (PhaseBuildTopLevel, PhaseBuildTree, PhaseRun), // such as:'cannot clone suite after tree has been built'🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@cmd/cloud-controller-manager-aws-tests-ext/main.go` around lines 173 - 177, Fix the typo in the comment above the framework.AfterReadingAllFlags(testContext) call: change "leding" to "leading" so the comment reads "...and leading to issues in Ginkgo phases (PhaseBuildTopLevel, PhaseBuildTree, PhaseRun), such as:'cannot clone suite after tree has been built'".
105-124: Getter function has unexpected side effects.
getRegionFromEnvsetsAWS_REGIONas a side effect when reading fromLEASED_RESOURCEorAWS_DEFAULT_REGION. This violates the principle of least surprise for a "get" function. Consider renaming togetAndSetRegionFromEnvor extracting the side effect into a separate function.♻️ Proposed refactor
-// getRegionFromEnv gets the region from the environment variables. -func getRegionFromEnv() string { +// getOrSetRegionFromEnv gets the region from environment variables and ensures +// AWS_REGION is set for downstream AWS SDK usage. +func getOrSetRegionFromEnv() string { region := os.Getenv("LEASED_RESOURCE") if len(region) > 0 { log.Debugf("Using region from LEASED_RESOURCE: %s", region)🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@cmd/cloud-controller-manager-aws-tests-ext/main.go` around lines 105 - 124, The function getRegionFromEnv currently mutates environment variables (calls os.Setenv for AWS_REGION) when reading LEASED_RESOURCE or AWS_DEFAULT_REGION; either remove these side effects so the function only returns the resolved region, or split into two functions: getRegionFromEnv (pure getter that reads LEASED_RESOURCE, AWS_REGION, AWS_DEFAULT_REGION and returns the region) and setRegionEnv(region string) which performs os.Setenv("AWS_REGION", region) when desired; if you prefer keeping behavior, rename getRegionFromEnv to getAndSetRegionFromEnv to make the side effect explicit and update all call sites accordingly.cmd/cloud-controller-manager-aws-tests-ext/e2e/helper.go (1)
187-196: Use AWS SDK error types instead of string matching.The
ec2IsNotFoundErrorfunction relies on string matching against error messages, which is fragile. AWS SDK v2 provides typed error handling viasmithyerrors. Additionally,InvalidGroup.Malformedindicates an invalid ID format, not a non-existent group—it should likely cause test failure rather than being treated as "not found."♻️ Proposed fix using AWS SDK error types
+import ( + "errors" + "github.com/aws/smithy-go" +) + // ec2IsNotFoundError checks if an error is an EC2 "not found" error. func ec2IsNotFoundError(err error) bool { if err == nil { return false } - // Check for common EC2 not found error messages - errMsg := err.Error() - return strings.Contains(errMsg, "InvalidGroup.NotFound") || - strings.Contains(errMsg, "InvalidGroupId.NotFound") || - strings.Contains(errMsg, "InvalidGroup.Malformed") + var apiErr smithy.APIError + if errors.As(err, &apiErr) { + switch apiErr.ErrorCode() { + case "InvalidGroup.NotFound", "InvalidGroupId.NotFound": + return true + } + } + return false }🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@cmd/cloud-controller-manager-aws-tests-ext/e2e/helper.go` around lines 187 - 196, Replace fragile string matching in ec2IsNotFoundError with typed AWS SDK error handling: use errors.As to check if err implements github.com/aws/smithy-go/middleware/APIError (smithy.APIError) or smithy.APIError interface and then switch on apiErr.ErrorCode() to return true only for "InvalidGroup.NotFound" and "InvalidGroupId.NotFound"; explicitly do NOT treat "InvalidGroup.Malformed" as not-found (return false) so malformed IDs cause test failures; update ec2IsNotFoundError to use errors.As and ErrorCode() comparisons instead of strings.Contains.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@cmd/cloud-controller-manager-aws-tests-ext/e2e/loadbalancer.go`:
- Around line 296-304: The call to framework.ExpectNoError inside the Eventually
callback prevents retries on transient errors; update the callback so
getAWSSecurityGroupRules(ctx, ec2Client, foundLB.SecurityGroups) returns its
error instead of calling framework.ExpectNoError. Specifically, replace the
ExpectNoError call with logic that checks err and returns nil, err (or
fmt.Errorf-wrapped err) so Eventually can retry; keep the subsequent length
check using originalSGRules and currentSGRules and return the existing
fmt.Errorf when counts haven't changed.
- Around line 292-294: The log message in the load balancer check (inside the
block that inspects foundLB and foundLB.SecurityGroups) is misleading because it
uses "expected=%d" while printing the actual count len(foundLB.SecurityGroups);
update the framework.Logf call to clearly state actual vs expected (for example
"Load balancer has no security groups attached: actual=%d expected=1" or simply
"Load balancer has no security groups attached: actual=%d"), using
len(foundLB.SecurityGroups) for the actual value, and leave the error return
(fmt.Errorf("load balancer has no security groups attached")) unchanged.
In `@cmd/cloud-controller-manager-aws-tests-ext/go.mod`:
- Line 132: The go.mod currently pulls k8s.io/cloud-provider v0.34.0 indirectly
which conflicts with other Kubernetes modules pinned at v0.35.0; update the
module replacement by adding a replace directive for k8s.io/cloud-provider to
v0.35.0 (i.e., add "replace k8s.io/cloud-provider => k8s.io/cloud-provider
v0.35.0" in go.mod) so the dependency graph resolves to the same Kubernetes
version, or alternatively add a brief comment in go.mod explaining why v0.34.0
must remain if there is a compatibility reason.
In `@cmd/cloud-controller-manager-aws-tests-ext/main.go`:
- Around line 191-193: The condition currently uses
len(os.Getenv("TEST_JUNIT_DIR")) >= 0 which is always true; change the check to
only set testContext.ReportDir when the environment variable is non-empty (e.g.,
testDir := os.Getenv("TEST_JUNIT_DIR"); if testDir != "" { testContext.ReportDir
= testDir }) so that testContext.ReportDir is not overwritten with an empty
string; update references to os.Getenv("TEST_JUNIT_DIR") and
testContext.ReportDir accordingly.
In `@cmd/cloud-controller-manager-aws-tests-ext/README.md`:
- Around line 46-50: Update the README to use the correct make target and output
path: replace the incorrect make invocation that references
openshift-hack/Makefile with the root Makefile target "make
cloud-controller-manager-aws-tests-ext", and update the described binary
location from "./aws-cloud-controller-manager-tests-ext" to
"./bin/cloud-controller-manager-aws-tests-ext" so the command and output path
match the actual "cloud-controller-manager-aws-tests-ext" build target.
- Line 39: Update the README entry that currently says "Go 1.24+" to match the
module's declared Go version in go.mod (go 1.25.0); edit the README text so the
prerequisite reflects "Go 1.25.0" or "Go 1.25+" to align with the go directive
in go.mod and avoid version mismatch.
---
Nitpick comments:
In `@cmd/cloud-controller-manager-aws-tests-ext/e2e/helper.go`:
- Around line 187-196: Replace fragile string matching in ec2IsNotFoundError
with typed AWS SDK error handling: use errors.As to check if err implements
github.com/aws/smithy-go/middleware/APIError (smithy.APIError) or
smithy.APIError interface and then switch on apiErr.ErrorCode() to return true
only for "InvalidGroup.NotFound" and "InvalidGroupId.NotFound"; explicitly do
NOT treat "InvalidGroup.Malformed" as not-found (return false) so malformed IDs
cause test failures; update ec2IsNotFoundError to use errors.As and ErrorCode()
comparisons instead of strings.Contains.
In `@cmd/cloud-controller-manager-aws-tests-ext/main.go`:
- Around line 173-177: Fix the typo in the comment above the
framework.AfterReadingAllFlags(testContext) call: change "leding" to "leading"
so the comment reads "...and leading to issues in Ginkgo phases
(PhaseBuildTopLevel, PhaseBuildTree, PhaseRun), such as:'cannot clone suite
after tree has been built'".
- Around line 105-124: The function getRegionFromEnv currently mutates
environment variables (calls os.Setenv for AWS_REGION) when reading
LEASED_RESOURCE or AWS_DEFAULT_REGION; either remove these side effects so the
function only returns the resolved region, or split into two functions:
getRegionFromEnv (pure getter that reads LEASED_RESOURCE, AWS_REGION,
AWS_DEFAULT_REGION and returns the region) and setRegionEnv(region string) which
performs os.Setenv("AWS_REGION", region) when desired; if you prefer keeping
behavior, rename getRegionFromEnv to getAndSetRegionFromEnv to make the side
effect explicit and update all call sites accordingly.
In `@Makefile`:
- Line 40: The Makefile's build target ("build: operator config-sync-controllers
azure-config-credentials-injector cloud-controller-manager-aws-tests-ext")
should be declared phony so it always runs; add a .PHONY declaration that
includes build (e.g., add ".PHONY: build" alongside any other phony targets) so
the make tool doesn't treat "build" as a real file and will always execute the
recipe.
- Around line 51-56: The target cloud-controller-manager-aws-tests-ext uses
pushd to change directories but never restores the original directory; update
the shell recipe so pushd cmd/cloud-controller-manager-aws-tests-ext is paired
with a corresponding popd after the go build step (e.g., ensure the sequence
ends with popd or chain commands so popd always runs even on failure) to restore
the working directory.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository: openshift/coderabbit/.coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: 202486ca-22bf-47b5-9126-7a3de9893062
⛔ Files ignored due to path filters (292)
cmd/cloud-controller-manager-aws-tests-ext/go.sumis excluded by!**/*.sumcmd/cloud-controller-manager-aws-tests-ext/vendor/cel.dev/expr/.bazelversionis excluded by!**/vendor/**cmd/cloud-controller-manager-aws-tests-ext/vendor/cel.dev/expr/.gitattributesis excluded by!**/vendor/**cmd/cloud-controller-manager-aws-tests-ext/vendor/cel.dev/expr/.gitignoreis excluded by!**/vendor/**cmd/cloud-controller-manager-aws-tests-ext/vendor/cel.dev/expr/BUILD.bazelis excluded by!**/vendor/**cmd/cloud-controller-manager-aws-tests-ext/vendor/cel.dev/expr/CODE_OF_CONDUCT.mdis excluded by!**/vendor/**cmd/cloud-controller-manager-aws-tests-ext/vendor/cel.dev/expr/CONTRIBUTING.mdis excluded by!**/vendor/**cmd/cloud-controller-manager-aws-tests-ext/vendor/cel.dev/expr/GOVERNANCE.mdis excluded by!**/vendor/**cmd/cloud-controller-manager-aws-tests-ext/vendor/cel.dev/expr/LICENSEis excluded by!**/vendor/**cmd/cloud-controller-manager-aws-tests-ext/vendor/cel.dev/expr/MAINTAINERS.mdis excluded by!**/vendor/**cmd/cloud-controller-manager-aws-tests-ext/vendor/cel.dev/expr/MODULE.bazelis excluded by!**/vendor/**cmd/cloud-controller-manager-aws-tests-ext/vendor/cel.dev/expr/README.mdis excluded by!**/vendor/**cmd/cloud-controller-manager-aws-tests-ext/vendor/cel.dev/expr/WORKSPACEis excluded by!**/vendor/**cmd/cloud-controller-manager-aws-tests-ext/vendor/cel.dev/expr/WORKSPACE.bzlmodis excluded by!**/vendor/**cmd/cloud-controller-manager-aws-tests-ext/vendor/cel.dev/expr/checked.pb.gois excluded by!**/*.pb.go,!**/vendor/**cmd/cloud-controller-manager-aws-tests-ext/vendor/cel.dev/expr/cloudbuild.yamlis excluded by!**/vendor/**cmd/cloud-controller-manager-aws-tests-ext/vendor/cel.dev/expr/eval.pb.gois excluded by!**/*.pb.go,!**/vendor/**cmd/cloud-controller-manager-aws-tests-ext/vendor/cel.dev/expr/explain.pb.gois excluded by!**/*.pb.go,!**/vendor/**cmd/cloud-controller-manager-aws-tests-ext/vendor/cel.dev/expr/regen_go_proto.shis excluded by!**/vendor/**cmd/cloud-controller-manager-aws-tests-ext/vendor/cel.dev/expr/regen_go_proto_canonical_protos.shis excluded by!**/vendor/**cmd/cloud-controller-manager-aws-tests-ext/vendor/cel.dev/expr/syntax.pb.gois excluded by!**/*.pb.go,!**/vendor/**cmd/cloud-controller-manager-aws-tests-ext/vendor/cel.dev/expr/value.pb.gois excluded by!**/*.pb.go,!**/vendor/**cmd/cloud-controller-manager-aws-tests-ext/vendor/github.com/Masterminds/semver/v3/.gitignoreis excluded by!**/vendor/**cmd/cloud-controller-manager-aws-tests-ext/vendor/github.com/Masterminds/semver/v3/.golangci.ymlis excluded by!**/vendor/**cmd/cloud-controller-manager-aws-tests-ext/vendor/github.com/Masterminds/semver/v3/CHANGELOG.mdis excluded by!**/vendor/**cmd/cloud-controller-manager-aws-tests-ext/vendor/github.com/Masterminds/semver/v3/LICENSE.txtis excluded by!**/vendor/**cmd/cloud-controller-manager-aws-tests-ext/vendor/github.com/Masterminds/semver/v3/Makefileis excluded by!**/vendor/**cmd/cloud-controller-manager-aws-tests-ext/vendor/github.com/Masterminds/semver/v3/README.mdis excluded by!**/vendor/**cmd/cloud-controller-manager-aws-tests-ext/vendor/github.com/Masterminds/semver/v3/SECURITY.mdis excluded by!**/vendor/**cmd/cloud-controller-manager-aws-tests-ext/vendor/github.com/Masterminds/semver/v3/collection.gois excluded by!**/vendor/**cmd/cloud-controller-manager-aws-tests-ext/vendor/github.com/Masterminds/semver/v3/constraints.gois excluded by!**/vendor/**cmd/cloud-controller-manager-aws-tests-ext/vendor/github.com/Masterminds/semver/v3/doc.gois excluded by!**/vendor/**cmd/cloud-controller-manager-aws-tests-ext/vendor/github.com/Masterminds/semver/v3/version.gois excluded by!**/vendor/**cmd/cloud-controller-manager-aws-tests-ext/vendor/github.com/antlr4-go/antlr/v4/.gitignoreis excluded by!**/vendor/**cmd/cloud-controller-manager-aws-tests-ext/vendor/github.com/antlr4-go/antlr/v4/LICENSEis excluded by!**/vendor/**cmd/cloud-controller-manager-aws-tests-ext/vendor/github.com/antlr4-go/antlr/v4/README.mdis excluded by!**/vendor/**cmd/cloud-controller-manager-aws-tests-ext/vendor/github.com/antlr4-go/antlr/v4/antlrdoc.gois excluded by!**/vendor/**cmd/cloud-controller-manager-aws-tests-ext/vendor/github.com/antlr4-go/antlr/v4/atn.gois excluded by!**/vendor/**cmd/cloud-controller-manager-aws-tests-ext/vendor/github.com/antlr4-go/antlr/v4/atn_config.gois excluded by!**/vendor/**cmd/cloud-controller-manager-aws-tests-ext/vendor/github.com/antlr4-go/antlr/v4/atn_config_set.gois excluded by!**/vendor/**cmd/cloud-controller-manager-aws-tests-ext/vendor/github.com/antlr4-go/antlr/v4/atn_deserialization_options.gois excluded by!**/vendor/**cmd/cloud-controller-manager-aws-tests-ext/vendor/github.com/antlr4-go/antlr/v4/atn_deserializer.gois excluded by!**/vendor/**cmd/cloud-controller-manager-aws-tests-ext/vendor/github.com/antlr4-go/antlr/v4/atn_simulator.gois excluded by!**/vendor/**cmd/cloud-controller-manager-aws-tests-ext/vendor/github.com/antlr4-go/antlr/v4/atn_state.gois excluded by!**/vendor/**cmd/cloud-controller-manager-aws-tests-ext/vendor/github.com/antlr4-go/antlr/v4/atn_type.gois excluded by!**/vendor/**cmd/cloud-controller-manager-aws-tests-ext/vendor/github.com/antlr4-go/antlr/v4/char_stream.gois excluded by!**/vendor/**cmd/cloud-controller-manager-aws-tests-ext/vendor/github.com/antlr4-go/antlr/v4/common_token_factory.gois excluded by!**/vendor/**cmd/cloud-controller-manager-aws-tests-ext/vendor/github.com/antlr4-go/antlr/v4/common_token_stream.gois excluded by!**/vendor/**cmd/cloud-controller-manager-aws-tests-ext/vendor/github.com/antlr4-go/antlr/v4/comparators.gois excluded by!**/vendor/**cmd/cloud-controller-manager-aws-tests-ext/vendor/github.com/antlr4-go/antlr/v4/configuration.gois excluded by!**/vendor/**cmd/cloud-controller-manager-aws-tests-ext/vendor/github.com/antlr4-go/antlr/v4/dfa.gois excluded by!**/vendor/**cmd/cloud-controller-manager-aws-tests-ext/vendor/github.com/antlr4-go/antlr/v4/dfa_serializer.gois excluded by!**/vendor/**cmd/cloud-controller-manager-aws-tests-ext/vendor/github.com/antlr4-go/antlr/v4/dfa_state.gois excluded by!**/vendor/**cmd/cloud-controller-manager-aws-tests-ext/vendor/github.com/antlr4-go/antlr/v4/diagnostic_error_listener.gois excluded by!**/vendor/**cmd/cloud-controller-manager-aws-tests-ext/vendor/github.com/antlr4-go/antlr/v4/error_listener.gois excluded by!**/vendor/**cmd/cloud-controller-manager-aws-tests-ext/vendor/github.com/antlr4-go/antlr/v4/error_strategy.gois excluded by!**/vendor/**cmd/cloud-controller-manager-aws-tests-ext/vendor/github.com/antlr4-go/antlr/v4/errors.gois excluded by!**/vendor/**cmd/cloud-controller-manager-aws-tests-ext/vendor/github.com/antlr4-go/antlr/v4/file_stream.gois excluded by!**/vendor/**cmd/cloud-controller-manager-aws-tests-ext/vendor/github.com/antlr4-go/antlr/v4/input_stream.gois excluded by!**/vendor/**cmd/cloud-controller-manager-aws-tests-ext/vendor/github.com/antlr4-go/antlr/v4/int_stream.gois excluded by!**/vendor/**cmd/cloud-controller-manager-aws-tests-ext/vendor/github.com/antlr4-go/antlr/v4/interval_set.gois excluded by!**/vendor/**cmd/cloud-controller-manager-aws-tests-ext/vendor/github.com/antlr4-go/antlr/v4/jcollect.gois excluded by!**/vendor/**cmd/cloud-controller-manager-aws-tests-ext/vendor/github.com/antlr4-go/antlr/v4/lexer.gois excluded by!**/vendor/**cmd/cloud-controller-manager-aws-tests-ext/vendor/github.com/antlr4-go/antlr/v4/lexer_action.gois excluded by!**/vendor/**cmd/cloud-controller-manager-aws-tests-ext/vendor/github.com/antlr4-go/antlr/v4/lexer_action_executor.gois excluded by!**/vendor/**cmd/cloud-controller-manager-aws-tests-ext/vendor/github.com/antlr4-go/antlr/v4/lexer_atn_simulator.gois excluded by!**/vendor/**cmd/cloud-controller-manager-aws-tests-ext/vendor/github.com/antlr4-go/antlr/v4/ll1_analyzer.gois excluded by!**/vendor/**cmd/cloud-controller-manager-aws-tests-ext/vendor/github.com/antlr4-go/antlr/v4/nostatistics.gois excluded by!**/vendor/**cmd/cloud-controller-manager-aws-tests-ext/vendor/github.com/antlr4-go/antlr/v4/parser.gois excluded by!**/vendor/**cmd/cloud-controller-manager-aws-tests-ext/vendor/github.com/antlr4-go/antlr/v4/parser_atn_simulator.gois excluded by!**/vendor/**cmd/cloud-controller-manager-aws-tests-ext/vendor/github.com/antlr4-go/antlr/v4/parser_rule_context.gois excluded by!**/vendor/**cmd/cloud-controller-manager-aws-tests-ext/vendor/github.com/antlr4-go/antlr/v4/prediction_context.gois excluded by!**/vendor/**cmd/cloud-controller-manager-aws-tests-ext/vendor/github.com/antlr4-go/antlr/v4/prediction_context_cache.gois excluded by!**/vendor/**cmd/cloud-controller-manager-aws-tests-ext/vendor/github.com/antlr4-go/antlr/v4/prediction_mode.gois excluded by!**/vendor/**cmd/cloud-controller-manager-aws-tests-ext/vendor/github.com/antlr4-go/antlr/v4/recognizer.gois excluded by!**/vendor/**cmd/cloud-controller-manager-aws-tests-ext/vendor/github.com/antlr4-go/antlr/v4/rule_context.gois excluded by!**/vendor/**cmd/cloud-controller-manager-aws-tests-ext/vendor/github.com/antlr4-go/antlr/v4/semantic_context.gois excluded by!**/vendor/**cmd/cloud-controller-manager-aws-tests-ext/vendor/github.com/antlr4-go/antlr/v4/statistics.gois excluded by!**/vendor/**cmd/cloud-controller-manager-aws-tests-ext/vendor/github.com/antlr4-go/antlr/v4/stats_data.gois excluded by!**/vendor/**cmd/cloud-controller-manager-aws-tests-ext/vendor/github.com/antlr4-go/antlr/v4/token.gois excluded by!**/vendor/**cmd/cloud-controller-manager-aws-tests-ext/vendor/github.com/antlr4-go/antlr/v4/token_source.gois excluded by!**/vendor/**cmd/cloud-controller-manager-aws-tests-ext/vendor/github.com/antlr4-go/antlr/v4/token_stream.gois excluded by!**/vendor/**cmd/cloud-controller-manager-aws-tests-ext/vendor/github.com/antlr4-go/antlr/v4/tokenstream_rewriter.gois excluded by!**/vendor/**cmd/cloud-controller-manager-aws-tests-ext/vendor/github.com/antlr4-go/antlr/v4/trace_listener.gois excluded by!**/vendor/**cmd/cloud-controller-manager-aws-tests-ext/vendor/github.com/antlr4-go/antlr/v4/transition.gois excluded by!**/vendor/**cmd/cloud-controller-manager-aws-tests-ext/vendor/github.com/antlr4-go/antlr/v4/tree.gois excluded by!**/vendor/**cmd/cloud-controller-manager-aws-tests-ext/vendor/github.com/antlr4-go/antlr/v4/trees.gois excluded by!**/vendor/**cmd/cloud-controller-manager-aws-tests-ext/vendor/github.com/antlr4-go/antlr/v4/utils.gois excluded by!**/vendor/**cmd/cloud-controller-manager-aws-tests-ext/vendor/github.com/aws/aws-sdk-go-v2/LICENSE.txtis excluded by!**/vendor/**cmd/cloud-controller-manager-aws-tests-ext/vendor/github.com/aws/aws-sdk-go-v2/NOTICE.txtis excluded by!**/vendor/**cmd/cloud-controller-manager-aws-tests-ext/vendor/github.com/aws/aws-sdk-go-v2/aws/accountid_endpoint_mode.gois excluded by!**/vendor/**cmd/cloud-controller-manager-aws-tests-ext/vendor/github.com/aws/aws-sdk-go-v2/aws/checksum.gois excluded by!**/vendor/**cmd/cloud-controller-manager-aws-tests-ext/vendor/github.com/aws/aws-sdk-go-v2/aws/config.gois excluded by!**/vendor/**cmd/cloud-controller-manager-aws-tests-ext/vendor/github.com/aws/aws-sdk-go-v2/aws/context.gois excluded by!**/vendor/**cmd/cloud-controller-manager-aws-tests-ext/vendor/github.com/aws/aws-sdk-go-v2/aws/credential_cache.gois excluded by!**/vendor/**cmd/cloud-controller-manager-aws-tests-ext/vendor/github.com/aws/aws-sdk-go-v2/aws/credentials.gois excluded by!**/vendor/**cmd/cloud-controller-manager-aws-tests-ext/vendor/github.com/aws/aws-sdk-go-v2/aws/defaults/auto.gois excluded by!**/vendor/**cmd/cloud-controller-manager-aws-tests-ext/vendor/github.com/aws/aws-sdk-go-v2/aws/defaults/configuration.gois excluded by!**/vendor/**cmd/cloud-controller-manager-aws-tests-ext/vendor/github.com/aws/aws-sdk-go-v2/aws/defaults/defaults.gois excluded by!**/vendor/**cmd/cloud-controller-manager-aws-tests-ext/vendor/github.com/aws/aws-sdk-go-v2/aws/defaults/doc.gois excluded by!**/vendor/**cmd/cloud-controller-manager-aws-tests-ext/vendor/github.com/aws/aws-sdk-go-v2/aws/defaultsmode.gois excluded by!**/vendor/**cmd/cloud-controller-manager-aws-tests-ext/vendor/github.com/aws/aws-sdk-go-v2/aws/doc.gois excluded by!**/vendor/**cmd/cloud-controller-manager-aws-tests-ext/vendor/github.com/aws/aws-sdk-go-v2/aws/endpoints.gois excluded by!**/vendor/**cmd/cloud-controller-manager-aws-tests-ext/vendor/github.com/aws/aws-sdk-go-v2/aws/errors.gois excluded by!**/vendor/**cmd/cloud-controller-manager-aws-tests-ext/vendor/github.com/aws/aws-sdk-go-v2/aws/from_ptr.gois excluded by!**/vendor/**cmd/cloud-controller-manager-aws-tests-ext/vendor/github.com/aws/aws-sdk-go-v2/aws/go_module_metadata.gois excluded by!**/vendor/**cmd/cloud-controller-manager-aws-tests-ext/vendor/github.com/aws/aws-sdk-go-v2/aws/logging.gois excluded by!**/vendor/**cmd/cloud-controller-manager-aws-tests-ext/vendor/github.com/aws/aws-sdk-go-v2/aws/logging_generate.gois excluded by!**/vendor/**cmd/cloud-controller-manager-aws-tests-ext/vendor/github.com/aws/aws-sdk-go-v2/aws/middleware/metadata.gois excluded by!**/vendor/**cmd/cloud-controller-manager-aws-tests-ext/vendor/github.com/aws/aws-sdk-go-v2/aws/middleware/middleware.gois excluded by!**/vendor/**cmd/cloud-controller-manager-aws-tests-ext/vendor/github.com/aws/aws-sdk-go-v2/aws/middleware/osname.gois excluded by!**/vendor/**cmd/cloud-controller-manager-aws-tests-ext/vendor/github.com/aws/aws-sdk-go-v2/aws/middleware/osname_go115.gois excluded by!**/vendor/**cmd/cloud-controller-manager-aws-tests-ext/vendor/github.com/aws/aws-sdk-go-v2/aws/middleware/recursion_detection.gois excluded by!**/vendor/**cmd/cloud-controller-manager-aws-tests-ext/vendor/github.com/aws/aws-sdk-go-v2/aws/middleware/request_id.gois excluded by!**/vendor/**cmd/cloud-controller-manager-aws-tests-ext/vendor/github.com/aws/aws-sdk-go-v2/aws/middleware/request_id_retriever.gois excluded by!**/vendor/**cmd/cloud-controller-manager-aws-tests-ext/vendor/github.com/aws/aws-sdk-go-v2/aws/middleware/user_agent.gois excluded by!**/vendor/**cmd/cloud-controller-manager-aws-tests-ext/vendor/github.com/aws/aws-sdk-go-v2/aws/protocol/ec2query/error_utils.gois excluded by!**/vendor/**cmd/cloud-controller-manager-aws-tests-ext/vendor/github.com/aws/aws-sdk-go-v2/aws/protocol/query/array.gois excluded by!**/vendor/**cmd/cloud-controller-manager-aws-tests-ext/vendor/github.com/aws/aws-sdk-go-v2/aws/protocol/query/encoder.gois excluded by!**/vendor/**cmd/cloud-controller-manager-aws-tests-ext/vendor/github.com/aws/aws-sdk-go-v2/aws/protocol/query/map.gois excluded by!**/vendor/**cmd/cloud-controller-manager-aws-tests-ext/vendor/github.com/aws/aws-sdk-go-v2/aws/protocol/query/middleware.gois excluded by!**/vendor/**cmd/cloud-controller-manager-aws-tests-ext/vendor/github.com/aws/aws-sdk-go-v2/aws/protocol/query/object.gois excluded by!**/vendor/**cmd/cloud-controller-manager-aws-tests-ext/vendor/github.com/aws/aws-sdk-go-v2/aws/protocol/query/value.gois excluded by!**/vendor/**cmd/cloud-controller-manager-aws-tests-ext/vendor/github.com/aws/aws-sdk-go-v2/aws/protocol/restjson/decoder_util.gois excluded by!**/vendor/**cmd/cloud-controller-manager-aws-tests-ext/vendor/github.com/aws/aws-sdk-go-v2/aws/protocol/xml/error_utils.gois excluded by!**/vendor/**cmd/cloud-controller-manager-aws-tests-ext/vendor/github.com/aws/aws-sdk-go-v2/aws/ratelimit/none.gois excluded by!**/vendor/**cmd/cloud-controller-manager-aws-tests-ext/vendor/github.com/aws/aws-sdk-go-v2/aws/ratelimit/token_bucket.gois excluded by!**/vendor/**cmd/cloud-controller-manager-aws-tests-ext/vendor/github.com/aws/aws-sdk-go-v2/aws/ratelimit/token_rate_limit.gois excluded by!**/vendor/**cmd/cloud-controller-manager-aws-tests-ext/vendor/github.com/aws/aws-sdk-go-v2/aws/request.gois excluded by!**/vendor/**cmd/cloud-controller-manager-aws-tests-ext/vendor/github.com/aws/aws-sdk-go-v2/aws/retry/adaptive.gois excluded by!**/vendor/**cmd/cloud-controller-manager-aws-tests-ext/vendor/github.com/aws/aws-sdk-go-v2/aws/retry/adaptive_ratelimit.gois excluded by!**/vendor/**cmd/cloud-controller-manager-aws-tests-ext/vendor/github.com/aws/aws-sdk-go-v2/aws/retry/adaptive_token_bucket.gois excluded by!**/vendor/**cmd/cloud-controller-manager-aws-tests-ext/vendor/github.com/aws/aws-sdk-go-v2/aws/retry/attempt_metrics.gois excluded by!**/vendor/**cmd/cloud-controller-manager-aws-tests-ext/vendor/github.com/aws/aws-sdk-go-v2/aws/retry/doc.gois excluded by!**/vendor/**cmd/cloud-controller-manager-aws-tests-ext/vendor/github.com/aws/aws-sdk-go-v2/aws/retry/errors.gois excluded by!**/vendor/**cmd/cloud-controller-manager-aws-tests-ext/vendor/github.com/aws/aws-sdk-go-v2/aws/retry/jitter_backoff.gois excluded by!**/vendor/**cmd/cloud-controller-manager-aws-tests-ext/vendor/github.com/aws/aws-sdk-go-v2/aws/retry/metadata.gois excluded by!**/vendor/**cmd/cloud-controller-manager-aws-tests-ext/vendor/github.com/aws/aws-sdk-go-v2/aws/retry/middleware.gois excluded by!**/vendor/**cmd/cloud-controller-manager-aws-tests-ext/vendor/github.com/aws/aws-sdk-go-v2/aws/retry/retry.gois excluded by!**/vendor/**cmd/cloud-controller-manager-aws-tests-ext/vendor/github.com/aws/aws-sdk-go-v2/aws/retry/retryable_error.gois excluded by!**/vendor/**cmd/cloud-controller-manager-aws-tests-ext/vendor/github.com/aws/aws-sdk-go-v2/aws/retry/standard.gois excluded by!**/vendor/**cmd/cloud-controller-manager-aws-tests-ext/vendor/github.com/aws/aws-sdk-go-v2/aws/retry/throttle_error.gois excluded by!**/vendor/**cmd/cloud-controller-manager-aws-tests-ext/vendor/github.com/aws/aws-sdk-go-v2/aws/retry/timeout_error.gois excluded by!**/vendor/**cmd/cloud-controller-manager-aws-tests-ext/vendor/github.com/aws/aws-sdk-go-v2/aws/retryer.gois excluded by!**/vendor/**cmd/cloud-controller-manager-aws-tests-ext/vendor/github.com/aws/aws-sdk-go-v2/aws/runtime.gois excluded by!**/vendor/**cmd/cloud-controller-manager-aws-tests-ext/vendor/github.com/aws/aws-sdk-go-v2/aws/signer/internal/v4/cache.gois excluded by!**/vendor/**cmd/cloud-controller-manager-aws-tests-ext/vendor/github.com/aws/aws-sdk-go-v2/aws/signer/internal/v4/const.gois excluded by!**/vendor/**cmd/cloud-controller-manager-aws-tests-ext/vendor/github.com/aws/aws-sdk-go-v2/aws/signer/internal/v4/header_rules.gois excluded by!**/vendor/**cmd/cloud-controller-manager-aws-tests-ext/vendor/github.com/aws/aws-sdk-go-v2/aws/signer/internal/v4/headers.gois excluded by!**/vendor/**cmd/cloud-controller-manager-aws-tests-ext/vendor/github.com/aws/aws-sdk-go-v2/aws/signer/internal/v4/hmac.gois excluded by!**/vendor/**cmd/cloud-controller-manager-aws-tests-ext/vendor/github.com/aws/aws-sdk-go-v2/aws/signer/internal/v4/host.gois excluded by!**/vendor/**cmd/cloud-controller-manager-aws-tests-ext/vendor/github.com/aws/aws-sdk-go-v2/aws/signer/internal/v4/scope.gois excluded by!**/vendor/**cmd/cloud-controller-manager-aws-tests-ext/vendor/github.com/aws/aws-sdk-go-v2/aws/signer/internal/v4/time.gois excluded by!**/vendor/**cmd/cloud-controller-manager-aws-tests-ext/vendor/github.com/aws/aws-sdk-go-v2/aws/signer/internal/v4/util.gois excluded by!**/vendor/**cmd/cloud-controller-manager-aws-tests-ext/vendor/github.com/aws/aws-sdk-go-v2/aws/signer/v4/middleware.gois excluded by!**/vendor/**cmd/cloud-controller-manager-aws-tests-ext/vendor/github.com/aws/aws-sdk-go-v2/aws/signer/v4/presign_middleware.gois excluded by!**/vendor/**cmd/cloud-controller-manager-aws-tests-ext/vendor/github.com/aws/aws-sdk-go-v2/aws/signer/v4/stream.gois excluded by!**/vendor/**cmd/cloud-controller-manager-aws-tests-ext/vendor/github.com/aws/aws-sdk-go-v2/aws/signer/v4/v4.gois excluded by!**/vendor/**cmd/cloud-controller-manager-aws-tests-ext/vendor/github.com/aws/aws-sdk-go-v2/aws/to_ptr.gois excluded by!**/vendor/**cmd/cloud-controller-manager-aws-tests-ext/vendor/github.com/aws/aws-sdk-go-v2/aws/transport/http/client.gois excluded by!**/vendor/**cmd/cloud-controller-manager-aws-tests-ext/vendor/github.com/aws/aws-sdk-go-v2/aws/transport/http/content_type.gois excluded by!**/vendor/**cmd/cloud-controller-manager-aws-tests-ext/vendor/github.com/aws/aws-sdk-go-v2/aws/transport/http/response_error.gois excluded by!**/vendor/**cmd/cloud-controller-manager-aws-tests-ext/vendor/github.com/aws/aws-sdk-go-v2/aws/transport/http/response_error_middleware.gois excluded by!**/vendor/**cmd/cloud-controller-manager-aws-tests-ext/vendor/github.com/aws/aws-sdk-go-v2/aws/transport/http/timeout_read_closer.gois excluded by!**/vendor/**cmd/cloud-controller-manager-aws-tests-ext/vendor/github.com/aws/aws-sdk-go-v2/aws/types.gois excluded by!**/vendor/**cmd/cloud-controller-manager-aws-tests-ext/vendor/github.com/aws/aws-sdk-go-v2/aws/version.gois excluded by!**/vendor/**cmd/cloud-controller-manager-aws-tests-ext/vendor/github.com/aws/aws-sdk-go-v2/config/CHANGELOG.mdis excluded by!**/vendor/**cmd/cloud-controller-manager-aws-tests-ext/vendor/github.com/aws/aws-sdk-go-v2/config/LICENSE.txtis excluded by!**/vendor/**cmd/cloud-controller-manager-aws-tests-ext/vendor/github.com/aws/aws-sdk-go-v2/config/config.gois excluded by!**/vendor/**cmd/cloud-controller-manager-aws-tests-ext/vendor/github.com/aws/aws-sdk-go-v2/config/defaultsmode.gois excluded by!**/vendor/**cmd/cloud-controller-manager-aws-tests-ext/vendor/github.com/aws/aws-sdk-go-v2/config/doc.gois excluded by!**/vendor/**cmd/cloud-controller-manager-aws-tests-ext/vendor/github.com/aws/aws-sdk-go-v2/config/env_config.gois excluded by!**/vendor/**cmd/cloud-controller-manager-aws-tests-ext/vendor/github.com/aws/aws-sdk-go-v2/config/generate.gois excluded by!**/vendor/**cmd/cloud-controller-manager-aws-tests-ext/vendor/github.com/aws/aws-sdk-go-v2/config/go_module_metadata.gois excluded by!**/vendor/**cmd/cloud-controller-manager-aws-tests-ext/vendor/github.com/aws/aws-sdk-go-v2/config/load_options.gois excluded by!**/vendor/**cmd/cloud-controller-manager-aws-tests-ext/vendor/github.com/aws/aws-sdk-go-v2/config/local.gois excluded by!**/vendor/**cmd/cloud-controller-manager-aws-tests-ext/vendor/github.com/aws/aws-sdk-go-v2/config/provider.gois excluded by!**/vendor/**cmd/cloud-controller-manager-aws-tests-ext/vendor/github.com/aws/aws-sdk-go-v2/config/resolve.gois excluded by!**/vendor/**cmd/cloud-controller-manager-aws-tests-ext/vendor/github.com/aws/aws-sdk-go-v2/config/resolve_bearer_token.gois excluded by!**/vendor/**cmd/cloud-controller-manager-aws-tests-ext/vendor/github.com/aws/aws-sdk-go-v2/config/resolve_credentials.gois excluded by!**/vendor/**cmd/cloud-controller-manager-aws-tests-ext/vendor/github.com/aws/aws-sdk-go-v2/config/shared_config.gois excluded by!**/vendor/**cmd/cloud-controller-manager-aws-tests-ext/vendor/github.com/aws/aws-sdk-go-v2/credentials/CHANGELOG.mdis excluded by!**/vendor/**cmd/cloud-controller-manager-aws-tests-ext/vendor/github.com/aws/aws-sdk-go-v2/credentials/LICENSE.txtis excluded by!**/vendor/**cmd/cloud-controller-manager-aws-tests-ext/vendor/github.com/aws/aws-sdk-go-v2/credentials/doc.gois excluded by!**/vendor/**cmd/cloud-controller-manager-aws-tests-ext/vendor/github.com/aws/aws-sdk-go-v2/credentials/ec2rolecreds/doc.gois excluded by!**/vendor/**cmd/cloud-controller-manager-aws-tests-ext/vendor/github.com/aws/aws-sdk-go-v2/credentials/ec2rolecreds/provider.gois excluded by!**/vendor/**cmd/cloud-controller-manager-aws-tests-ext/vendor/github.com/aws/aws-sdk-go-v2/credentials/endpointcreds/internal/client/auth.gois excluded by!**/vendor/**cmd/cloud-controller-manager-aws-tests-ext/vendor/github.com/aws/aws-sdk-go-v2/credentials/endpointcreds/internal/client/client.gois excluded by!**/vendor/**cmd/cloud-controller-manager-aws-tests-ext/vendor/github.com/aws/aws-sdk-go-v2/credentials/endpointcreds/internal/client/endpoints.gois excluded by!**/vendor/**cmd/cloud-controller-manager-aws-tests-ext/vendor/github.com/aws/aws-sdk-go-v2/credentials/endpointcreds/internal/client/middleware.gois excluded by!**/vendor/**cmd/cloud-controller-manager-aws-tests-ext/vendor/github.com/aws/aws-sdk-go-v2/credentials/endpointcreds/provider.gois excluded by!**/vendor/**cmd/cloud-controller-manager-aws-tests-ext/vendor/github.com/aws/aws-sdk-go-v2/credentials/go_module_metadata.gois excluded by!**/vendor/**cmd/cloud-controller-manager-aws-tests-ext/vendor/github.com/aws/aws-sdk-go-v2/credentials/processcreds/doc.gois excluded by!**/vendor/**cmd/cloud-controller-manager-aws-tests-ext/vendor/github.com/aws/aws-sdk-go-v2/credentials/processcreds/provider.gois excluded by!**/vendor/**cmd/cloud-controller-manager-aws-tests-ext/vendor/github.com/aws/aws-sdk-go-v2/credentials/ssocreds/doc.gois excluded by!**/vendor/**cmd/cloud-controller-manager-aws-tests-ext/vendor/github.com/aws/aws-sdk-go-v2/credentials/ssocreds/sso_cached_token.gois excluded by!**/vendor/**cmd/cloud-controller-manager-aws-tests-ext/vendor/github.com/aws/aws-sdk-go-v2/credentials/ssocreds/sso_credentials_provider.gois excluded by!**/vendor/**cmd/cloud-controller-manager-aws-tests-ext/vendor/github.com/aws/aws-sdk-go-v2/credentials/ssocreds/sso_token_provider.gois excluded by!**/vendor/**cmd/cloud-controller-manager-aws-tests-ext/vendor/github.com/aws/aws-sdk-go-v2/credentials/static_provider.gois excluded by!**/vendor/**cmd/cloud-controller-manager-aws-tests-ext/vendor/github.com/aws/aws-sdk-go-v2/credentials/stscreds/assume_role_provider.gois excluded by!**/vendor/**cmd/cloud-controller-manager-aws-tests-ext/vendor/github.com/aws/aws-sdk-go-v2/credentials/stscreds/web_identity_provider.gois excluded by!**/vendor/**cmd/cloud-controller-manager-aws-tests-ext/vendor/github.com/aws/aws-sdk-go-v2/feature/ec2/imds/CHANGELOG.mdis excluded by!**/vendor/**cmd/cloud-controller-manager-aws-tests-ext/vendor/github.com/aws/aws-sdk-go-v2/feature/ec2/imds/LICENSE.txtis excluded by!**/vendor/**cmd/cloud-controller-manager-aws-tests-ext/vendor/github.com/aws/aws-sdk-go-v2/feature/ec2/imds/api_client.gois excluded by!**/vendor/**cmd/cloud-controller-manager-aws-tests-ext/vendor/github.com/aws/aws-sdk-go-v2/feature/ec2/imds/api_op_GetDynamicData.gois excluded by!**/vendor/**cmd/cloud-controller-manager-aws-tests-ext/vendor/github.com/aws/aws-sdk-go-v2/feature/ec2/imds/api_op_GetIAMInfo.gois excluded by!**/vendor/**cmd/cloud-controller-manager-aws-tests-ext/vendor/github.com/aws/aws-sdk-go-v2/feature/ec2/imds/api_op_GetInstanceIdentityDocument.gois excluded by!**/vendor/**cmd/cloud-controller-manager-aws-tests-ext/vendor/github.com/aws/aws-sdk-go-v2/feature/ec2/imds/api_op_GetMetadata.gois excluded by!**/vendor/**cmd/cloud-controller-manager-aws-tests-ext/vendor/github.com/aws/aws-sdk-go-v2/feature/ec2/imds/api_op_GetRegion.gois excluded by!**/vendor/**cmd/cloud-controller-manager-aws-tests-ext/vendor/github.com/aws/aws-sdk-go-v2/feature/ec2/imds/api_op_GetToken.gois excluded by!**/vendor/**cmd/cloud-controller-manager-aws-tests-ext/vendor/github.com/aws/aws-sdk-go-v2/feature/ec2/imds/api_op_GetUserData.gois excluded by!**/vendor/**cmd/cloud-controller-manager-aws-tests-ext/vendor/github.com/aws/aws-sdk-go-v2/feature/ec2/imds/auth.gois excluded by!**/vendor/**cmd/cloud-controller-manager-aws-tests-ext/vendor/github.com/aws/aws-sdk-go-v2/feature/ec2/imds/doc.gois excluded by!**/vendor/**cmd/cloud-controller-manager-aws-tests-ext/vendor/github.com/aws/aws-sdk-go-v2/feature/ec2/imds/endpoints.gois excluded by!**/vendor/**cmd/cloud-controller-manager-aws-tests-ext/vendor/github.com/aws/aws-sdk-go-v2/feature/ec2/imds/go_module_metadata.gois excluded by!**/vendor/**cmd/cloud-controller-manager-aws-tests-ext/vendor/github.com/aws/aws-sdk-go-v2/feature/ec2/imds/internal/config/resolvers.gois excluded by!**/vendor/**cmd/cloud-controller-manager-aws-tests-ext/vendor/github.com/aws/aws-sdk-go-v2/feature/ec2/imds/request_middleware.gois excluded by!**/vendor/**cmd/cloud-controller-manager-aws-tests-ext/vendor/github.com/aws/aws-sdk-go-v2/feature/ec2/imds/token_provider.gois excluded by!**/vendor/**cmd/cloud-controller-manager-aws-tests-ext/vendor/github.com/aws/aws-sdk-go-v2/internal/auth/auth.gois excluded by!**/vendor/**cmd/cloud-controller-manager-aws-tests-ext/vendor/github.com/aws/aws-sdk-go-v2/internal/auth/scheme.gois excluded by!**/vendor/**cmd/cloud-controller-manager-aws-tests-ext/vendor/github.com/aws/aws-sdk-go-v2/internal/auth/smithy/bearer_token_adapter.gois excluded by!**/vendor/**cmd/cloud-controller-manager-aws-tests-ext/vendor/github.com/aws/aws-sdk-go-v2/internal/auth/smithy/bearer_token_signer_adapter.gois excluded by!**/vendor/**cmd/cloud-controller-manager-aws-tests-ext/vendor/github.com/aws/aws-sdk-go-v2/internal/auth/smithy/credentials_adapter.gois excluded by!**/vendor/**cmd/cloud-controller-manager-aws-tests-ext/vendor/github.com/aws/aws-sdk-go-v2/internal/auth/smithy/smithy.gois excluded by!**/vendor/**cmd/cloud-controller-manager-aws-tests-ext/vendor/github.com/aws/aws-sdk-go-v2/internal/auth/smithy/v4signer_adapter.gois excluded by!**/vendor/**cmd/cloud-controller-manager-aws-tests-ext/vendor/github.com/aws/aws-sdk-go-v2/internal/configsources/CHANGELOG.mdis excluded by!**/vendor/**cmd/cloud-controller-manager-aws-tests-ext/vendor/github.com/aws/aws-sdk-go-v2/internal/configsources/LICENSE.txtis excluded by!**/vendor/**cmd/cloud-controller-manager-aws-tests-ext/vendor/github.com/aws/aws-sdk-go-v2/internal/configsources/config.gois excluded by!**/vendor/**cmd/cloud-controller-manager-aws-tests-ext/vendor/github.com/aws/aws-sdk-go-v2/internal/configsources/endpoints.gois excluded by!**/vendor/**cmd/cloud-controller-manager-aws-tests-ext/vendor/github.com/aws/aws-sdk-go-v2/internal/configsources/go_module_metadata.gois excluded by!**/vendor/**cmd/cloud-controller-manager-aws-tests-ext/vendor/github.com/aws/aws-sdk-go-v2/internal/context/context.gois excluded by!**/vendor/**cmd/cloud-controller-manager-aws-tests-ext/vendor/github.com/aws/aws-sdk-go-v2/internal/endpoints/awsrulesfn/arn.gois excluded by!**/vendor/**cmd/cloud-controller-manager-aws-tests-ext/vendor/github.com/aws/aws-sdk-go-v2/internal/endpoints/awsrulesfn/doc.gois excluded by!**/vendor/**cmd/cloud-controller-manager-aws-tests-ext/vendor/github.com/aws/aws-sdk-go-v2/internal/endpoints/awsrulesfn/generate.gois excluded by!**/vendor/**cmd/cloud-controller-manager-aws-tests-ext/vendor/github.com/aws/aws-sdk-go-v2/internal/endpoints/awsrulesfn/host.gois excluded by!**/vendor/**cmd/cloud-controller-manager-aws-tests-ext/vendor/github.com/aws/aws-sdk-go-v2/internal/endpoints/awsrulesfn/partition.gois excluded by!**/vendor/**cmd/cloud-controller-manager-aws-tests-ext/vendor/github.com/aws/aws-sdk-go-v2/internal/endpoints/awsrulesfn/partitions.gois excluded by!**/vendor/**cmd/cloud-controller-manager-aws-tests-ext/vendor/github.com/aws/aws-sdk-go-v2/internal/endpoints/awsrulesfn/partitions.jsonis excluded by!**/vendor/**cmd/cloud-controller-manager-aws-tests-ext/vendor/github.com/aws/aws-sdk-go-v2/internal/endpoints/endpoints.gois excluded by!**/vendor/**cmd/cloud-controller-manager-aws-tests-ext/vendor/github.com/aws/aws-sdk-go-v2/internal/endpoints/v2/CHANGELOG.mdis excluded by!**/vendor/**cmd/cloud-controller-manager-aws-tests-ext/vendor/github.com/aws/aws-sdk-go-v2/internal/endpoints/v2/LICENSE.txtis excluded by!**/vendor/**cmd/cloud-controller-manager-aws-tests-ext/vendor/github.com/aws/aws-sdk-go-v2/internal/endpoints/v2/endpoints.gois excluded by!**/vendor/**cmd/cloud-controller-manager-aws-tests-ext/vendor/github.com/aws/aws-sdk-go-v2/internal/endpoints/v2/go_module_metadata.gois excluded by!**/vendor/**cmd/cloud-controller-manager-aws-tests-ext/vendor/github.com/aws/aws-sdk-go-v2/internal/ini/CHANGELOG.mdis excluded by!**/vendor/**cmd/cloud-controller-manager-aws-tests-ext/vendor/github.com/aws/aws-sdk-go-v2/internal/ini/LICENSE.txtis excluded by!**/vendor/**cmd/cloud-controller-manager-aws-tests-ext/vendor/github.com/aws/aws-sdk-go-v2/internal/ini/errors.gois excluded by!**/vendor/**cmd/cloud-controller-manager-aws-tests-ext/vendor/github.com/aws/aws-sdk-go-v2/internal/ini/go_module_metadata.gois excluded by!**/vendor/**cmd/cloud-controller-manager-aws-tests-ext/vendor/github.com/aws/aws-sdk-go-v2/internal/ini/ini.gois excluded by!**/vendor/**cmd/cloud-controller-manager-aws-tests-ext/vendor/github.com/aws/aws-sdk-go-v2/internal/ini/parse.gois excluded by!**/vendor/**cmd/cloud-controller-manager-aws-tests-ext/vendor/github.com/aws/aws-sdk-go-v2/internal/ini/sections.gois excluded by!**/vendor/**cmd/cloud-controller-manager-aws-tests-ext/vendor/github.com/aws/aws-sdk-go-v2/internal/ini/strings.gois excluded by!**/vendor/**cmd/cloud-controller-manager-aws-tests-ext/vendor/github.com/aws/aws-sdk-go-v2/internal/ini/token.gois excluded by!**/vendor/**cmd/cloud-controller-manager-aws-tests-ext/vendor/github.com/aws/aws-sdk-go-v2/internal/ini/tokenize.gois excluded by!**/vendor/**cmd/cloud-controller-manager-aws-tests-ext/vendor/github.com/aws/aws-sdk-go-v2/internal/ini/value.gois excluded by!**/vendor/**cmd/cloud-controller-manager-aws-tests-ext/vendor/github.com/aws/aws-sdk-go-v2/internal/middleware/middleware.gois excluded by!**/vendor/**cmd/cloud-controller-manager-aws-tests-ext/vendor/github.com/aws/aws-sdk-go-v2/internal/rand/rand.gois excluded by!**/vendor/**cmd/cloud-controller-manager-aws-tests-ext/vendor/github.com/aws/aws-sdk-go-v2/internal/sdk/interfaces.gois excluded by!**/vendor/**cmd/cloud-controller-manager-aws-tests-ext/vendor/github.com/aws/aws-sdk-go-v2/internal/sdk/time.gois excluded by!**/vendor/**cmd/cloud-controller-manager-aws-tests-ext/vendor/github.com/aws/aws-sdk-go-v2/internal/sdkio/byte.gois excluded by!**/vendor/**cmd/cloud-controller-manager-aws-tests-ext/vendor/github.com/aws/aws-sdk-go-v2/internal/shareddefaults/shared_config.gois excluded by!**/vendor/**cmd/cloud-controller-manager-aws-tests-ext/vendor/github.com/aws/aws-sdk-go-v2/internal/strings/strings.gois excluded by!**/vendor/**cmd/cloud-controller-manager-aws-tests-ext/vendor/github.com/aws/aws-sdk-go-v2/internal/sync/singleflight/LICENSEis excluded by!**/vendor/**cmd/cloud-controller-manager-aws-tests-ext/vendor/github.com/aws/aws-sdk-go-v2/internal/sync/singleflight/docs.gois excluded by!**/vendor/**cmd/cloud-controller-manager-aws-tests-ext/vendor/github.com/aws/aws-sdk-go-v2/internal/sync/singleflight/singleflight.gois excluded by!**/vendor/**cmd/cloud-controller-manager-aws-tests-ext/vendor/github.com/aws/aws-sdk-go-v2/internal/timeconv/duration.gois excluded by!**/vendor/**cmd/cloud-controller-manager-aws-tests-ext/vendor/github.com/aws/aws-sdk-go-v2/service/ec2/CHANGELOG.mdis excluded by!**/vendor/**cmd/cloud-controller-manager-aws-tests-ext/vendor/github.com/aws/aws-sdk-go-v2/service/ec2/LICENSE.txtis excluded by!**/vendor/**cmd/cloud-controller-manager-aws-tests-ext/vendor/github.com/aws/aws-sdk-go-v2/service/ec2/api_client.gois excluded by!**/vendor/**cmd/cloud-controller-manager-aws-tests-ext/vendor/github.com/aws/aws-sdk-go-v2/service/ec2/api_op_AcceptAddressTransfer.gois excluded by!**/vendor/**cmd/cloud-controller-manager-aws-tests-ext/vendor/github.com/aws/aws-sdk-go-v2/service/ec2/api_op_AcceptCapacityReservationBillingOwnership.gois excluded by!**/vendor/**cmd/cloud-controller-manager-aws-tests-ext/vendor/github.com/aws/aws-sdk-go-v2/service/ec2/api_op_AcceptReservedInstancesExchangeQuote.gois excluded by!**/vendor/**cmd/cloud-controller-manager-aws-tests-ext/vendor/github.com/aws/aws-sdk-go-v2/service/ec2/api_op_AcceptTransitGatewayMulticastDomainAssociations.gois excluded by!**/vendor/**cmd/cloud-controller-manager-aws-tests-ext/vendor/github.com/aws/aws-sdk-go-v2/service/ec2/api_op_AcceptTransitGatewayPeeringAttachment.gois excluded by!**/vendor/**cmd/cloud-controller-manager-aws-tests-ext/vendor/github.com/aws/aws-sdk-go-v2/service/ec2/api_op_AcceptTransitGatewayVpcAttachment.gois excluded by!**/vendor/**cmd/cloud-controller-manager-aws-tests-ext/vendor/github.com/aws/aws-sdk-go-v2/service/ec2/api_op_AcceptVpcEndpointConnections.gois excluded by!**/vendor/**cmd/cloud-controller-manager-aws-tests-ext/vendor/github.com/aws/aws-sdk-go-v2/service/ec2/api_op_AcceptVpcPeeringConnection.gois excluded by!**/vendor/**cmd/cloud-controller-manager-aws-tests-ext/vendor/github.com/aws/aws-sdk-go-v2/service/ec2/api_op_AdvertiseByoipCidr.gois excluded by!**/vendor/**cmd/cloud-controller-manager-aws-tests-ext/vendor/github.com/aws/aws-sdk-go-v2/service/ec2/api_op_AllocateAddress.gois excluded by!**/vendor/**cmd/cloud-controller-manager-aws-tests-ext/vendor/github.com/aws/aws-sdk-go-v2/service/ec2/api_op_AllocateHosts.gois excluded by!**/vendor/**cmd/cloud-controller-manager-aws-tests-ext/vendor/github.com/aws/aws-sdk-go-v2/service/ec2/api_op_AllocateIpamPoolCidr.gois excluded by!**/vendor/**cmd/cloud-controller-manager-aws-tests-ext/vendor/github.com/aws/aws-sdk-go-v2/service/ec2/api_op_ApplySecurityGroupsToClientVpnTargetNetwork.gois excluded by!**/vendor/**cmd/cloud-controller-manager-aws-tests-ext/vendor/github.com/aws/aws-sdk-go-v2/service/ec2/api_op_AssignIpv6Addresses.gois excluded by!**/vendor/**cmd/cloud-controller-manager-aws-tests-ext/vendor/github.com/aws/aws-sdk-go-v2/service/ec2/api_op_AssignPrivateIpAddresses.gois excluded by!**/vendor/**cmd/cloud-controller-manager-aws-tests-ext/vendor/github.com/aws/aws-sdk-go-v2/service/ec2/api_op_AssignPrivateNatGatewayAddress.gois excluded by!**/vendor/**cmd/cloud-controller-manager-aws-tests-ext/vendor/github.com/aws/aws-sdk-go-v2/service/ec2/api_op_AssociateAddress.gois excluded by!**/vendor/**cmd/cloud-controller-manager-aws-tests-ext/vendor/github.com/aws/aws-sdk-go-v2/service/ec2/api_op_AssociateCapacityReservationBillingOwner.gois excluded by!**/vendor/**cmd/cloud-controller-manager-aws-tests-ext/vendor/github.com/aws/aws-sdk-go-v2/service/ec2/api_op_AssociateClientVpnTargetNetwork.gois excluded by!**/vendor/**cmd/cloud-controller-manager-aws-tests-ext/vendor/github.com/aws/aws-sdk-go-v2/service/ec2/api_op_AssociateDhcpOptions.gois excluded by!**/vendor/**cmd/cloud-controller-manager-aws-tests-ext/vendor/github.com/aws/aws-sdk-go-v2/service/ec2/api_op_AssociateEnclaveCertificateIamRole.gois excluded by!**/vendor/**cmd/cloud-controller-manager-aws-tests-ext/vendor/github.com/aws/aws-sdk-go-v2/service/ec2/api_op_AssociateIamInstanceProfile.gois excluded by!**/vendor/**cmd/cloud-controller-manager-aws-tests-ext/vendor/github.com/aws/aws-sdk-go-v2/service/ec2/api_op_AssociateInstanceEventWindow.gois excluded by!**/vendor/**cmd/cloud-controller-manager-aws-tests-ext/vendor/github.com/aws/aws-sdk-go-v2/service/ec2/api_op_AssociateIpamByoasn.gois excluded by!**/vendor/**
📒 Files selected for processing (8)
.dockerignoreDockerfileMakefilecmd/cloud-controller-manager-aws-tests-ext/README.mdcmd/cloud-controller-manager-aws-tests-ext/e2e/helper.gocmd/cloud-controller-manager-aws-tests-ext/e2e/loadbalancer.gocmd/cloud-controller-manager-aws-tests-ext/go.modcmd/cloud-controller-manager-aws-tests-ext/main.go
Comment on lines
+296
to
+304
|
|
||
| currentSGRules, err := getAWSSecurityGroupRules(ctx, ec2Client, foundLB.SecurityGroups) | ||
| framework.ExpectNoError(err, "failed to get security group rules to calculate the diff") | ||
|
|
||
| if len(originalSGRules) >= len(currentSGRules) { | ||
| framework.Logf("Security group rules count did not changed: original=%d current=%d", | ||
| len(originalSGRules), len(currentSGRules)) | ||
| return nil, fmt.Errorf("security group rules count did not changed") | ||
| } |
There was a problem hiding this comment.
Avoid framework.ExpectNoError inside Eventually callback.
Using framework.ExpectNoError inside the Eventually callback will cause an immediate Ginkgo assertion failure on transient errors, preventing Eventually from retrying. Return the error instead to allow proper retry behavior.
🐛 Proposed fix
currentSGRules, err := getAWSSecurityGroupRules(ctx, ec2Client, foundLB.SecurityGroups)
- framework.ExpectNoError(err, "failed to get security group rules to calculate the diff")
+ if err != nil {
+ framework.Logf("failed to get security group rules: %v", err)
+ return nil, err
+ }
if len(originalSGRules) >= len(currentSGRules) {
framework.Logf("Security group rules count did not changed: original=%d current=%d",
len(originalSGRules), len(currentSGRules))
- return nil, fmt.Errorf("security group rules count did not changed")
+ return nil, fmt.Errorf("security group rules count did not change")
}🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In `@cmd/cloud-controller-manager-aws-tests-ext/e2e/loadbalancer.go` around lines
296 - 304, The call to framework.ExpectNoError inside the Eventually callback
prevents retries on transient errors; update the callback so
getAWSSecurityGroupRules(ctx, ec2Client, foundLB.SecurityGroups) returns its
error instead of calling framework.ExpectNoError. Specifically, replace the
ExpectNoError call with logic that checks err and returns nil, err (or
fmt.Errorf-wrapped err) so Eventually can retry; keep the subsequent length
check using originalSGRules and currentSGRules and return the existing
fmt.Errorf when counts haven't changed.
| gopkg.in/yaml.v3 v3.0.1 // indirect | ||
| k8s.io/apiextensions-apiserver v0.0.0 // indirect | ||
| k8s.io/apiserver v0.35.0 // indirect | ||
| k8s.io/cloud-provider v0.34.0 // indirect |
There was a problem hiding this comment.
🧩 Analysis chain
🏁 Script executed:
#!/bin/bash
# Check if cloud-provider v0.34.0 is intentional due to transitive dependencies
cd cmd/cloud-controller-manager-aws-tests-ext
go mod graph | grep cloud-provider | head -20Repository: openshift/cluster-cloud-controller-manager-operator
Length of output: 1533
🏁 Script executed:
cat cmd/cloud-controller-manager-aws-tests-ext/go.mod | grep -E 'k8s\.io' | head -30Repository: openshift/cluster-cloud-controller-manager-operator
Length of output: 1577
🏁 Script executed:
# Check if there are any comments or context around this dependency
sed -n '125,140p' cmd/cloud-controller-manager-aws-tests-ext/go.modRepository: openshift/cluster-cloud-controller-manager-operator
Length of output: 817
Add a replace directive for k8s.io/cloud-provider to align with other Kubernetes module versions.
The indirect dependency k8s.io/cloud-provider v0.34.0 is mismatched with other Kubernetes modules (all at v0.35.0 via direct dependencies and replace directives). This causes the build to resolve multiple versions of the same module (e.g., k8s.io/api v0.35.0 and k8s.io/api v0.34.0 via transitive dependencies), which can lead to API incompatibilities. Add a replace directive:
k8s.io/cloud-provider => k8s.io/cloud-provider v0.35.0
Or document why v0.34.0 is intentional if there is a compatibility reason for the version mismatch.
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In `@cmd/cloud-controller-manager-aws-tests-ext/go.mod` at line 132, The go.mod
currently pulls k8s.io/cloud-provider v0.34.0 indirectly which conflicts with
other Kubernetes modules pinned at v0.35.0; update the module replacement by
adding a replace directive for k8s.io/cloud-provider to v0.35.0 (i.e., add
"replace k8s.io/cloud-provider => k8s.io/cloud-provider v0.35.0" in go.mod) so
the dependency graph resolves to the same Kubernetes version, or alternatively
add a brief comment in go.mod explaining why v0.34.0 must remain if there is a
compatibility reason.
Comment on lines
+191
to
+193
| if len(os.Getenv("TEST_JUNIT_DIR")) >= 0 { | ||
| testContext.ReportDir = os.Getenv("TEST_JUNIT_DIR") | ||
| } |
There was a problem hiding this comment.
Condition is always true - likely a bug.
The condition len(os.Getenv("TEST_JUNIT_DIR")) >= 0 is always true because string length is never negative. This means testContext.ReportDir will always be set, even when TEST_JUNIT_DIR is empty (resulting in an empty ReportDir).
🐛 Proposed fix
// Output the logs on failure
- if len(os.Getenv("TEST_JUNIT_DIR")) >= 0 {
+ if len(os.Getenv("TEST_JUNIT_DIR")) > 0 {
testContext.ReportDir = os.Getenv("TEST_JUNIT_DIR")
}📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
Suggested change
| if len(os.Getenv("TEST_JUNIT_DIR")) >= 0 { | |
| testContext.ReportDir = os.Getenv("TEST_JUNIT_DIR") | |
| } | |
| if len(os.Getenv("TEST_JUNIT_DIR")) > 0 { | |
| testContext.ReportDir = os.Getenv("TEST_JUNIT_DIR") | |
| } |
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In `@cmd/cloud-controller-manager-aws-tests-ext/main.go` around lines 191 - 193,
The condition currently uses len(os.Getenv("TEST_JUNIT_DIR")) >= 0 which is
always true; change the check to only set testContext.ReportDir when the
environment variable is non-empty (e.g., testDir := os.Getenv("TEST_JUNIT_DIR");
if testDir != "" { testContext.ReportDir = testDir }) so that
testContext.ReportDir is not overwritten with an empty string; update references
to os.Getenv("TEST_JUNIT_DIR") and testContext.ReportDir accordingly.
|
|
||
| ## Prerequisites | ||
|
|
||
| - Go 1.24+ |
There was a problem hiding this comment.
Go version mismatch with go.mod.
The README states "Go 1.24+" but go.mod specifies go 1.25.0. Update the prerequisite to match the actual requirement.
📝 Proposed fix
-- Go 1.24+
+- Go 1.25+📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
Suggested change
| - Go 1.24+ | |
| - Go 1.25+ |
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In `@cmd/cloud-controller-manager-aws-tests-ext/README.md` at line 39, Update the
README entry that currently says "Go 1.24+" to match the module's declared Go
version in go.mod (go 1.25.0); edit the README text so the prerequisite reflects
"Go 1.25.0" or "Go 1.25+" to align with the go directive in go.mod and avoid
version mismatch.
Contributor
Author
|
/testwith openshift/cluster-cloud-controller-manager-operator/main/e2e-aws-ovn openshift/origin#30864 |
Contributor
Author
|
/testwith openshift/cloud-provider-aws/main/e2e-aws-ovn openshift/origin#30864 |
Contributor
|
@mtulio, |
Contributor
Author
|
/test e2e-aws-ovn |
Contributor
Author
|
Fixed wrong statement in .dockerignore /test e2e-aws-ovn |
Contributor
Author
|
/testwith openshift/cluster-cloud-controller-manager-operator/main/e2e-aws-ovn openshift/origin#30864 |
|
@mtulio: This pull request references SPLAT-2672 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.22.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
There was a problem hiding this comment.
Actionable comments posted: 1
♻️ Duplicate comments (1)
cmd/cloud-controller-manager-aws-tests-ext/e2e/loadbalancer.go (1)
300-303:⚠️ Potential issue | 🟡 MinorGrammar issue in log message and error string.
"did not changed" should be "did not change".
📝 Proposed fix
if len(originalSGRules) >= len(currentSGRules) { - framework.Logf("Security group rules count did not changed: original=%d current=%d", + framework.Logf("Security group rules count did not change: original=%d current=%d", len(originalSGRules), len(currentSGRules)) - return nil, fmt.Errorf("security group rules count did not changed") + return nil, fmt.Errorf("security group rules count did not change") }🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@cmd/cloud-controller-manager-aws-tests-ext/e2e/loadbalancer.go` around lines 300 - 303, Fix the grammar in the security group rules message and error: update the framework.Logf call and the returned error string that currently say "did not changed" to "did not change" (the checks around originalSGRules and currentSGRules where the log and fmt.Errorf are used).
🧹 Nitpick comments (5)
Dockerfile (1)
8-12: Clarify why only the test extension binary is gzipped.The test extension binary is gzipped while other binaries (
cluster-controller-manager-operator,config-sync-controllers,azure-config-credentials-injector) are copied directly. This inconsistency may be intentional (e.g., to reduce image size for a large test binary that's not always needed), but it would be helpful to add a comment explaining the rationale.Also note that consumers will need to
gunzipthe binary before use, which should be documented in the README.🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@Dockerfile` around lines 8 - 12, Add a brief comment in the Dockerfile next to the COPY that places cloud-controller-manager-aws-tests-ext.gz explaining why only the test extension binary is gzipped (e.g., large test-only binary kept compressed to reduce image size and because it's optional), and update the README to document that consumers must gunzip /usr/bin/cloud-controller-manager-aws-tests-ext.gz before executing; reference the COPY entry for cloud-controller-manager-aws-tests-ext.gz and the other copied binaries (cluster-controller-manager-operator, config-sync-controllers, azure-config-credentials-injector) so maintainers can see the intentional difference.cmd/cloud-controller-manager-aws-tests-ext/main.go (1)
104-124: Side effect of settingAWS_REGIONshould be documented.The
getRegionFromEnvfunction setsAWS_REGIONas a side effect when reading fromLEASED_RESOURCEorAWS_DEFAULT_REGION. Consider adding a comment to make this intentional behavior explicit, or renaming togetAndSetRegionFromEnvto make the side effect obvious.🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@cmd/cloud-controller-manager-aws-tests-ext/main.go` around lines 104 - 124, getRegionFromEnv currently has the side effect of setting the AWS_REGION env var when it reads from LEASED_RESOURCE or AWS_DEFAULT_REGION; update the code to make this intentional behavior explicit by either adding a clear comment above getRegionFromEnv describing that it will set AWS_REGION as a side effect (mentioning the specific branches that call os.Setenv) or rename the function to getAndSetRegionFromEnv and update all call sites to the new name so the side effect is obvious; ensure any documentation or tests referencing getRegionFromEnv are updated to reflect the documented/renamed behavior.cmd/cloud-controller-manager-aws-tests-ext/e2e/loadbalancer.go (1)
565-576: Error handling assumes any API error means load balancer is deleted.The current logic treats any error from
getAWSLoadBalancerFromDNSNameas success (LB deleted). However, transient errors (network issues, throttling) would incorrectly mark the poll as complete. Consider distinguishing between "not found" errors and other errors.🛡️ Proposed improvement
err = wait.PollUntilContextTimeout(ctx, 5*time.Second, loadBalancerCreateTimeout, true, func(ctx context.Context) (bool, error) { foundLB, err := getAWSLoadBalancerFromDNSName(ctx, elbClient, lbDNS) if err != nil { - // Error finding LB likely means it's deleted - this is success - framework.Logf("Load balancer %s not found (likely deleted): %v", lbDNS, err) - return true, nil + // Only treat "not found" as success; propagate other errors + if strings.Contains(err.Error(), "not found") || strings.Contains(err.Error(), "LoadBalancerNotFound") { + framework.Logf("Load balancer %s not found (deleted): %v", lbDNS, err) + return true, nil + } + framework.Logf("Error querying load balancer %s: %v", lbDNS, err) + return false, nil // Retry on transient errors }🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@cmd/cloud-controller-manager-aws-tests-ext/e2e/loadbalancer.go` around lines 565 - 576, The polling logic treats any error from getAWSLoadBalancerFromDNSName as a successful deletion; change it to distinguish "not found" from other errors by inspecting the returned error (e.g., check AWS error codes or use errors.Is against a sentinel not-found error returned by getAWSLoadBalancerFromDNSName). In the anonymous func passed to wait.PollUntilContextTimeout (the block using elbClient, lbDNS, loadBalancerCreateTimeout), only treat the specific not-found result as success (return true, nil); for transient/other errors log the failure and return false, nil so the poll retries (or return the error only if it should abort permanently). If needed, update getAWSLoadBalancerFromDNSName to return a clear not-found sentinel error to make this check reliable.cmd/cloud-controller-manager-aws-tests-ext/go.mod (1)
138-138:k8s.io/kubectlversion is misaligned with other k8s.io modules.The indirect dependency
k8s.io/kubectl v0.33.0is out of sync with most other Kubernetes modules pinned at v0.35.0. Bothv0.33.0andv0.35.0are stable releases and alignment is possible. Consider adding a replace directive to bring it in line with the rest.Note:
k8s.io/cloud-provider v0.34.0is similarly misaligned.🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@cmd/cloud-controller-manager-aws-tests-ext/go.mod` at line 138, The go.mod lists an indirect dependency k8s.io/kubectl at v0.33.0 which is out of sync with the project’s other Kubernetes modules (mostly v0.35.0); update the module alignment by adding a replace directive that forces k8s.io/kubectl => k8s.io/kubectl v0.35.0 (and likewise add/adjust a replace for k8s.io/cloud-provider to v0.35.0 if present) so all k8s.io modules use the same v0.35.0 version; locate the k8s.io/kubectl entry in go.mod and add the replace directives accordingly.Makefile (1)
51-56: Consider usingcdwith subshell instead ofpushdwithoutpopd.The
pushdcommand changes directory but there's no correspondingpopd. While this works in this specific case, using a subshell withcdis more idiomatic in Makefiles and clearer about intent.Additionally,
LDFLAGSis undefined in the Makefile. Unlike standard Go environment variables (GOOS, GOARCH, GOPROXY), LDFLAGS must be explicitly defined. Currently,-ldflags="$(LDFLAGS)"expands to-ldflags="", which is harmless but indicates incomplete build configuration. Consider defining LDFLAGS explicitly or using hardcoded flags like-ldflags="-s -w"if appropriate for this binary.♻️ Proposed improvement
cloud-controller-manager-aws-tests-ext: - pushd cmd/cloud-controller-manager-aws-tests-ext && \ - GO111MODULE=on CGO_ENABLED=0 GOOS=$(GOOS) GOARCH=$(GOARCH) GOPROXY=$(GOPROXY) go build \ + (cd cmd/cloud-controller-manager-aws-tests-ext && \ + GO111MODULE=on CGO_ENABLED=0 GOOS=$(GOOS) GOARCH=$(GOARCH) GOPROXY=$(GOPROXY) go build \ -trimpath \ - -ldflags="$(LDFLAGS)" \ + -ldflags="-s -w" \ -o=../../bin/cloud-controller-manager-aws-tests-ext .)🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@Makefile` around lines 51 - 56, The cloud-controller-manager-aws-tests-ext Make target uses pushd without popd and passes an undefined LDFLAGS; change the recipe to run the build in a subshell (e.g., use (cd cmd/cloud-controller-manager-aws-tests-ext && GO111MODULE=on CGO_ENABLED=0 GOOS=$(GOOS) GOARCH=$(GOARCH) GOPROXY=$(GOPROXY) go build ... -o ... .)) instead of pushd, and add a default LDFLAGS assignment at top of the Makefile (e.g., define LDFLAGS using LDFLAGS ?= -s -w or an explicit value) so the -ldflags="$(LDFLAGS)" expansion is intentional; update the cloud-controller-manager-aws-tests-ext recipe to reference the LDFLAGS variable as before.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@cmd/cloud-controller-manager-aws-tests-ext/e2e/loadbalancer.go`:
- Line 80: Fix the typo in the test description string passed to It — add the
missing closing single-quote so the message reads "should have
NLBSecurityGroupMode with 'Managed' value in cloud-config"; locate the It(...)
call where the description currently is "should have NLBSecurityGroupMode with
'Managed value in cloud-config" and update that string accordingly.
---
Duplicate comments:
In `@cmd/cloud-controller-manager-aws-tests-ext/e2e/loadbalancer.go`:
- Around line 300-303: Fix the grammar in the security group rules message and
error: update the framework.Logf call and the returned error string that
currently say "did not changed" to "did not change" (the checks around
originalSGRules and currentSGRules where the log and fmt.Errorf are used).
---
Nitpick comments:
In `@cmd/cloud-controller-manager-aws-tests-ext/e2e/loadbalancer.go`:
- Around line 565-576: The polling logic treats any error from
getAWSLoadBalancerFromDNSName as a successful deletion; change it to distinguish
"not found" from other errors by inspecting the returned error (e.g., check AWS
error codes or use errors.Is against a sentinel not-found error returned by
getAWSLoadBalancerFromDNSName). In the anonymous func passed to
wait.PollUntilContextTimeout (the block using elbClient, lbDNS,
loadBalancerCreateTimeout), only treat the specific not-found result as success
(return true, nil); for transient/other errors log the failure and return false,
nil so the poll retries (or return the error only if it should abort
permanently). If needed, update getAWSLoadBalancerFromDNSName to return a clear
not-found sentinel error to make this check reliable.
In `@cmd/cloud-controller-manager-aws-tests-ext/go.mod`:
- Line 138: The go.mod lists an indirect dependency k8s.io/kubectl at v0.33.0
which is out of sync with the project’s other Kubernetes modules (mostly
v0.35.0); update the module alignment by adding a replace directive that forces
k8s.io/kubectl => k8s.io/kubectl v0.35.0 (and likewise add/adjust a replace for
k8s.io/cloud-provider to v0.35.0 if present) so all k8s.io modules use the same
v0.35.0 version; locate the k8s.io/kubectl entry in go.mod and add the replace
directives accordingly.
In `@cmd/cloud-controller-manager-aws-tests-ext/main.go`:
- Around line 104-124: getRegionFromEnv currently has the side effect of setting
the AWS_REGION env var when it reads from LEASED_RESOURCE or AWS_DEFAULT_REGION;
update the code to make this intentional behavior explicit by either adding a
clear comment above getRegionFromEnv describing that it will set AWS_REGION as a
side effect (mentioning the specific branches that call os.Setenv) or rename the
function to getAndSetRegionFromEnv and update all call sites to the new name so
the side effect is obvious; ensure any documentation or tests referencing
getRegionFromEnv are updated to reflect the documented/renamed behavior.
In `@Dockerfile`:
- Around line 8-12: Add a brief comment in the Dockerfile next to the COPY that
places cloud-controller-manager-aws-tests-ext.gz explaining why only the test
extension binary is gzipped (e.g., large test-only binary kept compressed to
reduce image size and because it's optional), and update the README to document
that consumers must gunzip /usr/bin/cloud-controller-manager-aws-tests-ext.gz
before executing; reference the COPY entry for
cloud-controller-manager-aws-tests-ext.gz and the other copied binaries
(cluster-controller-manager-operator, config-sync-controllers,
azure-config-credentials-injector) so maintainers can see the intentional
difference.
In `@Makefile`:
- Around line 51-56: The cloud-controller-manager-aws-tests-ext Make target uses
pushd without popd and passes an undefined LDFLAGS; change the recipe to run the
build in a subshell (e.g., use (cd cmd/cloud-controller-manager-aws-tests-ext &&
GO111MODULE=on CGO_ENABLED=0 GOOS=$(GOOS) GOARCH=$(GOARCH) GOPROXY=$(GOPROXY) go
build ... -o ... .)) instead of pushd, and add a default LDFLAGS assignment at
top of the Makefile (e.g., define LDFLAGS using LDFLAGS ?= -s -w or an explicit
value) so the -ldflags="$(LDFLAGS)" expansion is intentional; update the
cloud-controller-manager-aws-tests-ext recipe to reference the LDFLAGS variable
as before.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository: openshift/coderabbit/.coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: 12e50d26-0815-44fc-abda-503961d9f9d7
⛔ Files ignored due to path filters (1)
cmd/cloud-controller-manager-aws-tests-ext/go.sumis excluded by!**/*.sum
📒 Files selected for processing (8)
.dockerignoreDockerfileMakefilecmd/cloud-controller-manager-aws-tests-ext/README.mdcmd/cloud-controller-manager-aws-tests-ext/e2e/helper.gocmd/cloud-controller-manager-aws-tests-ext/e2e/loadbalancer.gocmd/cloud-controller-manager-aws-tests-ext/go.modcmd/cloud-controller-manager-aws-tests-ext/main.go
🚧 Files skipped from review as they are similar to previous changes (2)
- cmd/cloud-controller-manager-aws-tests-ext/e2e/helper.go
- .dockerignore
| // - Configuration includes: NLBSecurityGroupMode set to 'Managed' | ||
| // - The test must fail if the feature gate is enabled and the configuration does not include NLBSecurityGroupMode set to 'Managed' | ||
| // - The test must skip if the feature gate is not enabled | ||
| It("should have NLBSecurityGroupMode with 'Managed value in cloud-config", func(ctx context.Context) { |
There was a problem hiding this comment.
Minor typo in test description.
There's a missing closing quote in the test description: 'Managed value should be 'Managed' value.
📝 Proposed fix
- It("should have NLBSecurityGroupMode with 'Managed value in cloud-config", func(ctx context.Context) {
+ It("should have NLBSecurityGroupMode with 'Managed' value in cloud-config", func(ctx context.Context) {📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
Suggested change
| It("should have NLBSecurityGroupMode with 'Managed value in cloud-config", func(ctx context.Context) { | |
| It("should have NLBSecurityGroupMode with 'Managed' value in cloud-config", func(ctx context.Context) { |
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In `@cmd/cloud-controller-manager-aws-tests-ext/e2e/loadbalancer.go` at line 80,
Fix the typo in the test description string passed to It — add the missing
closing single-quote so the message reads "should have NLBSecurityGroupMode with
'Managed' value in cloud-config"; locate the It(...) call where the description
currently is "should have NLBSecurityGroupMode with 'Managed value in
cloud-config" and update that string accordingly.
Contributor
Author
|
/testwith openshift/cluster-cloud-controller-manager-operator/main/e2e-aws-ovn openshift/origin#30864,openshift/cloud-provider-aws#133 |
Contributor
Author
|
/testwith openshift/cluster-cloud-controller-manager-operator/main/e2e-aws-ovn openshift/origin#30864 openshift/cloud-provider-aws#133 |
|
@mtulio: This pull request references SPLAT-2672 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.22.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
Contributor
Author
|
I've found two issues in my last attempt:
/testwith openshift/cluster-cloud-controller-manager-operator/main/e2e-aws-ovn openshift/origin#30864 openshift/cloud-provider-aws#133 |
|
@mtulio: This pull request references SPLAT-2672 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.22.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
There was a problem hiding this comment.
Actionable comments posted: 2
♻️ Duplicate comments (5)
cmd/cloud-controller-manager-aws-tests-ext/main.go (1)
191-193:⚠️ Potential issue | 🟠 MajorFix always-true
TEST_JUNIT_DIRcondition.
len(os.Getenv("TEST_JUNIT_DIR")) >= 0is always true, soReportDiris set even when empty.Proposed fix
- if len(os.Getenv("TEST_JUNIT_DIR")) >= 0 { - testContext.ReportDir = os.Getenv("TEST_JUNIT_DIR") + if testDir := strings.TrimSpace(os.Getenv("TEST_JUNIT_DIR")); testDir != "" { + testContext.ReportDir = testDir }🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@cmd/cloud-controller-manager-aws-tests-ext/main.go` around lines 191 - 193, The condition checking TEST_JUNIT_DIR is always true (len(...) >= 0) so testContext.ReportDir gets set even when empty; change the check to only set testContext.ReportDir when the env var is non-empty (e.g., use len(os.Getenv("TEST_JUNIT_DIR")) > 0 or os.Getenv("TEST_JUNIT_DIR") != "") so testContext.ReportDir is assigned only when a real path is provided.cmd/cloud-controller-manager-aws-tests-ext/e2e/loadbalancer.go (4)
202-213:⚠️ Potential issue | 🔴 CriticalGuard
lbbefore dereferencinglb.Statein the poll callback.When the lookup returns
lb == nil, the log at Line 212 panics instead of retrying.Proposed fix
if lb != nil && lb.State != nil && lb.State.Code == elbv2types.LoadBalancerStateEnumActive { foundLB = lb return true, nil } - framework.Logf("Load balancer not yet active, current state: %v", lb.State) + if lb == nil { + framework.Logf("Load balancer %s not returned yet", lbDNS) + return false, nil + } + framework.Logf("Load balancer not yet active, current state: %v", lb.State) return false, nil🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@cmd/cloud-controller-manager-aws-tests-ext/e2e/loadbalancer.go` around lines 202 - 213, The poll callback dereferences lb.State without guarding lb, which can panic when getAWSLoadBalancerFromDNSName returns nil; update the function passed to wait.PollUntilContextTimeout so it first checks if lb == nil and logs/returns retry (e.g., "load balancer not found") before accessing lb.State, and then check lb.State != nil before inspecting lb.State.Code; reference the poll callback used with wait.PollUntilContextTimeout and the getAWSLoadBalancerFromDNSName result (lb) and set foundLB only after confirming lb and lb.State are non-nil and state is Active.
292-299:⚠️ Potential issue | 🔴 CriticalKeep the
Eventuallycallback retry-safe (no hard assertions, no nil-unsafe log).
framework.ExpectNoErroraborts retries, and Line 293 dereferencesfoundLB.SecurityGroupswhenfoundLBis nil.Proposed fix
- if foundLB == nil || len(foundLB.SecurityGroups) == 0 { - framework.Logf("Load balancer has no security groups attached, expected=%d", len(foundLB.SecurityGroups)) + if foundLB == nil { + framework.Logf("Load balancer not found yet") + return nil, fmt.Errorf("load balancer not found yet") + } + if len(foundLB.SecurityGroups) == 0 { + framework.Logf("Load balancer has no security groups attached") return nil, fmt.Errorf("load balancer has no security groups attached") } @@ - currentSGRules, err := getAWSSecurityGroupRules(ctx, ec2Client, foundLB.SecurityGroups) - framework.ExpectNoError(err, "failed to get security group rules to calculate the diff") + currentSGRules, err := getAWSSecurityGroupRules(ctx, ec2Client, foundLB.SecurityGroups) + if err != nil { + framework.Logf("failed to get security group rules: %v", err) + return nil, err + }🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@cmd/cloud-controller-manager-aws-tests-ext/e2e/loadbalancer.go` around lines 292 - 299, The Eventually callback must be retry-safe: stop using framework.ExpectNoError inside the callback and avoid dereferencing foundLB when it can be nil. Replace the framework.ExpectNoError call with error propagation (return nil, err) so the Eventually loop can retry, and move the nil check before accessing foundLB.SecurityGroups (check foundLB == nil and return a retryable error). Ensure getAWSSecurityGroupRules is only called when foundLB != nil and foundLB.SecurityGroups is non-empty, and surface any errors from getAWSSecurityGroupRules back to the caller instead of calling ExpectNoError.
565-570:⚠️ Potential issue | 🟠 MajorDo not treat every ELB lookup error as successful deletion.
This can mark deletion successful on throttling/auth/transient failures and hide leaked load balancers.
Proposed fix
err = wait.PollUntilContextTimeout(ctx, 5*time.Second, loadBalancerCreateTimeout, true, func(ctx context.Context) (bool, error) { foundLB, err := getAWSLoadBalancerFromDNSName(ctx, elbClient, lbDNS) if err != nil { - // Error finding LB likely means it's deleted - this is success - framework.Logf("Load balancer %s not found (likely deleted): %v", lbDNS, err) - return true, nil + // Only "not found" should be considered success; retry on transient errors. + if isELBNotFoundError(err) { + framework.Logf("Load balancer %s not found (deleted)", lbDNS) + return true, nil + } + framework.Logf("Error while checking load balancer %s deletion: %v", lbDNS, err) + return false, err }🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@cmd/cloud-controller-manager-aws-tests-ext/e2e/loadbalancer.go` around lines 565 - 570, The current deletion loop treats any error from getAWSLoadBalancerFromDNSName as successful deletion; instead, only treat a definitive "not found" error as success and surface other errors so the poller can retry or fail. In the wait.PollUntilContextTimeout callback where getAWSLoadBalancerFromDNSName(ctx, elbClient, lbDNS) is called, check the returned error: if it indicates the ELB is missing (e.g., AWS "LoadBalancerNotFound" / not-found sentinel from the AWS SDK or specific error string/code returned by getAWSLoadBalancerFromDNSName) then log and return true, nil; otherwise log the transient/auth/throttling error and return false, err so the poller retries or ultimately fails. Ensure you reference getAWSLoadBalancerFromDNSName and the anonymous poll function around lbDNS/el bClient when making this change.
119-141:⚠️ Potential issue | 🟠 MajorRegister cleanup immediately after provisioning to prevent leaked NLB/SG resources on early failures.
This test only deletes at the tail; any failure before Line 140 can leak service-owned AWS resources.
Proposed fix pattern
lbDNS := svc.Status.LoadBalancer.Ingress[0].Hostname + DeferCleanup(func(ctx context.Context) { + err := deleteServiceAndWaitForLoadBalancerDeletion(ctx, jig, lbDNS) + framework.ExpectNoError(err, "failed to delete service and wait for load balancer deletion") + }) framework.Logf("Load balancer DNS: %s", lbDNS) - - err = deleteServiceAndWaitForLoadBalancerDeletion(ctx, jig, lbDNS) - framework.ExpectNoError(err, "failed to delete service and wait for load balancer deletion")🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@cmd/cloud-controller-manager-aws-tests-ext/e2e/loadbalancer.go` around lines 119 - 141, After calling createServiceNLB (svc, jig, err...), immediately register a cleanup action so resources are removed on early failures: use framework.AddCleanupAction (or the test's DeferCleanup helper) to add a closure that will delete the service and wait for LB deletion by invoking deleteServiceAndWaitForLoadBalancerDeletion with jig and the current LB hostname if available; if svc.Status.LoadBalancer.Ingress is empty in the cleanup closure, fall back to deleting the Service object via jig.DeleteService (or equivalent) to ensure no NLB/SG is leaked. Ensure this registration happens right after createServiceNLB and before any subsequent Expect/validation.
🧹 Nitpick comments (1)
Makefile (1)
40-40: Declarebuild(and the new binary target) as.PHONYto avoid target/file collisions.If a file or directory named
buildorcloud-controller-manager-aws-tests-extexists,makecan incorrectly skip the recipe.Proposed fix
+.PHONY: build cloud-controller-manager-aws-tests-ext build: operator config-sync-controllers azure-config-credentials-injector cloud-controller-manager-aws-tests-ext🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@Makefile` at line 40, Add a .PHONY declaration for the Makefile targets so make won't treat real files as up-to-date; specifically add a .PHONY line that includes build and the new binary target cloud-controller-manager-aws-tests-ext (and any other non-file targets like operator, config-sync-controllers, azure-config-credentials-injector if desired) so the build recipe always runs regardless of existing files with those names.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@cmd/cloud-controller-manager-aws-tests-ext/e2e/helper.go`:
- Around line 187-195: The ec2IsNotFoundError helper incorrectly treats
"InvalidGroup.Malformed" as a not-found case; change it to use typed AWS SDK v2
error handling by casting the error to smithy.APIError via errors.As and inspect
apiErr.ErrorCode(), returning true only for "InvalidGroup.NotFound" and
"InvalidGroupId.NotFound" and false otherwise (do not treat
"InvalidGroup.Malformed" as not-found so callers like securityGroupExists() can
surface it as an input error). Ensure the function still returns false for nil
errors and returns false for non-API errors.
In `@cmd/cloud-controller-manager-aws-tests-ext/main.go`:
- Around line 167-170: The code in initFrameworkForTests currently panics on
clientConfig.ClientConfig() failures; change it to return the error instead of
calling panic so callers can handle it. Replace the panic(fmt.Errorf(...)) with
a wrapped error return (e.g., return nil, fmt.Errorf("failed to get client
config: %w", err)) and propagate that error out of initFrameworkForTests,
ensuring any callers handle the returned error from initFrameworkForTests
accordingly; reference the variables/functions cfg and
clientConfig.ClientConfig() when locating the change.
---
Duplicate comments:
In `@cmd/cloud-controller-manager-aws-tests-ext/e2e/loadbalancer.go`:
- Around line 202-213: The poll callback dereferences lb.State without guarding
lb, which can panic when getAWSLoadBalancerFromDNSName returns nil; update the
function passed to wait.PollUntilContextTimeout so it first checks if lb == nil
and logs/returns retry (e.g., "load balancer not found") before accessing
lb.State, and then check lb.State != nil before inspecting lb.State.Code;
reference the poll callback used with wait.PollUntilContextTimeout and the
getAWSLoadBalancerFromDNSName result (lb) and set foundLB only after confirming
lb and lb.State are non-nil and state is Active.
- Around line 292-299: The Eventually callback must be retry-safe: stop using
framework.ExpectNoError inside the callback and avoid dereferencing foundLB when
it can be nil. Replace the framework.ExpectNoError call with error propagation
(return nil, err) so the Eventually loop can retry, and move the nil check
before accessing foundLB.SecurityGroups (check foundLB == nil and return a
retryable error). Ensure getAWSSecurityGroupRules is only called when foundLB !=
nil and foundLB.SecurityGroups is non-empty, and surface any errors from
getAWSSecurityGroupRules back to the caller instead of calling ExpectNoError.
- Around line 565-570: The current deletion loop treats any error from
getAWSLoadBalancerFromDNSName as successful deletion; instead, only treat a
definitive "not found" error as success and surface other errors so the poller
can retry or fail. In the wait.PollUntilContextTimeout callback where
getAWSLoadBalancerFromDNSName(ctx, elbClient, lbDNS) is called, check the
returned error: if it indicates the ELB is missing (e.g., AWS
"LoadBalancerNotFound" / not-found sentinel from the AWS SDK or specific error
string/code returned by getAWSLoadBalancerFromDNSName) then log and return true,
nil; otherwise log the transient/auth/throttling error and return false, err so
the poller retries or ultimately fails. Ensure you reference
getAWSLoadBalancerFromDNSName and the anonymous poll function around lbDNS/el
bClient when making this change.
- Around line 119-141: After calling createServiceNLB (svc, jig, err...),
immediately register a cleanup action so resources are removed on early
failures: use framework.AddCleanupAction (or the test's DeferCleanup helper) to
add a closure that will delete the service and wait for LB deletion by invoking
deleteServiceAndWaitForLoadBalancerDeletion with jig and the current LB hostname
if available; if svc.Status.LoadBalancer.Ingress is empty in the cleanup
closure, fall back to deleting the Service object via jig.DeleteService (or
equivalent) to ensure no NLB/SG is leaked. Ensure this registration happens
right after createServiceNLB and before any subsequent Expect/validation.
In `@cmd/cloud-controller-manager-aws-tests-ext/main.go`:
- Around line 191-193: The condition checking TEST_JUNIT_DIR is always true
(len(...) >= 0) so testContext.ReportDir gets set even when empty; change the
check to only set testContext.ReportDir when the env var is non-empty (e.g., use
len(os.Getenv("TEST_JUNIT_DIR")) > 0 or os.Getenv("TEST_JUNIT_DIR") != "") so
testContext.ReportDir is assigned only when a real path is provided.
---
Nitpick comments:
In `@Makefile`:
- Line 40: Add a .PHONY declaration for the Makefile targets so make won't treat
real files as up-to-date; specifically add a .PHONY line that includes build and
the new binary target cloud-controller-manager-aws-tests-ext (and any other
non-file targets like operator, config-sync-controllers,
azure-config-credentials-injector if desired) so the build recipe always runs
regardless of existing files with those names.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: f36708f0-8412-414b-b4ae-a9f71b70443b
⛔ Files ignored due to path filters (1)
cmd/cloud-controller-manager-aws-tests-ext/go.sumis excluded by!**/*.sum
📒 Files selected for processing (7)
.dockerignoreDockerfileMakefilecmd/cloud-controller-manager-aws-tests-ext/e2e/helper.gocmd/cloud-controller-manager-aws-tests-ext/e2e/loadbalancer.gocmd/cloud-controller-manager-aws-tests-ext/go.modcmd/cloud-controller-manager-aws-tests-ext/main.go
🚧 Files skipped from review as they are similar to previous changes (2)
- Dockerfile
- cmd/cloud-controller-manager-aws-tests-ext/go.mod
Comment on lines
+187
to
+195
| func ec2IsNotFoundError(err error) bool { | ||
| if err == nil { | ||
| return false | ||
| } | ||
| // Check for common EC2 not found error messages | ||
| errMsg := err.Error() | ||
| return strings.Contains(errMsg, "InvalidGroup.NotFound") || | ||
| strings.Contains(errMsg, "InvalidGroupId.NotFound") || | ||
| strings.Contains(errMsg, "InvalidGroup.Malformed") |
There was a problem hiding this comment.
🧩 Analysis chain
🏁 Script executed:
head -200 cmd/cloud-controller-manager-aws-tests-ext/e2e/helper.go | tail -50Repository: openshift/cluster-cloud-controller-manager-operator
Length of output: 1737
🏁 Script executed:
# First, let's see the exact function and surrounding context
sed -n '180,200p' cmd/cloud-controller-manager-aws-tests-ext/e2e/helper.goRepository: openshift/cluster-cloud-controller-manager-operator
Length of output: 562
🏁 Script executed:
# Also check the imports at the top of the file
head -50 cmd/cloud-controller-manager-aws-tests-ext/e2e/helper.goRepository: openshift/cluster-cloud-controller-manager-operator
Length of output: 2027
🏁 Script executed:
# Check if smithy-go is in the project dependencies
grep -r "smithy-go" . --include="*.go" --include="go.mod" | head -20Repository: openshift/cluster-cloud-controller-manager-operator
Length of output: 3526
🏁 Script executed:
# Search for other error handling patterns in the codebase
rg "errors\.As" --type go | head -20Repository: openshift/cluster-cloud-controller-manager-operator
Length of output: 2473
🏁 Script executed:
# Look for AWS error handling examples in the codebase
rg "ErrorCode()" --type go | head -20Repository: openshift/cluster-cloud-controller-manager-operator
Length of output: 2770
🌐 Web query:
AWS SDK v2 Go error handling InvalidGroup.NotFound InvalidGroup.Malformed smithy APIError
💡 Result:
In AWS SDK for Go v2, EC2 service errors like InvalidGroup.NotFound / InvalidGroup.Malformed are typically surfaced as an error chain (often wrapped in *smithy.OperationError). The most robust way to handle them is to unwrap with errors.As and inspect the Smithy APIError interface (code/message/fault). (docs.aws.amazon.com)
import (
"errors"
"fmt"
"github.com/aws/smithy-go"
)
func isInvalidGroup(err error) (code string, ok bool) {
var apiErr smithy.APIError
if errors.As(err, &apiErr) {
switch apiErr.ErrorCode() { // e.g. "InvalidGroup.NotFound", "InvalidGroup.Malformed"
case "InvalidGroup.NotFound", "InvalidGroup.Malformed":
return apiErr.ErrorCode(), true
}
}
return "", false
}
func example(err error) {
if code, ok := isInvalidGroup(err); ok {
// handle specifically (wrong SG id format, wrong region/VPC, deleted SG, eventual consistency, etc.)
fmt.Println("security group error:", code)
return
}
// generic handling
fmt.Println("other error:", err)
}Notes:
smithy.APIErroris the generic interface implemented by SDK service/protocol errors and exposesErrorCode()/ErrorMessage()(andErrorFault()). (pkg.go.dev)InvalidGroup.NotFound/InvalidGroup.Malformedare EC2 API error codes you should compare as strings (they’re documented by EC2; they aren’t always generated as dedicated Go exception types for the Query protocol). (docs.aws.amazon.com)
Citations:
- 1: https://docs.aws.amazon.com/sdk-for-go/v2/developer-guide/handle-errors.html?utm_source=openai
- 2: https://pkg.go.dev/github.com/aws/smithy-go?utm_source=openai
- 3: https://docs.aws.amazon.com/AWSEC2/latest/APIReference/errors-overview.html?utm_source=openai
Use typed AWS SDK v2 error handling instead of string matching; InvalidGroup.Malformed indicates bad input, not a deleted resource.
The current implementation treats InvalidGroup.Malformed as equivalent to "not found", which is semantically incorrect. Malformed IDs represent input validation failures, not resource deletions. This causes securityGroupExists() to return (false, nil) for invalid IDs, masking input errors and producing false-positive cleanup checks.
Use smithy.APIError with errors.As() to properly handle AWS SDK v2 errors and only check for actual "not found" codes:
Proposed fix
import (
"context"
+ "errors"
"fmt"
"strings"
@@
ec2types "github.com/aws/aws-sdk-go-v2/service/ec2/types"
elbv2 "github.com/aws/aws-sdk-go-v2/service/elasticloadbalancingv2"
elbv2types "github.com/aws/aws-sdk-go-v2/service/elasticloadbalancingv2/types"
+ "github.com/aws/smithy-go"
@@
func ec2IsNotFoundError(err error) bool {
if err == nil {
return false
}
- // Check for common EC2 not found error messages
- errMsg := err.Error()
- return strings.Contains(errMsg, "InvalidGroup.NotFound") ||
- strings.Contains(errMsg, "InvalidGroupId.NotFound") ||
- strings.Contains(errMsg, "InvalidGroup.Malformed")
+ var apiErr smithy.APIError
+ if errors.As(err, &apiErr) {
+ code := apiErr.ErrorCode()
+ return code == "InvalidGroup.NotFound" || code == "InvalidGroupId.NotFound"
+ }
+ return false
}📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
Suggested change
| func ec2IsNotFoundError(err error) bool { | |
| if err == nil { | |
| return false | |
| } | |
| // Check for common EC2 not found error messages | |
| errMsg := err.Error() | |
| return strings.Contains(errMsg, "InvalidGroup.NotFound") || | |
| strings.Contains(errMsg, "InvalidGroupId.NotFound") || | |
| strings.Contains(errMsg, "InvalidGroup.Malformed") | |
| func ec2IsNotFoundError(err error) bool { | |
| if err == nil { | |
| return false | |
| } | |
| var apiErr smithy.APIError | |
| if errors.As(err, &apiErr) { | |
| code := apiErr.ErrorCode() | |
| return code == "InvalidGroup.NotFound" || code == "InvalidGroupId.NotFound" | |
| } | |
| return false | |
| } |
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In `@cmd/cloud-controller-manager-aws-tests-ext/e2e/helper.go` around lines 187 -
195, The ec2IsNotFoundError helper incorrectly treats "InvalidGroup.Malformed"
as a not-found case; change it to use typed AWS SDK v2 error handling by casting
the error to smithy.APIError via errors.As and inspect apiErr.ErrorCode(),
returning true only for "InvalidGroup.NotFound" and "InvalidGroupId.NotFound"
and false otherwise (do not treat "InvalidGroup.Malformed" as not-found so
callers like securityGroupExists() can surface it as an input error). Ensure the
function still returns false for nil errors and returns false for non-API
errors.
Comment on lines
+167
to
+170
| cfg, err := clientConfig.ClientConfig() | ||
| if err != nil { | ||
| panic(fmt.Errorf("failed to get client config: %w", err)) | ||
| } |
There was a problem hiding this comment.
Return config-loading failures instead of panicking inside initFrameworkForTests.
This function already returns error; panic here bypasses caller handling and hard-exits.
Proposed fix
cfg, err := clientConfig.ClientConfig()
if err != nil {
- panic(fmt.Errorf("failed to get client config: %w", err))
+ return fmt.Errorf("failed to get client config: %w", err)
}📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
Suggested change
| cfg, err := clientConfig.ClientConfig() | |
| if err != nil { | |
| panic(fmt.Errorf("failed to get client config: %w", err)) | |
| } | |
| cfg, err := clientConfig.ClientConfig() | |
| if err != nil { | |
| return fmt.Errorf("failed to get client config: %w", err) | |
| } |
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In `@cmd/cloud-controller-manager-aws-tests-ext/main.go` around lines 167 - 170,
The code in initFrameworkForTests currently panics on
clientConfig.ClientConfig() failures; change it to return the error instead of
calling panic so callers can handle it. Replace the panic(fmt.Errorf(...)) with
a wrapped error return (e.g., return nil, fmt.Errorf("failed to get client
config: %w", err)) and propagate that error out of initFrameworkForTests,
ensuring any callers handle the returned error from initFrameworkForTests
accordingly; reference the variables/functions cfg and
clientConfig.ClientConfig() when locating the change.
Contributor
|
/lgtm |
Contributor
Author
|
/testwith openshift/cluster-cloud-controller-manager-operator/main/e2e-aws-ovn openshift/origin#30864 |
Contributor
Author
|
/testwith openshift/cluster-cloud-controller-manager-operator/main/e2e-aws-ovn-techpreview openshift/origin#30864 |
Contributor
Author
|
The following jobs have expected tests provided by OTE (prefix
|
Contributor
Author
|
/verified by CI tests passing #437 (comment) |
openshift-ci-robot
added
the
verified
|
@mtulio: This PR has been marked as verified by DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
Contributor
Author
|
/assign @elmiko @miyadav @sunzhaohua2 |
Contributor
|
@mtulio: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
elmiko
reviewed
Mar 17, 2026
Contributor
elmiko
left a comment
elmiko
left a comment
There was a problem hiding this comment.
i think this looks pretty solid to me, i just have a couple nits/questions.
sunzhaohua2
reviewed
Mar 18, 2026
| ext := e.NewExtension("openshift", "payload", "aws-cloud-controller-manager") | ||
|
|
||
| ext.AddSuite(e.Suite{ | ||
| Name: "ccm/aws/conformance/parallel", |
Contributor
There was a problem hiding this comment.
Here add Parents more better? and delete line 73
Parents: []string{
"openshift/conformance/parallel",
},
Member
There was a problem hiding this comment.
it was done same way earlier in ccm aws repo , hence I guess , following same pattern.
Contributor
Author
There was a problem hiding this comment.
it was done same way earlier in ccm aws repo , hence I guess , following same pattern.
Correct, this is unchanged from CCM AWS files, just moving files to here.
Although, if this won't affect regular flow, as well achieve the same goal which is falling those tests into the standard suite "openshift/conformance/parallel", looks good to me. Now I can't see benefits of having a custom suite, as I thought when developed that.
Can you all see that we need a custom (leave it as it) or change it to default conformance suite (Parent to "openshift/conformance/parallel") ?
I just need to validate if setting Parent won't inherit all parent's tests - which I have a vague memory that it was happening, and we don't expect that.
Added openshift-specific tests for upstream project CCM-AWS exposed through OTE interface/binary;
Creating development document to build and use the OTE binary for CCM-AWS project.
Adjust the build image for CCCMO project to pack the OTE binary into the image - which is available in payload, required by OTE extractor (openshift-tests utility). The image is compressed, the decompression is done by client side when extracting it. PR adding the extraction: openshift/origin#30864
Added OTE (OpenShift Tests Extension) module to create the binary used to test CCM-AWS project. The module is self-contained from CCCMO repository, and the binary is built and added to the project's image: cluster-cloud-controller-manager-operator.
openshift-ci-robot
removed
the
verified
Contributor
|
New changes are detected. LGTM label has been removed. |
There was a problem hiding this comment.
♻️ Duplicate comments (8)
cmd/cloud-controller-manager-aws-tests-ext/main.go (2)
167-170:⚠️ Potential issue | 🟠 MajorReturn config-loading failures instead of panicking in
initFrameworkForTests.Line 169 bypasses the function’s error contract and hard-exits setup.
Proposed fix
cfg, err := clientConfig.ClientConfig() if err != nil { - panic(fmt.Errorf("failed to get client config: %w", err)) + return fmt.Errorf("failed to get client config: %w", err) }🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@cmd/cloud-controller-manager-aws-tests-ext/main.go` around lines 167 - 170, The initFrameworkForTests function currently panics on client config load failure by calling clientConfig.ClientConfig() and using panic(fmt.Errorf(...)), which violates its error-return contract; change this to return the error instead of panicking: replace the panic branch so initFrameworkForTests returns the wrapped error (e.g., fmt.Errorf("failed to get client config: %w", err)) up the call chain, and adjust callers to handle the returned error if necessary; locate the clientConfig.ClientConfig() call and the cfg variable in initFrameworkForTests and propagate the error rather than exiting the process.
191-193:⚠️ Potential issue | 🟠 MajorFix the always-true
TEST_JUNIT_DIRguard.Line 191 is always true, so
ReportDirgets overwritten even whenTEST_JUNIT_DIRis empty.Proposed fix
-// Output the logs on failure -if len(os.Getenv("TEST_JUNIT_DIR")) >= 0 { - testContext.ReportDir = os.Getenv("TEST_JUNIT_DIR") +// Output logs on failure when junit dir is explicitly set. +if testDir := strings.TrimSpace(os.Getenv("TEST_JUNIT_DIR")); testDir != "" { + testContext.ReportDir = testDir }🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@cmd/cloud-controller-manager-aws-tests-ext/main.go` around lines 191 - 193, The guard currently uses len(os.Getenv("TEST_JUNIT_DIR")) >= 0 which is always true, causing testContext.ReportDir to be set even when the env var is empty; change the check to verify the env var is non-empty (for example retrieve the value into a variable via os.Getenv("TEST_JUNIT_DIR") and use v != "" or len(v) > 0) and only assign testContext.ReportDir = v when that condition passes.cmd/cloud-controller-manager-aws-tests-ext/e2e/loadbalancer.go (6)
565-570:⚠️ Potential issue | 🟠 MajorDo not treat all AWS lookup errors as successful deletion.
Lines 567-570 currently mark deletion as success for any error (including auth/throttle/network errors), which can hide leaked load balancers.
Proposed fix
+import ( + "errors" + ... +) err = wait.PollUntilContextTimeout(ctx, 5*time.Second, loadBalancerCreateTimeout, true, func(ctx context.Context) (bool, error) { foundLB, err := getAWSLoadBalancerFromDNSName(ctx, elbClient, lbDNS) if err != nil { - // Error finding LB likely means it's deleted - this is success - framework.Logf("Load balancer %s not found (likely deleted): %v", lbDNS, err) - return true, nil + var notFound *elbv2types.LoadBalancerNotFoundException + if errors.As(err, ¬Found) { + framework.Logf("Load balancer %s has been deleted", lbDNS) + return true, nil + } + framework.Logf("Error querying load balancer %s during deletion wait: %v", lbDNS, err) + return false, nil }🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@cmd/cloud-controller-manager-aws-tests-ext/e2e/loadbalancer.go` around lines 565 - 570, The current polling callback in wait.PollUntilContextTimeout treats any error from getAWSLoadBalancerFromDNSName as a successful deletion; instead, update the callback to only return success when the LB is actually not found (e.g., error indicates "not found" or getAWSLoadBalancerFromDNSName returns nil/false), and for other errors (auth, throttle, network) return false with the error so the poll will retry; reference the wait.PollUntilContextTimeout callback, getAWSLoadBalancerFromDNSName, elbClient, and lbDNS and implement explicit error inspection (AWS error code or sentinel not-found condition) to differentiate deletion from transient/permission errors.
292-294:⚠️ Potential issue | 🔴 CriticalAvoid nil dereference in the
foundLBsecurity-group check.Line 293 calls
len(foundLB.SecurityGroups)even whenfoundLB == nil.Proposed fix
-if foundLB == nil || len(foundLB.SecurityGroups) == 0 { - framework.Logf("Load balancer has no security groups attached, expected=%d", len(foundLB.SecurityGroups)) +if foundLB == nil { + framework.Logf("Load balancer not found yet") + return nil, fmt.Errorf("load balancer not found yet") +} +if len(foundLB.SecurityGroups) == 0 { + framework.Logf("Load balancer has no security groups attached") return nil, fmt.Errorf("load balancer has no security groups attached") }🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@cmd/cloud-controller-manager-aws-tests-ext/e2e/loadbalancer.go` around lines 292 - 294, The check dereferences foundLB when computing len(foundLB.SecurityGroups), risking a nil panic; change the logic to first test if foundLB == nil and handle that case (log and return an error) before accessing foundLB.SecurityGroups, and when logging the security-group count use a safe value (e.g., 0) or conditional access; update the block around the foundLB check (variable foundLB and its SecurityGroups) so the nil-case is handled separately from the empty-security-groups case.
467-476:⚠️ Potential issue | 🟠 MajorCheck required ports by presence, not exact multiset equality.
Line 476 with
ConsistOffails when SG rules include duplicates or additional managed ports, even if 80/443 are present.Proposed fix
-Expect(expectedPorts).To(ConsistOf([]int32{80, 443}), "security groups should have rules for both ports 80 and 443") +Expect(expectedPorts).To(ContainElements(int32(80), int32(443)), + "security groups should include rules for ports 80 and 443")🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@cmd/cloud-controller-manager-aws-tests-ext/e2e/loadbalancer.go` around lines 467 - 476, The test currently builds expectedPorts from currentSGRules and asserts exact multiset equality using Expect(expectedPorts).To(ConsistOf(...)), which fails if there are duplicates or extra ports; change the assertion to only require presence of ports 80 and 443 (e.g. use Gomega's ContainElements or two ContainElement checks) so the test verifies that expectedPorts contains 80 and 443 without demanding exact equality. Update the Expect call that references expectedPorts accordingly.
297-299:⚠️ Potential issue | 🟠 MajorDo not call
framework.ExpectNoErrorinsideEventuallycallbacks.Line 298 turns transient AWS/API failures into immediate spec failures instead of retrying.
Proposed fix
currentSGRules, err := getAWSSecurityGroupRules(ctx, ec2Client, foundLB.SecurityGroups) -framework.ExpectNoError(err, "failed to get security group rules to calculate the diff") +if err != nil { + framework.Logf("failed to get security group rules to calculate the diff: %v", err) + return nil, err +}🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@cmd/cloud-controller-manager-aws-tests-ext/e2e/loadbalancer.go` around lines 297 - 299, The callback passed to Eventually currently calls framework.ExpectNoError, which aborts immediately on transient AWS/API errors; instead call getAWSSecurityGroupRules(ctx, ec2Client, foundLB.SecurityGroups) inside the Eventually closure, and if it returns an error propagate that error from the closure (do not call framework.ExpectNoError there), then let the Eventually assertion check for success (e.g. Eventually(func() error { ... }).Should(Succeed())) so retries handle transient failures; update the closure around getAWSSecurityGroupRules and remove framework.ExpectNoError usage from inside it.
202-213:⚠️ Potential issue | 🔴 CriticalGuard
lbbefore logginglb.Statein poll loop.Line 212 can panic when
getAWSLoadBalancerFromDNSNamereturnslb == nil, which aborts retries.Proposed fix
if lb != nil && lb.State != nil && lb.State.Code == elbv2types.LoadBalancerStateEnumActive { foundLB = lb return true, nil } -framework.Logf("Load balancer not yet active, current state: %v", lb.State) +if lb == nil { + framework.Logf("Load balancer %s not returned yet", lbDNS) + return false, nil +} +framework.Logf("Load balancer not yet active, current state: %v", lb.State) return false, nil🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@cmd/cloud-controller-manager-aws-tests-ext/e2e/loadbalancer.go` around lines 202 - 213, The poll callback risk panics by dereferencing lb.State when lb can be nil; update the anonymous function passed to wait.PollUntilContextTimeout (the lambda that calls getAWSLoadBalancerFromDNSName) to guard lb before accessing lb.State and when logging — i.e., check if lb == nil (or lb.State == nil) and log an appropriate message like "Load balancer not found" or "state not available" instead of using lb.State directly; keep the existing success condition (lb != nil && lb.State != nil && lb.State.Code == elbv2types.LoadBalancerStateEnumActive) and only reference lb.State after those nil checks (refer to getAWSLoadBalancerFromDNSName, the local variable lb, and framework.Logf).
119-122:⚠️ Potential issue | 🟠 MajorRegister cleanup immediately after service/LB provisioning.
Lines 140/329/389/478 only clean up at the end of each spec. Any failure before those lines leaks NLBs and managed security groups.
Proposed fix pattern (apply to each spec)
svc, jig, err := createServiceNLB(ctx, cs, ns, serviceName, map[int32]int32{80: 8080}) framework.ExpectNoError(err, "failed to create NLB service load balancer") +Expect(svc.Status.LoadBalancer.Ingress).NotTo(BeEmpty(), "service must publish load balancer ingress") +lbDNS := svc.Status.LoadBalancer.Ingress[0].Hostname +DeferCleanup(func(cleanupCtx context.Context) { + err := deleteServiceAndWaitForLoadBalancerDeletion(cleanupCtx, jig, lbDNS) + framework.ExpectNoError(err, "failed to delete service and wait for load balancer deletion") +}) ... -err = deleteServiceAndWaitForLoadBalancerDeletion(ctx, jig, lbDNS) -framework.ExpectNoError(err, "failed to delete service and wait for load balancer deletion")Also applies to: 137-141, 248-250, 267-330, 354-356, 361-390, 440-442, 446-479
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@cmd/cloud-controller-manager-aws-tests-ext/e2e/loadbalancer.go` around lines 119 - 122, After creating the service/load-balancer with createServiceNLB (which returns svc and jig), register the cleanup immediately — right after the call and after checking err — instead of only at the end of the spec; add a cleanup registration that calls the existing jig/tear-down helper(s) to delete the Service and associated NLB and managed security groups (use jig.TearDown or the test framework's RegisterCleanupAction/DeferCleanup equivalent) so resources are removed on any early failure; apply this change wherever createServiceNLB is used (references: createServiceNLB, svc, jig).
🧹 Nitpick comments (1)
Makefile (1)
40-40: Declarebuildas.PHONYto avoid silent no-op builds.If a file/dir named
buildexists, Line 40 may not execute the recipe.Proposed fix
+.PHONY: build build: operator config-sync-controllers azure-config-credentials-injector cloud-controller-manager-aws-tests-extAs per coding guidelines, "Focus on major issues impacting performance, readability, maintainability and security. Avoid nitpicks and avoid verbosity."
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@Makefile` at line 40, The Makefile's build target is not declared .PHONY which can cause the recipe to be skipped if a file named "build" exists; add a .PHONY declaration for build (e.g., include " .PHONY: build" or add "build" to an existing .PHONY line) so the "build" target (and any related targets if preferred) are always executed; update the Makefile near the top-level target declarations to include this change referencing the target name "build".
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Duplicate comments:
In `@cmd/cloud-controller-manager-aws-tests-ext/e2e/loadbalancer.go`:
- Around line 565-570: The current polling callback in
wait.PollUntilContextTimeout treats any error from getAWSLoadBalancerFromDNSName
as a successful deletion; instead, update the callback to only return success
when the LB is actually not found (e.g., error indicates "not found" or
getAWSLoadBalancerFromDNSName returns nil/false), and for other errors (auth,
throttle, network) return false with the error so the poll will retry; reference
the wait.PollUntilContextTimeout callback, getAWSLoadBalancerFromDNSName,
elbClient, and lbDNS and implement explicit error inspection (AWS error code or
sentinel not-found condition) to differentiate deletion from
transient/permission errors.
- Around line 292-294: The check dereferences foundLB when computing
len(foundLB.SecurityGroups), risking a nil panic; change the logic to first test
if foundLB == nil and handle that case (log and return an error) before
accessing foundLB.SecurityGroups, and when logging the security-group count use
a safe value (e.g., 0) or conditional access; update the block around the
foundLB check (variable foundLB and its SecurityGroups) so the nil-case is
handled separately from the empty-security-groups case.
- Around line 467-476: The test currently builds expectedPorts from
currentSGRules and asserts exact multiset equality using
Expect(expectedPorts).To(ConsistOf(...)), which fails if there are duplicates or
extra ports; change the assertion to only require presence of ports 80 and 443
(e.g. use Gomega's ContainElements or two ContainElement checks) so the test
verifies that expectedPorts contains 80 and 443 without demanding exact
equality. Update the Expect call that references expectedPorts accordingly.
- Around line 297-299: The callback passed to Eventually currently calls
framework.ExpectNoError, which aborts immediately on transient AWS/API errors;
instead call getAWSSecurityGroupRules(ctx, ec2Client, foundLB.SecurityGroups)
inside the Eventually closure, and if it returns an error propagate that error
from the closure (do not call framework.ExpectNoError there), then let the
Eventually assertion check for success (e.g. Eventually(func() error { ...
}).Should(Succeed())) so retries handle transient failures; update the closure
around getAWSSecurityGroupRules and remove framework.ExpectNoError usage from
inside it.
- Around line 202-213: The poll callback risk panics by dereferencing lb.State
when lb can be nil; update the anonymous function passed to
wait.PollUntilContextTimeout (the lambda that calls
getAWSLoadBalancerFromDNSName) to guard lb before accessing lb.State and when
logging — i.e., check if lb == nil (or lb.State == nil) and log an appropriate
message like "Load balancer not found" or "state not available" instead of using
lb.State directly; keep the existing success condition (lb != nil && lb.State !=
nil && lb.State.Code == elbv2types.LoadBalancerStateEnumActive) and only
reference lb.State after those nil checks (refer to
getAWSLoadBalancerFromDNSName, the local variable lb, and framework.Logf).
- Around line 119-122: After creating the service/load-balancer with
createServiceNLB (which returns svc and jig), register the cleanup immediately —
right after the call and after checking err — instead of only at the end of the
spec; add a cleanup registration that calls the existing jig/tear-down helper(s)
to delete the Service and associated NLB and managed security groups (use
jig.TearDown or the test framework's RegisterCleanupAction/DeferCleanup
equivalent) so resources are removed on any early failure; apply this change
wherever createServiceNLB is used (references: createServiceNLB, svc, jig).
In `@cmd/cloud-controller-manager-aws-tests-ext/main.go`:
- Around line 167-170: The initFrameworkForTests function currently panics on
client config load failure by calling clientConfig.ClientConfig() and using
panic(fmt.Errorf(...)), which violates its error-return contract; change this to
return the error instead of panicking: replace the panic branch so
initFrameworkForTests returns the wrapped error (e.g., fmt.Errorf("failed to get
client config: %w", err)) up the call chain, and adjust callers to handle the
returned error if necessary; locate the clientConfig.ClientConfig() call and the
cfg variable in initFrameworkForTests and propagate the error rather than
exiting the process.
- Around line 191-193: The guard currently uses len(os.Getenv("TEST_JUNIT_DIR"))
>= 0 which is always true, causing testContext.ReportDir to be set even when the
env var is empty; change the check to verify the env var is non-empty (for
example retrieve the value into a variable via os.Getenv("TEST_JUNIT_DIR") and
use v != "" or len(v) > 0) and only assign testContext.ReportDir = v when that
condition passes.
---
Nitpick comments:
In `@Makefile`:
- Line 40: The Makefile's build target is not declared .PHONY which can cause
the recipe to be skipped if a file named "build" exists; add a .PHONY
declaration for build (e.g., include " .PHONY: build" or add "build" to an
existing .PHONY line) so the "build" target (and any related targets if
preferred) are always executed; update the Makefile near the top-level target
declarations to include this change referencing the target name "build".
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 6cb06d9e-e1f7-4970-9c34-45e2e2ff174e
⛔ Files ignored due to path filters (293)
cmd/cloud-controller-manager-aws-tests-ext/go.sumis excluded by!**/*.sumcmd/cloud-controller-manager-aws-tests-ext/vendor/cel.dev/expr/.bazelversionis excluded by!**/vendor/**cmd/cloud-controller-manager-aws-tests-ext/vendor/cel.dev/expr/.gitattributesis excluded by!**/vendor/**cmd/cloud-controller-manager-aws-tests-ext/vendor/cel.dev/expr/.gitignoreis excluded by!**/vendor/**cmd/cloud-controller-manager-aws-tests-ext/vendor/cel.dev/expr/BUILD.bazelis excluded by!**/vendor/**cmd/cloud-controller-manager-aws-tests-ext/vendor/cel.dev/expr/CODE_OF_CONDUCT.mdis excluded by!**/vendor/**cmd/cloud-controller-manager-aws-tests-ext/vendor/cel.dev/expr/CONTRIBUTING.mdis excluded by!**/vendor/**cmd/cloud-controller-manager-aws-tests-ext/vendor/cel.dev/expr/GOVERNANCE.mdis excluded by!**/vendor/**cmd/cloud-controller-manager-aws-tests-ext/vendor/cel.dev/expr/LICENSEis excluded by!**/vendor/**cmd/cloud-controller-manager-aws-tests-ext/vendor/cel.dev/expr/MAINTAINERS.mdis excluded by!**/vendor/**cmd/cloud-controller-manager-aws-tests-ext/vendor/cel.dev/expr/MODULE.bazelis excluded by!**/vendor/**cmd/cloud-controller-manager-aws-tests-ext/vendor/cel.dev/expr/README.mdis excluded by!**/vendor/**cmd/cloud-controller-manager-aws-tests-ext/vendor/cel.dev/expr/WORKSPACEis excluded by!**/vendor/**cmd/cloud-controller-manager-aws-tests-ext/vendor/cel.dev/expr/WORKSPACE.bzlmodis excluded by!**/vendor/**cmd/cloud-controller-manager-aws-tests-ext/vendor/cel.dev/expr/checked.pb.gois excluded by!**/*.pb.go,!**/vendor/**cmd/cloud-controller-manager-aws-tests-ext/vendor/cel.dev/expr/cloudbuild.yamlis excluded by!**/vendor/**cmd/cloud-controller-manager-aws-tests-ext/vendor/cel.dev/expr/eval.pb.gois excluded by!**/*.pb.go,!**/vendor/**cmd/cloud-controller-manager-aws-tests-ext/vendor/cel.dev/expr/explain.pb.gois excluded by!**/*.pb.go,!**/vendor/**cmd/cloud-controller-manager-aws-tests-ext/vendor/cel.dev/expr/regen_go_proto.shis excluded by!**/vendor/**cmd/cloud-controller-manager-aws-tests-ext/vendor/cel.dev/expr/regen_go_proto_canonical_protos.shis excluded by!**/vendor/**cmd/cloud-controller-manager-aws-tests-ext/vendor/cel.dev/expr/syntax.pb.gois excluded by!**/*.pb.go,!**/vendor/**cmd/cloud-controller-manager-aws-tests-ext/vendor/cel.dev/expr/value.pb.gois excluded by!**/*.pb.go,!**/vendor/**cmd/cloud-controller-manager-aws-tests-ext/vendor/github.com/Masterminds/semver/v3/.gitignoreis excluded by!**/vendor/**cmd/cloud-controller-manager-aws-tests-ext/vendor/github.com/Masterminds/semver/v3/.golangci.ymlis excluded by!**/vendor/**cmd/cloud-controller-manager-aws-tests-ext/vendor/github.com/Masterminds/semver/v3/CHANGELOG.mdis excluded by!**/vendor/**cmd/cloud-controller-manager-aws-tests-ext/vendor/github.com/Masterminds/semver/v3/LICENSE.txtis excluded by!**/vendor/**cmd/cloud-controller-manager-aws-tests-ext/vendor/github.com/Masterminds/semver/v3/Makefileis excluded by!**/vendor/**cmd/cloud-controller-manager-aws-tests-ext/vendor/github.com/Masterminds/semver/v3/README.mdis excluded by!**/vendor/**cmd/cloud-controller-manager-aws-tests-ext/vendor/github.com/Masterminds/semver/v3/SECURITY.mdis excluded by!**/vendor/**cmd/cloud-controller-manager-aws-tests-ext/vendor/github.com/Masterminds/semver/v3/collection.gois excluded by!**/vendor/**cmd/cloud-controller-manager-aws-tests-ext/vendor/github.com/Masterminds/semver/v3/constraints.gois excluded by!**/vendor/**cmd/cloud-controller-manager-aws-tests-ext/vendor/github.com/Masterminds/semver/v3/doc.gois excluded by!**/vendor/**cmd/cloud-controller-manager-aws-tests-ext/vendor/github.com/Masterminds/semver/v3/version.gois excluded by!**/vendor/**cmd/cloud-controller-manager-aws-tests-ext/vendor/github.com/antlr4-go/antlr/v4/.gitignoreis excluded by!**/vendor/**cmd/cloud-controller-manager-aws-tests-ext/vendor/github.com/antlr4-go/antlr/v4/LICENSEis excluded by!**/vendor/**cmd/cloud-controller-manager-aws-tests-ext/vendor/github.com/antlr4-go/antlr/v4/README.mdis excluded by!**/vendor/**cmd/cloud-controller-manager-aws-tests-ext/vendor/github.com/antlr4-go/antlr/v4/antlrdoc.gois excluded by!**/vendor/**cmd/cloud-controller-manager-aws-tests-ext/vendor/github.com/antlr4-go/antlr/v4/atn.gois excluded by!**/vendor/**cmd/cloud-controller-manager-aws-tests-ext/vendor/github.com/antlr4-go/antlr/v4/atn_config.gois excluded by!**/vendor/**cmd/cloud-controller-manager-aws-tests-ext/vendor/github.com/antlr4-go/antlr/v4/atn_config_set.gois excluded by!**/vendor/**cmd/cloud-controller-manager-aws-tests-ext/vendor/github.com/antlr4-go/antlr/v4/atn_deserialization_options.gois excluded by!**/vendor/**cmd/cloud-controller-manager-aws-tests-ext/vendor/github.com/antlr4-go/antlr/v4/atn_deserializer.gois excluded by!**/vendor/**cmd/cloud-controller-manager-aws-tests-ext/vendor/github.com/antlr4-go/antlr/v4/atn_simulator.gois excluded by!**/vendor/**cmd/cloud-controller-manager-aws-tests-ext/vendor/github.com/antlr4-go/antlr/v4/atn_state.gois excluded by!**/vendor/**cmd/cloud-controller-manager-aws-tests-ext/vendor/github.com/antlr4-go/antlr/v4/atn_type.gois excluded by!**/vendor/**cmd/cloud-controller-manager-aws-tests-ext/vendor/github.com/antlr4-go/antlr/v4/char_stream.gois excluded by!**/vendor/**cmd/cloud-controller-manager-aws-tests-ext/vendor/github.com/antlr4-go/antlr/v4/common_token_factory.gois excluded by!**/vendor/**cmd/cloud-controller-manager-aws-tests-ext/vendor/github.com/antlr4-go/antlr/v4/common_token_stream.gois excluded by!**/vendor/**cmd/cloud-controller-manager-aws-tests-ext/vendor/github.com/antlr4-go/antlr/v4/comparators.gois excluded by!**/vendor/**cmd/cloud-controller-manager-aws-tests-ext/vendor/github.com/antlr4-go/antlr/v4/configuration.gois excluded by!**/vendor/**cmd/cloud-controller-manager-aws-tests-ext/vendor/github.com/antlr4-go/antlr/v4/dfa.gois excluded by!**/vendor/**cmd/cloud-controller-manager-aws-tests-ext/vendor/github.com/antlr4-go/antlr/v4/dfa_serializer.gois excluded by!**/vendor/**cmd/cloud-controller-manager-aws-tests-ext/vendor/github.com/antlr4-go/antlr/v4/dfa_state.gois excluded by!**/vendor/**cmd/cloud-controller-manager-aws-tests-ext/vendor/github.com/antlr4-go/antlr/v4/diagnostic_error_listener.gois excluded by!**/vendor/**cmd/cloud-controller-manager-aws-tests-ext/vendor/github.com/antlr4-go/antlr/v4/error_listener.gois excluded by!**/vendor/**cmd/cloud-controller-manager-aws-tests-ext/vendor/github.com/antlr4-go/antlr/v4/error_strategy.gois excluded by!**/vendor/**cmd/cloud-controller-manager-aws-tests-ext/vendor/github.com/antlr4-go/antlr/v4/errors.gois excluded by!**/vendor/**cmd/cloud-controller-manager-aws-tests-ext/vendor/github.com/antlr4-go/antlr/v4/file_stream.gois excluded by!**/vendor/**cmd/cloud-controller-manager-aws-tests-ext/vendor/github.com/antlr4-go/antlr/v4/input_stream.gois excluded by!**/vendor/**cmd/cloud-controller-manager-aws-tests-ext/vendor/github.com/antlr4-go/antlr/v4/int_stream.gois excluded by!**/vendor/**cmd/cloud-controller-manager-aws-tests-ext/vendor/github.com/antlr4-go/antlr/v4/interval_set.gois excluded by!**/vendor/**cmd/cloud-controller-manager-aws-tests-ext/vendor/github.com/antlr4-go/antlr/v4/jcollect.gois excluded by!**/vendor/**cmd/cloud-controller-manager-aws-tests-ext/vendor/github.com/antlr4-go/antlr/v4/lexer.gois excluded by!**/vendor/**cmd/cloud-controller-manager-aws-tests-ext/vendor/github.com/antlr4-go/antlr/v4/lexer_action.gois excluded by!**/vendor/**cmd/cloud-controller-manager-aws-tests-ext/vendor/github.com/antlr4-go/antlr/v4/lexer_action_executor.gois excluded by!**/vendor/**cmd/cloud-controller-manager-aws-tests-ext/vendor/github.com/antlr4-go/antlr/v4/lexer_atn_simulator.gois excluded by!**/vendor/**cmd/cloud-controller-manager-aws-tests-ext/vendor/github.com/antlr4-go/antlr/v4/ll1_analyzer.gois excluded by!**/vendor/**cmd/cloud-controller-manager-aws-tests-ext/vendor/github.com/antlr4-go/antlr/v4/nostatistics.gois excluded by!**/vendor/**cmd/cloud-controller-manager-aws-tests-ext/vendor/github.com/antlr4-go/antlr/v4/parser.gois excluded by!**/vendor/**cmd/cloud-controller-manager-aws-tests-ext/vendor/github.com/antlr4-go/antlr/v4/parser_atn_simulator.gois excluded by!**/vendor/**cmd/cloud-controller-manager-aws-tests-ext/vendor/github.com/antlr4-go/antlr/v4/parser_rule_context.gois excluded by!**/vendor/**cmd/cloud-controller-manager-aws-tests-ext/vendor/github.com/antlr4-go/antlr/v4/prediction_context.gois excluded by!**/vendor/**cmd/cloud-controller-manager-aws-tests-ext/vendor/github.com/antlr4-go/antlr/v4/prediction_context_cache.gois excluded by!**/vendor/**cmd/cloud-controller-manager-aws-tests-ext/vendor/github.com/antlr4-go/antlr/v4/prediction_mode.gois excluded by!**/vendor/**cmd/cloud-controller-manager-aws-tests-ext/vendor/github.com/antlr4-go/antlr/v4/recognizer.gois excluded by!**/vendor/**cmd/cloud-controller-manager-aws-tests-ext/vendor/github.com/antlr4-go/antlr/v4/rule_context.gois excluded by!**/vendor/**cmd/cloud-controller-manager-aws-tests-ext/vendor/github.com/antlr4-go/antlr/v4/semantic_context.gois excluded by!**/vendor/**cmd/cloud-controller-manager-aws-tests-ext/vendor/github.com/antlr4-go/antlr/v4/statistics.gois excluded by!**/vendor/**cmd/cloud-controller-manager-aws-tests-ext/vendor/github.com/antlr4-go/antlr/v4/stats_data.gois excluded by!**/vendor/**cmd/cloud-controller-manager-aws-tests-ext/vendor/github.com/antlr4-go/antlr/v4/token.gois excluded by!**/vendor/**cmd/cloud-controller-manager-aws-tests-ext/vendor/github.com/antlr4-go/antlr/v4/token_source.gois excluded by!**/vendor/**cmd/cloud-controller-manager-aws-tests-ext/vendor/github.com/antlr4-go/antlr/v4/token_stream.gois excluded by!**/vendor/**cmd/cloud-controller-manager-aws-tests-ext/vendor/github.com/antlr4-go/antlr/v4/tokenstream_rewriter.gois excluded by!**/vendor/**cmd/cloud-controller-manager-aws-tests-ext/vendor/github.com/antlr4-go/antlr/v4/trace_listener.gois excluded by!**/vendor/**cmd/cloud-controller-manager-aws-tests-ext/vendor/github.com/antlr4-go/antlr/v4/transition.gois excluded by!**/vendor/**cmd/cloud-controller-manager-aws-tests-ext/vendor/github.com/antlr4-go/antlr/v4/tree.gois excluded by!**/vendor/**cmd/cloud-controller-manager-aws-tests-ext/vendor/github.com/antlr4-go/antlr/v4/trees.gois excluded by!**/vendor/**cmd/cloud-controller-manager-aws-tests-ext/vendor/github.com/antlr4-go/antlr/v4/utils.gois excluded by!**/vendor/**cmd/cloud-controller-manager-aws-tests-ext/vendor/github.com/aws/aws-sdk-go-v2/LICENSE.txtis excluded by!**/vendor/**cmd/cloud-controller-manager-aws-tests-ext/vendor/github.com/aws/aws-sdk-go-v2/NOTICE.txtis excluded by!**/vendor/**cmd/cloud-controller-manager-aws-tests-ext/vendor/github.com/aws/aws-sdk-go-v2/aws/accountid_endpoint_mode.gois excluded by!**/vendor/**cmd/cloud-controller-manager-aws-tests-ext/vendor/github.com/aws/aws-sdk-go-v2/aws/checksum.gois excluded by!**/vendor/**cmd/cloud-controller-manager-aws-tests-ext/vendor/github.com/aws/aws-sdk-go-v2/aws/config.gois excluded by!**/vendor/**cmd/cloud-controller-manager-aws-tests-ext/vendor/github.com/aws/aws-sdk-go-v2/aws/context.gois excluded by!**/vendor/**cmd/cloud-controller-manager-aws-tests-ext/vendor/github.com/aws/aws-sdk-go-v2/aws/credential_cache.gois excluded by!**/vendor/**cmd/cloud-controller-manager-aws-tests-ext/vendor/github.com/aws/aws-sdk-go-v2/aws/credentials.gois excluded by!**/vendor/**cmd/cloud-controller-manager-aws-tests-ext/vendor/github.com/aws/aws-sdk-go-v2/aws/defaults/auto.gois excluded by!**/vendor/**cmd/cloud-controller-manager-aws-tests-ext/vendor/github.com/aws/aws-sdk-go-v2/aws/defaults/configuration.gois excluded by!**/vendor/**cmd/cloud-controller-manager-aws-tests-ext/vendor/github.com/aws/aws-sdk-go-v2/aws/defaults/defaults.gois excluded by!**/vendor/**cmd/cloud-controller-manager-aws-tests-ext/vendor/github.com/aws/aws-sdk-go-v2/aws/defaults/doc.gois excluded by!**/vendor/**cmd/cloud-controller-manager-aws-tests-ext/vendor/github.com/aws/aws-sdk-go-v2/aws/defaultsmode.gois excluded by!**/vendor/**cmd/cloud-controller-manager-aws-tests-ext/vendor/github.com/aws/aws-sdk-go-v2/aws/doc.gois excluded by!**/vendor/**cmd/cloud-controller-manager-aws-tests-ext/vendor/github.com/aws/aws-sdk-go-v2/aws/endpoints.gois excluded by!**/vendor/**cmd/cloud-controller-manager-aws-tests-ext/vendor/github.com/aws/aws-sdk-go-v2/aws/errors.gois excluded by!**/vendor/**cmd/cloud-controller-manager-aws-tests-ext/vendor/github.com/aws/aws-sdk-go-v2/aws/from_ptr.gois excluded by!**/vendor/**cmd/cloud-controller-manager-aws-tests-ext/vendor/github.com/aws/aws-sdk-go-v2/aws/go_module_metadata.gois excluded by!**/vendor/**cmd/cloud-controller-manager-aws-tests-ext/vendor/github.com/aws/aws-sdk-go-v2/aws/logging.gois excluded by!**/vendor/**cmd/cloud-controller-manager-aws-tests-ext/vendor/github.com/aws/aws-sdk-go-v2/aws/logging_generate.gois excluded by!**/vendor/**cmd/cloud-controller-manager-aws-tests-ext/vendor/github.com/aws/aws-sdk-go-v2/aws/middleware/metadata.gois excluded by!**/vendor/**cmd/cloud-controller-manager-aws-tests-ext/vendor/github.com/aws/aws-sdk-go-v2/aws/middleware/middleware.gois excluded by!**/vendor/**cmd/cloud-controller-manager-aws-tests-ext/vendor/github.com/aws/aws-sdk-go-v2/aws/middleware/osname.gois excluded by!**/vendor/**cmd/cloud-controller-manager-aws-tests-ext/vendor/github.com/aws/aws-sdk-go-v2/aws/middleware/osname_go115.gois excluded by!**/vendor/**cmd/cloud-controller-manager-aws-tests-ext/vendor/github.com/aws/aws-sdk-go-v2/aws/middleware/recursion_detection.gois excluded by!**/vendor/**cmd/cloud-controller-manager-aws-tests-ext/vendor/github.com/aws/aws-sdk-go-v2/aws/middleware/request_id.gois excluded by!**/vendor/**cmd/cloud-controller-manager-aws-tests-ext/vendor/github.com/aws/aws-sdk-go-v2/aws/middleware/request_id_retriever.gois excluded by!**/vendor/**cmd/cloud-controller-manager-aws-tests-ext/vendor/github.com/aws/aws-sdk-go-v2/aws/middleware/user_agent.gois excluded by!**/vendor/**cmd/cloud-controller-manager-aws-tests-ext/vendor/github.com/aws/aws-sdk-go-v2/aws/protocol/ec2query/error_utils.gois excluded by!**/vendor/**cmd/cloud-controller-manager-aws-tests-ext/vendor/github.com/aws/aws-sdk-go-v2/aws/protocol/query/array.gois excluded by!**/vendor/**cmd/cloud-controller-manager-aws-tests-ext/vendor/github.com/aws/aws-sdk-go-v2/aws/protocol/query/encoder.gois excluded by!**/vendor/**cmd/cloud-controller-manager-aws-tests-ext/vendor/github.com/aws/aws-sdk-go-v2/aws/protocol/query/map.gois excluded by!**/vendor/**cmd/cloud-controller-manager-aws-tests-ext/vendor/github.com/aws/aws-sdk-go-v2/aws/protocol/query/middleware.gois excluded by!**/vendor/**cmd/cloud-controller-manager-aws-tests-ext/vendor/github.com/aws/aws-sdk-go-v2/aws/protocol/query/object.gois excluded by!**/vendor/**cmd/cloud-controller-manager-aws-tests-ext/vendor/github.com/aws/aws-sdk-go-v2/aws/protocol/query/value.gois excluded by!**/vendor/**cmd/cloud-controller-manager-aws-tests-ext/vendor/github.com/aws/aws-sdk-go-v2/aws/protocol/restjson/decoder_util.gois excluded by!**/vendor/**cmd/cloud-controller-manager-aws-tests-ext/vendor/github.com/aws/aws-sdk-go-v2/aws/protocol/xml/error_utils.gois excluded by!**/vendor/**cmd/cloud-controller-manager-aws-tests-ext/vendor/github.com/aws/aws-sdk-go-v2/aws/ratelimit/none.gois excluded by!**/vendor/**cmd/cloud-controller-manager-aws-tests-ext/vendor/github.com/aws/aws-sdk-go-v2/aws/ratelimit/token_bucket.gois excluded by!**/vendor/**cmd/cloud-controller-manager-aws-tests-ext/vendor/github.com/aws/aws-sdk-go-v2/aws/ratelimit/token_rate_limit.gois excluded by!**/vendor/**cmd/cloud-controller-manager-aws-tests-ext/vendor/github.com/aws/aws-sdk-go-v2/aws/request.gois excluded by!**/vendor/**cmd/cloud-controller-manager-aws-tests-ext/vendor/github.com/aws/aws-sdk-go-v2/aws/retry/adaptive.gois excluded by!**/vendor/**cmd/cloud-controller-manager-aws-tests-ext/vendor/github.com/aws/aws-sdk-go-v2/aws/retry/adaptive_ratelimit.gois excluded by!**/vendor/**cmd/cloud-controller-manager-aws-tests-ext/vendor/github.com/aws/aws-sdk-go-v2/aws/retry/adaptive_token_bucket.gois excluded by!**/vendor/**cmd/cloud-controller-manager-aws-tests-ext/vendor/github.com/aws/aws-sdk-go-v2/aws/retry/attempt_metrics.gois excluded by!**/vendor/**cmd/cloud-controller-manager-aws-tests-ext/vendor/github.com/aws/aws-sdk-go-v2/aws/retry/doc.gois excluded by!**/vendor/**cmd/cloud-controller-manager-aws-tests-ext/vendor/github.com/aws/aws-sdk-go-v2/aws/retry/errors.gois excluded by!**/vendor/**cmd/cloud-controller-manager-aws-tests-ext/vendor/github.com/aws/aws-sdk-go-v2/aws/retry/jitter_backoff.gois excluded by!**/vendor/**cmd/cloud-controller-manager-aws-tests-ext/vendor/github.com/aws/aws-sdk-go-v2/aws/retry/metadata.gois excluded by!**/vendor/**cmd/cloud-controller-manager-aws-tests-ext/vendor/github.com/aws/aws-sdk-go-v2/aws/retry/middleware.gois excluded by!**/vendor/**cmd/cloud-controller-manager-aws-tests-ext/vendor/github.com/aws/aws-sdk-go-v2/aws/retry/retry.gois excluded by!**/vendor/**cmd/cloud-controller-manager-aws-tests-ext/vendor/github.com/aws/aws-sdk-go-v2/aws/retry/retryable_error.gois excluded by!**/vendor/**cmd/cloud-controller-manager-aws-tests-ext/vendor/github.com/aws/aws-sdk-go-v2/aws/retry/standard.gois excluded by!**/vendor/**cmd/cloud-controller-manager-aws-tests-ext/vendor/github.com/aws/aws-sdk-go-v2/aws/retry/throttle_error.gois excluded by!**/vendor/**cmd/cloud-controller-manager-aws-tests-ext/vendor/github.com/aws/aws-sdk-go-v2/aws/retry/timeout_error.gois excluded by!**/vendor/**cmd/cloud-controller-manager-aws-tests-ext/vendor/github.com/aws/aws-sdk-go-v2/aws/retryer.gois excluded by!**/vendor/**cmd/cloud-controller-manager-aws-tests-ext/vendor/github.com/aws/aws-sdk-go-v2/aws/runtime.gois excluded by!**/vendor/**cmd/cloud-controller-manager-aws-tests-ext/vendor/github.com/aws/aws-sdk-go-v2/aws/signer/internal/v4/cache.gois excluded by!**/vendor/**cmd/cloud-controller-manager-aws-tests-ext/vendor/github.com/aws/aws-sdk-go-v2/aws/signer/internal/v4/const.gois excluded by!**/vendor/**cmd/cloud-controller-manager-aws-tests-ext/vendor/github.com/aws/aws-sdk-go-v2/aws/signer/internal/v4/header_rules.gois excluded by!**/vendor/**cmd/cloud-controller-manager-aws-tests-ext/vendor/github.com/aws/aws-sdk-go-v2/aws/signer/internal/v4/headers.gois excluded by!**/vendor/**cmd/cloud-controller-manager-aws-tests-ext/vendor/github.com/aws/aws-sdk-go-v2/aws/signer/internal/v4/hmac.gois excluded by!**/vendor/**cmd/cloud-controller-manager-aws-tests-ext/vendor/github.com/aws/aws-sdk-go-v2/aws/signer/internal/v4/host.gois excluded by!**/vendor/**cmd/cloud-controller-manager-aws-tests-ext/vendor/github.com/aws/aws-sdk-go-v2/aws/signer/internal/v4/scope.gois excluded by!**/vendor/**cmd/cloud-controller-manager-aws-tests-ext/vendor/github.com/aws/aws-sdk-go-v2/aws/signer/internal/v4/time.gois excluded by!**/vendor/**cmd/cloud-controller-manager-aws-tests-ext/vendor/github.com/aws/aws-sdk-go-v2/aws/signer/internal/v4/util.gois excluded by!**/vendor/**cmd/cloud-controller-manager-aws-tests-ext/vendor/github.com/aws/aws-sdk-go-v2/aws/signer/v4/middleware.gois excluded by!**/vendor/**cmd/cloud-controller-manager-aws-tests-ext/vendor/github.com/aws/aws-sdk-go-v2/aws/signer/v4/presign_middleware.gois excluded by!**/vendor/**cmd/cloud-controller-manager-aws-tests-ext/vendor/github.com/aws/aws-sdk-go-v2/aws/signer/v4/stream.gois excluded by!**/vendor/**cmd/cloud-controller-manager-aws-tests-ext/vendor/github.com/aws/aws-sdk-go-v2/aws/signer/v4/v4.gois excluded by!**/vendor/**cmd/cloud-controller-manager-aws-tests-ext/vendor/github.com/aws/aws-sdk-go-v2/aws/to_ptr.gois excluded by!**/vendor/**cmd/cloud-controller-manager-aws-tests-ext/vendor/github.com/aws/aws-sdk-go-v2/aws/transport/http/client.gois excluded by!**/vendor/**cmd/cloud-controller-manager-aws-tests-ext/vendor/github.com/aws/aws-sdk-go-v2/aws/transport/http/content_type.gois excluded by!**/vendor/**cmd/cloud-controller-manager-aws-tests-ext/vendor/github.com/aws/aws-sdk-go-v2/aws/transport/http/response_error.gois excluded by!**/vendor/**cmd/cloud-controller-manager-aws-tests-ext/vendor/github.com/aws/aws-sdk-go-v2/aws/transport/http/response_error_middleware.gois excluded by!**/vendor/**cmd/cloud-controller-manager-aws-tests-ext/vendor/github.com/aws/aws-sdk-go-v2/aws/transport/http/timeout_read_closer.gois excluded by!**/vendor/**cmd/cloud-controller-manager-aws-tests-ext/vendor/github.com/aws/aws-sdk-go-v2/aws/types.gois excluded by!**/vendor/**cmd/cloud-controller-manager-aws-tests-ext/vendor/github.com/aws/aws-sdk-go-v2/aws/version.gois excluded by!**/vendor/**cmd/cloud-controller-manager-aws-tests-ext/vendor/github.com/aws/aws-sdk-go-v2/config/CHANGELOG.mdis excluded by!**/vendor/**cmd/cloud-controller-manager-aws-tests-ext/vendor/github.com/aws/aws-sdk-go-v2/config/LICENSE.txtis excluded by!**/vendor/**cmd/cloud-controller-manager-aws-tests-ext/vendor/github.com/aws/aws-sdk-go-v2/config/config.gois excluded by!**/vendor/**cmd/cloud-controller-manager-aws-tests-ext/vendor/github.com/aws/aws-sdk-go-v2/config/defaultsmode.gois excluded by!**/vendor/**cmd/cloud-controller-manager-aws-tests-ext/vendor/github.com/aws/aws-sdk-go-v2/config/doc.gois excluded by!**/vendor/**cmd/cloud-controller-manager-aws-tests-ext/vendor/github.com/aws/aws-sdk-go-v2/config/env_config.gois excluded by!**/vendor/**cmd/cloud-controller-manager-aws-tests-ext/vendor/github.com/aws/aws-sdk-go-v2/config/generate.gois excluded by!**/vendor/**cmd/cloud-controller-manager-aws-tests-ext/vendor/github.com/aws/aws-sdk-go-v2/config/go_module_metadata.gois excluded by!**/vendor/**cmd/cloud-controller-manager-aws-tests-ext/vendor/github.com/aws/aws-sdk-go-v2/config/load_options.gois excluded by!**/vendor/**cmd/cloud-controller-manager-aws-tests-ext/vendor/github.com/aws/aws-sdk-go-v2/config/local.gois excluded by!**/vendor/**cmd/cloud-controller-manager-aws-tests-ext/vendor/github.com/aws/aws-sdk-go-v2/config/provider.gois excluded by!**/vendor/**cmd/cloud-controller-manager-aws-tests-ext/vendor/github.com/aws/aws-sdk-go-v2/config/resolve.gois excluded by!**/vendor/**cmd/cloud-controller-manager-aws-tests-ext/vendor/github.com/aws/aws-sdk-go-v2/config/resolve_bearer_token.gois excluded by!**/vendor/**cmd/cloud-controller-manager-aws-tests-ext/vendor/github.com/aws/aws-sdk-go-v2/config/resolve_credentials.gois excluded by!**/vendor/**cmd/cloud-controller-manager-aws-tests-ext/vendor/github.com/aws/aws-sdk-go-v2/config/shared_config.gois excluded by!**/vendor/**cmd/cloud-controller-manager-aws-tests-ext/vendor/github.com/aws/aws-sdk-go-v2/credentials/CHANGELOG.mdis excluded by!**/vendor/**cmd/cloud-controller-manager-aws-tests-ext/vendor/github.com/aws/aws-sdk-go-v2/credentials/LICENSE.txtis excluded by!**/vendor/**cmd/cloud-controller-manager-aws-tests-ext/vendor/github.com/aws/aws-sdk-go-v2/credentials/doc.gois excluded by!**/vendor/**cmd/cloud-controller-manager-aws-tests-ext/vendor/github.com/aws/aws-sdk-go-v2/credentials/ec2rolecreds/doc.gois excluded by!**/vendor/**cmd/cloud-controller-manager-aws-tests-ext/vendor/github.com/aws/aws-sdk-go-v2/credentials/ec2rolecreds/provider.gois excluded by!**/vendor/**cmd/cloud-controller-manager-aws-tests-ext/vendor/github.com/aws/aws-sdk-go-v2/credentials/endpointcreds/internal/client/auth.gois excluded by!**/vendor/**cmd/cloud-controller-manager-aws-tests-ext/vendor/github.com/aws/aws-sdk-go-v2/credentials/endpointcreds/internal/client/client.gois excluded by!**/vendor/**cmd/cloud-controller-manager-aws-tests-ext/vendor/github.com/aws/aws-sdk-go-v2/credentials/endpointcreds/internal/client/endpoints.gois excluded by!**/vendor/**cmd/cloud-controller-manager-aws-tests-ext/vendor/github.com/aws/aws-sdk-go-v2/credentials/endpointcreds/internal/client/middleware.gois excluded by!**/vendor/**cmd/cloud-controller-manager-aws-tests-ext/vendor/github.com/aws/aws-sdk-go-v2/credentials/endpointcreds/provider.gois excluded by!**/vendor/**cmd/cloud-controller-manager-aws-tests-ext/vendor/github.com/aws/aws-sdk-go-v2/credentials/go_module_metadata.gois excluded by!**/vendor/**cmd/cloud-controller-manager-aws-tests-ext/vendor/github.com/aws/aws-sdk-go-v2/credentials/processcreds/doc.gois excluded by!**/vendor/**cmd/cloud-controller-manager-aws-tests-ext/vendor/github.com/aws/aws-sdk-go-v2/credentials/processcreds/provider.gois excluded by!**/vendor/**cmd/cloud-controller-manager-aws-tests-ext/vendor/github.com/aws/aws-sdk-go-v2/credentials/ssocreds/doc.gois excluded by!**/vendor/**cmd/cloud-controller-manager-aws-tests-ext/vendor/github.com/aws/aws-sdk-go-v2/credentials/ssocreds/sso_cached_token.gois excluded by!**/vendor/**cmd/cloud-controller-manager-aws-tests-ext/vendor/github.com/aws/aws-sdk-go-v2/credentials/ssocreds/sso_credentials_provider.gois excluded by!**/vendor/**cmd/cloud-controller-manager-aws-tests-ext/vendor/github.com/aws/aws-sdk-go-v2/credentials/ssocreds/sso_token_provider.gois excluded by!**/vendor/**cmd/cloud-controller-manager-aws-tests-ext/vendor/github.com/aws/aws-sdk-go-v2/credentials/static_provider.gois excluded by!**/vendor/**cmd/cloud-controller-manager-aws-tests-ext/vendor/github.com/aws/aws-sdk-go-v2/credentials/stscreds/assume_role_provider.gois excluded by!**/vendor/**cmd/cloud-controller-manager-aws-tests-ext/vendor/github.com/aws/aws-sdk-go-v2/credentials/stscreds/web_identity_provider.gois excluded by!**/vendor/**cmd/cloud-controller-manager-aws-tests-ext/vendor/github.com/aws/aws-sdk-go-v2/feature/ec2/imds/CHANGELOG.mdis excluded by!**/vendor/**cmd/cloud-controller-manager-aws-tests-ext/vendor/github.com/aws/aws-sdk-go-v2/feature/ec2/imds/LICENSE.txtis excluded by!**/vendor/**cmd/cloud-controller-manager-aws-tests-ext/vendor/github.com/aws/aws-sdk-go-v2/feature/ec2/imds/api_client.gois excluded by!**/vendor/**cmd/cloud-controller-manager-aws-tests-ext/vendor/github.com/aws/aws-sdk-go-v2/feature/ec2/imds/api_op_GetDynamicData.gois excluded by!**/vendor/**cmd/cloud-controller-manager-aws-tests-ext/vendor/github.com/aws/aws-sdk-go-v2/feature/ec2/imds/api_op_GetIAMInfo.gois excluded by!**/vendor/**cmd/cloud-controller-manager-aws-tests-ext/vendor/github.com/aws/aws-sdk-go-v2/feature/ec2/imds/api_op_GetInstanceIdentityDocument.gois excluded by!**/vendor/**cmd/cloud-controller-manager-aws-tests-ext/vendor/github.com/aws/aws-sdk-go-v2/feature/ec2/imds/api_op_GetMetadata.gois excluded by!**/vendor/**cmd/cloud-controller-manager-aws-tests-ext/vendor/github.com/aws/aws-sdk-go-v2/feature/ec2/imds/api_op_GetRegion.gois excluded by!**/vendor/**cmd/cloud-controller-manager-aws-tests-ext/vendor/github.com/aws/aws-sdk-go-v2/feature/ec2/imds/api_op_GetToken.gois excluded by!**/vendor/**cmd/cloud-controller-manager-aws-tests-ext/vendor/github.com/aws/aws-sdk-go-v2/feature/ec2/imds/api_op_GetUserData.gois excluded by!**/vendor/**cmd/cloud-controller-manager-aws-tests-ext/vendor/github.com/aws/aws-sdk-go-v2/feature/ec2/imds/auth.gois excluded by!**/vendor/**cmd/cloud-controller-manager-aws-tests-ext/vendor/github.com/aws/aws-sdk-go-v2/feature/ec2/imds/doc.gois excluded by!**/vendor/**cmd/cloud-controller-manager-aws-tests-ext/vendor/github.com/aws/aws-sdk-go-v2/feature/ec2/imds/endpoints.gois excluded by!**/vendor/**cmd/cloud-controller-manager-aws-tests-ext/vendor/github.com/aws/aws-sdk-go-v2/feature/ec2/imds/go_module_metadata.gois excluded by!**/vendor/**cmd/cloud-controller-manager-aws-tests-ext/vendor/github.com/aws/aws-sdk-go-v2/feature/ec2/imds/internal/config/resolvers.gois excluded by!**/vendor/**cmd/cloud-controller-manager-aws-tests-ext/vendor/github.com/aws/aws-sdk-go-v2/feature/ec2/imds/request_middleware.gois excluded by!**/vendor/**cmd/cloud-controller-manager-aws-tests-ext/vendor/github.com/aws/aws-sdk-go-v2/feature/ec2/imds/token_provider.gois excluded by!**/vendor/**cmd/cloud-controller-manager-aws-tests-ext/vendor/github.com/aws/aws-sdk-go-v2/internal/auth/auth.gois excluded by!**/vendor/**cmd/cloud-controller-manager-aws-tests-ext/vendor/github.com/aws/aws-sdk-go-v2/internal/auth/scheme.gois excluded by!**/vendor/**cmd/cloud-controller-manager-aws-tests-ext/vendor/github.com/aws/aws-sdk-go-v2/internal/auth/smithy/bearer_token_adapter.gois excluded by!**/vendor/**cmd/cloud-controller-manager-aws-tests-ext/vendor/github.com/aws/aws-sdk-go-v2/internal/auth/smithy/bearer_token_signer_adapter.gois excluded by!**/vendor/**cmd/cloud-controller-manager-aws-tests-ext/vendor/github.com/aws/aws-sdk-go-v2/internal/auth/smithy/credentials_adapter.gois excluded by!**/vendor/**cmd/cloud-controller-manager-aws-tests-ext/vendor/github.com/aws/aws-sdk-go-v2/internal/auth/smithy/smithy.gois excluded by!**/vendor/**cmd/cloud-controller-manager-aws-tests-ext/vendor/github.com/aws/aws-sdk-go-v2/internal/auth/smithy/v4signer_adapter.gois excluded by!**/vendor/**cmd/cloud-controller-manager-aws-tests-ext/vendor/github.com/aws/aws-sdk-go-v2/internal/configsources/CHANGELOG.mdis excluded by!**/vendor/**cmd/cloud-controller-manager-aws-tests-ext/vendor/github.com/aws/aws-sdk-go-v2/internal/configsources/LICENSE.txtis excluded by!**/vendor/**cmd/cloud-controller-manager-aws-tests-ext/vendor/github.com/aws/aws-sdk-go-v2/internal/configsources/config.gois excluded by!**/vendor/**cmd/cloud-controller-manager-aws-tests-ext/vendor/github.com/aws/aws-sdk-go-v2/internal/configsources/endpoints.gois excluded by!**/vendor/**cmd/cloud-controller-manager-aws-tests-ext/vendor/github.com/aws/aws-sdk-go-v2/internal/configsources/go_module_metadata.gois excluded by!**/vendor/**cmd/cloud-controller-manager-aws-tests-ext/vendor/github.com/aws/aws-sdk-go-v2/internal/context/context.gois excluded by!**/vendor/**cmd/cloud-controller-manager-aws-tests-ext/vendor/github.com/aws/aws-sdk-go-v2/internal/endpoints/awsrulesfn/arn.gois excluded by!**/vendor/**cmd/cloud-controller-manager-aws-tests-ext/vendor/github.com/aws/aws-sdk-go-v2/internal/endpoints/awsrulesfn/doc.gois excluded by!**/vendor/**cmd/cloud-controller-manager-aws-tests-ext/vendor/github.com/aws/aws-sdk-go-v2/internal/endpoints/awsrulesfn/generate.gois excluded by!**/vendor/**cmd/cloud-controller-manager-aws-tests-ext/vendor/github.com/aws/aws-sdk-go-v2/internal/endpoints/awsrulesfn/host.gois excluded by!**/vendor/**cmd/cloud-controller-manager-aws-tests-ext/vendor/github.com/aws/aws-sdk-go-v2/internal/endpoints/awsrulesfn/partition.gois excluded by!**/vendor/**cmd/cloud-controller-manager-aws-tests-ext/vendor/github.com/aws/aws-sdk-go-v2/internal/endpoints/awsrulesfn/partitions.gois excluded by!**/vendor/**cmd/cloud-controller-manager-aws-tests-ext/vendor/github.com/aws/aws-sdk-go-v2/internal/endpoints/awsrulesfn/partitions.jsonis excluded by!**/vendor/**cmd/cloud-controller-manager-aws-tests-ext/vendor/github.com/aws/aws-sdk-go-v2/internal/endpoints/endpoints.gois excluded by!**/vendor/**cmd/cloud-controller-manager-aws-tests-ext/vendor/github.com/aws/aws-sdk-go-v2/internal/endpoints/v2/CHANGELOG.mdis excluded by!**/vendor/**cmd/cloud-controller-manager-aws-tests-ext/vendor/github.com/aws/aws-sdk-go-v2/internal/endpoints/v2/LICENSE.txtis excluded by!**/vendor/**cmd/cloud-controller-manager-aws-tests-ext/vendor/github.com/aws/aws-sdk-go-v2/internal/endpoints/v2/endpoints.gois excluded by!**/vendor/**cmd/cloud-controller-manager-aws-tests-ext/vendor/github.com/aws/aws-sdk-go-v2/internal/endpoints/v2/go_module_metadata.gois excluded by!**/vendor/**cmd/cloud-controller-manager-aws-tests-ext/vendor/github.com/aws/aws-sdk-go-v2/internal/ini/CHANGELOG.mdis excluded by!**/vendor/**cmd/cloud-controller-manager-aws-tests-ext/vendor/github.com/aws/aws-sdk-go-v2/internal/ini/LICENSE.txtis excluded by!**/vendor/**cmd/cloud-controller-manager-aws-tests-ext/vendor/github.com/aws/aws-sdk-go-v2/internal/ini/errors.gois excluded by!**/vendor/**cmd/cloud-controller-manager-aws-tests-ext/vendor/github.com/aws/aws-sdk-go-v2/internal/ini/go_module_metadata.gois excluded by!**/vendor/**cmd/cloud-controller-manager-aws-tests-ext/vendor/github.com/aws/aws-sdk-go-v2/internal/ini/ini.gois excluded by!**/vendor/**cmd/cloud-controller-manager-aws-tests-ext/vendor/github.com/aws/aws-sdk-go-v2/internal/ini/parse.gois excluded by!**/vendor/**cmd/cloud-controller-manager-aws-tests-ext/vendor/github.com/aws/aws-sdk-go-v2/internal/ini/sections.gois excluded by!**/vendor/**cmd/cloud-controller-manager-aws-tests-ext/vendor/github.com/aws/aws-sdk-go-v2/internal/ini/strings.gois excluded by!**/vendor/**cmd/cloud-controller-manager-aws-tests-ext/vendor/github.com/aws/aws-sdk-go-v2/internal/ini/token.gois excluded by!**/vendor/**cmd/cloud-controller-manager-aws-tests-ext/vendor/github.com/aws/aws-sdk-go-v2/internal/ini/tokenize.gois excluded by!**/vendor/**cmd/cloud-controller-manager-aws-tests-ext/vendor/github.com/aws/aws-sdk-go-v2/internal/ini/value.gois excluded by!**/vendor/**cmd/cloud-controller-manager-aws-tests-ext/vendor/github.com/aws/aws-sdk-go-v2/internal/middleware/middleware.gois excluded by!**/vendor/**cmd/cloud-controller-manager-aws-tests-ext/vendor/github.com/aws/aws-sdk-go-v2/internal/rand/rand.gois excluded by!**/vendor/**cmd/cloud-controller-manager-aws-tests-ext/vendor/github.com/aws/aws-sdk-go-v2/internal/sdk/interfaces.gois excluded by!**/vendor/**cmd/cloud-controller-manager-aws-tests-ext/vendor/github.com/aws/aws-sdk-go-v2/internal/sdk/time.gois excluded by!**/vendor/**cmd/cloud-controller-manager-aws-tests-ext/vendor/github.com/aws/aws-sdk-go-v2/internal/sdkio/byte.gois excluded by!**/vendor/**cmd/cloud-controller-manager-aws-tests-ext/vendor/github.com/aws/aws-sdk-go-v2/internal/shareddefaults/shared_config.gois excluded by!**/vendor/**cmd/cloud-controller-manager-aws-tests-ext/vendor/github.com/aws/aws-sdk-go-v2/internal/strings/strings.gois excluded by!**/vendor/**cmd/cloud-controller-manager-aws-tests-ext/vendor/github.com/aws/aws-sdk-go-v2/internal/sync/singleflight/LICENSEis excluded by!**/vendor/**cmd/cloud-controller-manager-aws-tests-ext/vendor/github.com/aws/aws-sdk-go-v2/internal/sync/singleflight/docs.gois excluded by!**/vendor/**cmd/cloud-controller-manager-aws-tests-ext/vendor/github.com/aws/aws-sdk-go-v2/internal/sync/singleflight/singleflight.gois excluded by!**/vendor/**cmd/cloud-controller-manager-aws-tests-ext/vendor/github.com/aws/aws-sdk-go-v2/internal/timeconv/duration.gois excluded by!**/vendor/**cmd/cloud-controller-manager-aws-tests-ext/vendor/github.com/aws/aws-sdk-go-v2/service/ec2/CHANGELOG.mdis excluded by!**/vendor/**cmd/cloud-controller-manager-aws-tests-ext/vendor/github.com/aws/aws-sdk-go-v2/service/ec2/LICENSE.txtis excluded by!**/vendor/**cmd/cloud-controller-manager-aws-tests-ext/vendor/github.com/aws/aws-sdk-go-v2/service/ec2/api_client.gois excluded by!**/vendor/**cmd/cloud-controller-manager-aws-tests-ext/vendor/github.com/aws/aws-sdk-go-v2/service/ec2/api_op_AcceptAddressTransfer.gois excluded by!**/vendor/**cmd/cloud-controller-manager-aws-tests-ext/vendor/github.com/aws/aws-sdk-go-v2/service/ec2/api_op_AcceptCapacityReservationBillingOwnership.gois excluded by!**/vendor/**cmd/cloud-controller-manager-aws-tests-ext/vendor/github.com/aws/aws-sdk-go-v2/service/ec2/api_op_AcceptReservedInstancesExchangeQuote.gois excluded by!**/vendor/**cmd/cloud-controller-manager-aws-tests-ext/vendor/github.com/aws/aws-sdk-go-v2/service/ec2/api_op_AcceptTransitGatewayMulticastDomainAssociations.gois excluded by!**/vendor/**cmd/cloud-controller-manager-aws-tests-ext/vendor/github.com/aws/aws-sdk-go-v2/service/ec2/api_op_AcceptTransitGatewayPeeringAttachment.gois excluded by!**/vendor/**cmd/cloud-controller-manager-aws-tests-ext/vendor/github.com/aws/aws-sdk-go-v2/service/ec2/api_op_AcceptTransitGatewayVpcAttachment.gois excluded by!**/vendor/**cmd/cloud-controller-manager-aws-tests-ext/vendor/github.com/aws/aws-sdk-go-v2/service/ec2/api_op_AcceptVpcEndpointConnections.gois excluded by!**/vendor/**cmd/cloud-controller-manager-aws-tests-ext/vendor/github.com/aws/aws-sdk-go-v2/service/ec2/api_op_AcceptVpcPeeringConnection.gois excluded by!**/vendor/**cmd/cloud-controller-manager-aws-tests-ext/vendor/github.com/aws/aws-sdk-go-v2/service/ec2/api_op_AdvertiseByoipCidr.gois excluded by!**/vendor/**cmd/cloud-controller-manager-aws-tests-ext/vendor/github.com/aws/aws-sdk-go-v2/service/ec2/api_op_AllocateAddress.gois excluded by!**/vendor/**cmd/cloud-controller-manager-aws-tests-ext/vendor/github.com/aws/aws-sdk-go-v2/service/ec2/api_op_AllocateHosts.gois excluded by!**/vendor/**cmd/cloud-controller-manager-aws-tests-ext/vendor/github.com/aws/aws-sdk-go-v2/service/ec2/api_op_AllocateIpamPoolCidr.gois excluded by!**/vendor/**cmd/cloud-controller-manager-aws-tests-ext/vendor/github.com/aws/aws-sdk-go-v2/service/ec2/api_op_ApplySecurityGroupsToClientVpnTargetNetwork.gois excluded by!**/vendor/**cmd/cloud-controller-manager-aws-tests-ext/vendor/github.com/aws/aws-sdk-go-v2/service/ec2/api_op_AssignIpv6Addresses.gois excluded by!**/vendor/**cmd/cloud-controller-manager-aws-tests-ext/vendor/github.com/aws/aws-sdk-go-v2/service/ec2/api_op_AssignPrivateIpAddresses.gois excluded by!**/vendor/**cmd/cloud-controller-manager-aws-tests-ext/vendor/github.com/aws/aws-sdk-go-v2/service/ec2/api_op_AssignPrivateNatGatewayAddress.gois excluded by!**/vendor/**cmd/cloud-controller-manager-aws-tests-ext/vendor/github.com/aws/aws-sdk-go-v2/service/ec2/api_op_AssociateAddress.gois excluded by!**/vendor/**cmd/cloud-controller-manager-aws-tests-ext/vendor/github.com/aws/aws-sdk-go-v2/service/ec2/api_op_AssociateCapacityReservationBillingOwner.gois excluded by!**/vendor/**cmd/cloud-controller-manager-aws-tests-ext/vendor/github.com/aws/aws-sdk-go-v2/service/ec2/api_op_AssociateClientVpnTargetNetwork.gois excluded by!**/vendor/**cmd/cloud-controller-manager-aws-tests-ext/vendor/github.com/aws/aws-sdk-go-v2/service/ec2/api_op_AssociateDhcpOptions.gois excluded by!**/vendor/**cmd/cloud-controller-manager-aws-tests-ext/vendor/github.com/aws/aws-sdk-go-v2/service/ec2/api_op_AssociateEnclaveCertificateIamRole.gois excluded by!**/vendor/**cmd/cloud-controller-manager-aws-tests-ext/vendor/github.com/aws/aws-sdk-go-v2/service/ec2/api_op_AssociateIamInstanceProfile.gois excluded by!**/vendor/**cmd/cloud-controller-manager-aws-tests-ext/vendor/github.com/aws/aws-sdk-go-v2/service/ec2/api_op_AssociateInstanceEventWindow.gois excluded by!**/vendor/**cmd/cloud-controller-manager-aws-tests-ext/vendor/github.com/aws/aws-sdk-go-v2/service/ec2/api_op_AssociateIpamByoasn.gois excluded by!**/vendor/**cmd/cloud-controller-manager-aws-tests-ext/vendor/github.com/aws/aws-sdk-go-v2/service/ec2/api_op_AssociateIpamResourceDiscovery.gois excluded by!**/vendor/**
📒 Files selected for processing (7)
.dockerignoreDockerfileMakefilecmd/cloud-controller-manager-aws-tests-ext/e2e/helper.gocmd/cloud-controller-manager-aws-tests-ext/e2e/loadbalancer.gocmd/cloud-controller-manager-aws-tests-ext/go.modcmd/cloud-controller-manager-aws-tests-ext/main.go
🚧 Files skipped from review as they are similar to previous changes (4)
- Dockerfile
- .dockerignore
- cmd/cloud-controller-manager-aws-tests-ext/e2e/helper.go
- cmd/cloud-controller-manager-aws-tests-ext/go.mod
Contributor
Author
I am reviewing CodeRabbit suggestions to apply here too. |
Contributor
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Blocks:
Must pass testing with PRs*:
*must be tested after CCM rebased PR: