Skip to content

LOG-7892: support format parameter for http sink#3074

Merged
openshift-merge-bot[bot] merged 1 commit intoopenshift:masterfrom
AndrewChubatiuk:http-framing
Feb 12, 2026
Merged

LOG-7892: support format parameter for http sink#3074
openshift-merge-bot[bot] merged 1 commit intoopenshift:masterfrom
AndrewChubatiuk:http-framing

Conversation

@AndrewChubatiuk
Copy link
Copy Markdown
Contributor

@AndrewChubatiuk AndrewChubatiuk commented Jul 2, 2025 •
edited
Loading

Description

NDJSON (newline-delimited JSON) allows to send log events in a streaming fashion which results in a smaller memory footprint on a receiver side. Added format argument for HTTP sink, that accepts json and ndjson values to support NDJSON data ingestion

/cc @Clee2691 @cahartma @jcantrill
/assign @jcantrill

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jul 2, 2025
@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented Jul 2, 2025

@AndrewChubatiuk: This pull request explicitly references no jira issue.

Details

In response to this:

Description

NDJSON (newline-delimited JSON) allows to send log events in a streaming fashion which results in a smaller memory footprint on a receiver side. Added line_per_event boolean argument for HTTP sink, which enables log events framing separating events with a newline

/cc @Clee2691 @cahartma
/assign @cahartma

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci Bot requested review from Clee2691 and cahartma July 2, 2025 10:37
@openshift-ci openshift-ci Bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jul 2, 2025
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Jul 2, 2025

Hi @AndrewChubatiuk. Thanks for your PR.

I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@vrutkovs
Copy link
Copy Markdown

vrutkovs commented Jul 2, 2025

/ok-to-test

@openshift-ci openshift-ci Bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jul 2, 2025
@jcantrill
Copy link
Copy Markdown
Contributor

jcantrill commented Jul 7, 2025

/hold

@openshift-ci openshift-ci Bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 7, 2025
@AndrewChubatiuk AndrewChubatiuk force-pushed the http-framing branch 3 times, most recently from 51ccd76 to 2e5417c Compare September 25, 2025 20:01
@AndrewChubatiuk AndrewChubatiuk force-pushed the http-framing branch 2 times, most recently from 85b5c6b to fdc25c0 Compare October 14, 2025 10:05
@jcantrill
Copy link
Copy Markdown
Contributor

jcantrill commented Oct 15, 2025

@AndrewChubatiuk are you still interested in submitting this contribution? If so, we'll need to create a tracking issue and review the API

@AndrewChubatiuk
Copy link
Copy Markdown
Contributor Author

AndrewChubatiuk commented Oct 15, 2025 •
edited
Loading

are you still interested in submitting this contribution? If so, we'll need to create a tracking issue and review the API

yes, interested in this as well

@vrutkovs
Copy link
Copy Markdown

vrutkovs commented Oct 16, 2025 •
edited by openshift-ci Bot
Loading

/retitle LOG-7892: support NDJSON for http sink

@openshift-ci openshift-ci Bot changed the title NO-JIRA: support NDJSON for http sink LOG-7892: support NDJSON for http sink Oct 16, 2025
@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented Oct 16, 2025 •
edited by openshift-ci Bot
Loading

@AndrewChubatiuk: This pull request references LOG-7892 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.8.0" version, but no target version was set.

Details

In response to this:

Description

NDJSON (newline-delimited JSON) allows to send log events in a streaming fashion which results in a smaller memory footprint on a receiver side. Added line_per_event boolean argument for HTTP sink, which enables NDJSON format for HTTP sink events

rebased it against #3073
since both PR share same functional tests code

/cc @Clee2691 @cahartma
/assign @cahartma

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@AndrewChubatiuk AndrewChubatiuk force-pushed the http-framing branch 3 times, most recently from 8d8aa0f to d81fe1f Compare October 17, 2025 04:41
@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented Nov 13, 2025 •
edited by openshift-ci Bot
Loading

@AndrewChubatiuk: This pull request references LOG-7892 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.8.0" version, but no target version was set.

Details

In response to this:

Description

NDJSON (newline-delimited JSON) allows to send log events in a streaming fashion which results in a smaller memory footprint on a receiver side. Added line_per_event boolean argument for HTTP sink, which enables NDJSON format for HTTP sink events

rebased it against #3073
since both PR share same functional tests code

/cc @Clee2691 @cahartma @jcantrill

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented Nov 18, 2025 •
edited by openshift-ci Bot
Loading

@AndrewChubatiuk: This pull request references LOG-7892 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.8.0" version, but no target version was set.

Details

In response to this:

Description

NDJSON (newline-delimited JSON) allows to send log events in a streaming fashion which results in a smaller memory footprint on a receiver side. Added line_per_event boolean argument for HTTP sink, which enables NDJSON format for HTTP sink events

rebased it against #3073
since both PR share same functional tests code

/cc @Clee2691 @cahartma @jcantrill
/assign @jcantrill

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 3, 2026
@AndrewChubatiuk AndrewChubatiuk force-pushed the http-framing branch 2 times, most recently from 0749e6f to a83ccfa Compare February 3, 2026 20:24
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 3, 2026
@AndrewChubatiuk
Copy link
Copy Markdown
Contributor Author

AndrewChubatiuk commented Feb 4, 2026

/test images

@AndrewChubatiuk
Copy link
Copy Markdown
Contributor Author

AndrewChubatiuk commented Feb 4, 2026

/retest

@jcantrill
Copy link
Copy Markdown
Contributor

jcantrill commented Feb 6, 2026

/hold cancel

@openshift-ci openshift-ci Bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 6, 2026
@jcantrill
Copy link
Copy Markdown
Contributor

jcantrill commented Feb 6, 2026

/approve
/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Feb 6, 2026
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Feb 6, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: AndrewChubatiuk, jcantrill

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 6, 2026
@AndrewChubatiuk
Copy link
Copy Markdown
Contributor Author

AndrewChubatiuk commented Feb 6, 2026

/retest

@jcantrill
Copy link
Copy Markdown
Contributor

jcantrill commented Feb 6, 2026

/test functional-target

@AndrewChubatiuk
Copy link
Copy Markdown
Contributor Author

AndrewChubatiuk commented Feb 7, 2026

/retest

@openshift-ci openshift-ci Bot removed the lgtm Indicates that a PR is ready to be merged. label Feb 7, 2026
@AndrewChubatiuk
Copy link
Copy Markdown
Contributor Author

AndrewChubatiuk commented Feb 9, 2026

/retest

1 similar comment
@jcantrill
Copy link
Copy Markdown
Contributor

jcantrill commented Feb 12, 2026

/retest

@jcantrill
Copy link
Copy Markdown
Contributor

jcantrill commented Feb 12, 2026

/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Feb 12, 2026
@AndrewChubatiuk
Copy link
Copy Markdown
Contributor Author

AndrewChubatiuk commented Feb 12, 2026

/retest

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Feb 12, 2026

@AndrewChubatiuk: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot Bot merged commit 0ad01ba into openshift:master Feb 12, 2026
7 checks passed
@AndrewChubatiuk AndrewChubatiuk deleted the http-framing branch February 13, 2026 04:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jcantrill jcantrill jcantrill requested changes

@cahartma cahartma Awaiting requested review from cahartma

@Clee2691 Clee2691 Awaiting requested review from Clee2691

+1 more reviewer

@alanconway alanconway alanconway left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@jcantrill jcantrill

@cahartma cahartma

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release/6.5

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@AndrewChubatiuk @openshift-ci-robot @vrutkovs @jcantrill @alanconway @openshift-merge-robot @cahartma