Skip to content

CORS-4332: Add GCP to the allowed platforms for dual stack#2894

Open
barbacbd wants to merge 1 commit intoopenshift:masterfrom
barbacbd:CORS-4332
Open

CORS-4332: Add GCP to the allowed platforms for dual stack#2894
barbacbd wants to merge 1 commit intoopenshift:masterfrom
barbacbd:CORS-4332

Conversation

@barbacbd
Copy link

Added GCP as a platform that supports DualStack on Day-0
Added GCP as a platform that does not support conversion to DualStack on Day-2
Added tests for GCP

** GCP is behind a featuregate. Ensure that these featuregates are enablede before dual stack support is extended to GCP.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jan 28, 2026
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jan 28, 2026

@barbacbd: This pull request references CORS-4332 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.22.0" version, but no target version was set.

Details

In response to this:

Added GCP as a platform that supports DualStack on Day-0
Added GCP as a platform that does not support conversion to DualStack on Day-2
Added tests for GCP

** GCP is behind a featuregate. Ensure that these featuregates are enablede before dual stack support is extended to GCP.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@barbacbd
Copy link
Author

/hold

@coderabbitai
Copy link

coderabbitai bot commented Jan 28, 2026

Walkthrough

Adds GCP to dual‑stack gating and updates tests: render logic now treats GCP as a platform that can support dual‑stack when the GCP dual‑stack feature gate is enabled; tests updated to drive dual‑stack behavior via feature gates and to adjust platform setups/status checks.

Changes

Cohort / File(s) Summary
Platform support logic
pkg/network/render.go
Extend isSupportedDualStackPlatform to include configv1.GCPPlatformType and gate it with apifeatures.FeatureGateGCPDualStackInstall; update comment to mention GCP alongside AWS and Azure.
Cluster config tests
pkg/network/cluster_config_test.go
Update tests to reflect feature‑gate driven dual‑stack behavior: add apifeatures.FeatureGateGCPDualStackInstall to dual‑stack feature sets and adjust platform/status setups so dual‑stack is allowed only when the feature gate is present.
Render tests
pkg/network/render_test.go
Add apifeatures.FeatureGateGCPDualStackInstall to default dual‑stack feature gates and set infra.PlatformType to configv1.GCPPlatformType in TestAllowMigrationOnlyForSupportedTypes to validate GCP path.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

No actionable comments were generated in the recent review. 🎉

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 golangci-lint (2.5.0)

level=error msg="Running error: context loading failed: failed to load packages: failed to load packages: failed to load with go/packages: err: exit status 1: stderr: go: inconsistent vendoring in :\n\tgithub.com/Masterminds/semver@v1.5.0: is explicitly required in go.mod, but not marked as explicit in vendor/modules.txt\n\tgithub.com/Masterminds/sprig/v3@v3.2.3: is explicitly required in go.mod, but not marked as explicit in vendor/modules.txt\n\tgithub.com/containernetworking/cni@v0.8.0: is explicitly required in go.mod, but not marked as explicit in vendor/modules.txt\n\tgithub.com/ghodss/yaml@v1.0.1-0.20190212211648-25d852aebe32: is explicitly required in go.mod, but not marked as explicit in vendor/modules.txt\n\tgithub.com/go-bindata/go-bindata@v3.1.2+incompatible: is explicitly required in go.mod, but not marked as explicit in vendor/modules.txt\n\tgithub.com/onsi/gomega@v1.38.1: is explicitly required in go.mod, but not marked as explicit in vendor/modules.txt\n\tgithub.com/ope

... [truncated 17231 characters] ...

ired in go.mod, but not marked as explicit in vendor/modules.txt\n\tk8s.io/gengo/v2@v2.0.0-20250922181213-ec3ebc5fd46b: is explicitly required in go.mod, but not marked as explicit in vendor/modules.txt\n\tk8s.io/kms@v0.34.1: is explicitly required in go.mod, but not marked as explicit in vendor/modules.txt\n\tk8s.io/kube-aggregator@v0.34.1: is explicitly required in go.mod, but not marked as explicit in vendor/modules.txt\n\tsigs.k8s.io/randfill@v1.0.0: is explicitly required in go.mod, but not marked as explicit in vendor/modules.txt\n\tsigs.k8s.io/structured-merge-diff/v6@v6.3.0: is explicitly required in go.mod, but not marked as explicit in vendor/modules.txt\n\n\tTo ignore the vendor directory, use -mod=readonly or -mod=mod.\n\tTo sync the vendor directory, run:\n\t\tgo mod vendor\n"

Tip

Issue Planner is now in beta. Read the docs and try it out! Share your feedback on Discord.


Comment @coderabbitai help to get the list of available commands and usage tips.

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 28, 2026
@openshift-ci openshift-ci bot requested review from jcaamano and ricky-rav January 28, 2026 15:46
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 28, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: barbacbd
Once this PR has been reviewed and has the lgtm label, please assign knobunc for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@barbacbd barbacbd force-pushed the CORS-4332 branch 2 times, most recently from cc60608 to e7e4777 Compare January 30, 2026 15:55
Added GCP as a platform that supports DualStack on Day-0
Added GCP as a platform that does not support conversion to DualStack on Day-2
Added tests for GCP

** GCP is behind a featuregate. Ensure that these featuregates are enablede before
dual stack support is extended to GCP.
@barbacbd
Copy link
Author

/retest-required

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 12, 2026

@barbacbd: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/4.22-upgrade-from-stable-4.21-e2e-azure-ovn-upgrade f3cc867 link false /test 4.22-upgrade-from-stable-4.21-e2e-azure-ovn-upgrade
ci/prow/security f3cc867 link false /test security
ci/prow/hypershift-e2e-aks f3cc867 link true /test hypershift-e2e-aks

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants