MON-4509: Migrate Prometheus targets discovering from Endpoints to EndpointSlices

[machine424]

This PR migrates Prometheus service discovery from the deprecated Endpoints API to the EndpointSlices API, by:

• Setting serviceDiscoveryRole: EndpointSlice on ServiceMonitors.
• Granting Prometheus endpointslices permissions.

We're taking a conservative approach by keeping the existing endpoints permissions alongside the new endpointslices ones. This provides a safety net in case any ServiceMonitors, whether deployed from this repo or from another source, still rely on the same Role and were missed during the migration.

That said, since both resources provide essentially the same data, keeping both isn't meaningfully more permissive from a security standpoint.

These changes target OpenShift 4.22+ and should not be backported to earlier releases.

Due to the scope of changes across multiple repositories, these modifications were generated with Claude assistance.

[openshift-ci]

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

[openshift-ci-robot]

@machine424: This pull request references MON-4509 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.22.0" version, but no target version was set.

Details

In response to this:

This PR migrates Prometheus service discovery from the deprecated Endpoints API to the EndpointSlices API, by:

• Setting serviceDiscoveryRole: EndpointSlice on ServiceMonitors.
• Granting Prometheus endpointslices permissions.

We're taking a conservative approach by keeping the existing endpoints permissions alongside the new endpointslices ones. This provides a safety net in case any ServiceMonitors, whether deployed from this repo or from another source, still rely on the same Role and were missed during the migration.

That said, since both resources provide essentially the same data, keeping both isn't meaningfully more permissive from a security standpoint.

These changes target OpenShift 4.22+ and should not be backported to earlier releases.

Due to the scope of changes across multiple repositories, these modifications were generated with Claude assistance.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[machine424]

/retest-required

[machine424]

/verified by existing tests
/jira refresh

[openshift-ci-robot]

@machine424: This PR has been marked as verified by existing tests.

Details

In response to this:

/verified by existing tests
/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci-robot]

@machine424: This pull request references MON-4509 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.22.0" version, but no target version was set.

Details

In response to this:

/verified by existing tests
/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[dfajmon]

/lgtm
/approved

Adding a document for future proofing
https://github.com/openshift/prometheus-operator/blob/1056d8dfe7b4ab7fb9feb50069947f51287601d8/Documentation/platform/troubleshooting.md#L35

[dfajmon]

/approve

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dfajmon, machine424

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [dfajmon]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[jsafrane]

/retest-required

[mpatlasov]

/override ci/prow/hypershift-e2e-aks

The test doesn't give us any useful signals now, it is perma-failing these days. See also how it failed in:

• NO-JIRA: Add a comment to sync AWS EBS IAM role into HyperShift #676
• STOR-2884: Add service to generate a TLS cert for EFS operator csi-operator#522
• STOR-2758: Update rbac from provisioner rebase #674
• STOR-2770: Stop generating self-signed certificates #662

/test hypershift-aws-e2e-external

[openshift-ci]

@mpatlasov: Overrode contexts on behalf of mpatlasov: ci/prow/hypershift-e2e-aks

Details

In response to this:

/override ci/prow/hypershift-e2e-aks

The test doesn't give us any useful signals now, it is perma-failing these days. See also how it failed in:

• NO-JIRA: Add a comment to sync AWS EBS IAM role into HyperShift #676
• STOR-2884: Add service to generate a TLS cert for EFS operator csi-operator#522
• STOR-2758: Update rbac from provisioner rebase #674
• STOR-2770: Stop generating self-signed certificates #662

/test hypershift-aws-e2e-external

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[openshift-ci-robot]

/retest-required

Remaining retests: 0 against base HEAD ba77c76 and 2 for PR HEAD 973c12e in total

[mpatlasov]

/test hypershift-aws-e2e-external

[openshift-ci]

@machine424: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.