Skip to content

[release-4.19] OCPBUGS-81736: Migrate InstallPlan components table to PatternFly Table#16256

Open
rhamilto wants to merge 1 commit intoopenshift:release-4.19from
rhamilto:OCPBUGS-81736
Open

[release-4.19] OCPBUGS-81736: Migrate InstallPlan components table to PatternFly Table#16256
rhamilto wants to merge 1 commit intoopenshift:release-4.19from
rhamilto:OCPBUGS-81736

Conversation

@rhamilto
Copy link
Copy Markdown
Member

@rhamilto rhamilto commented Apr 6, 2026

Summary

Cherry-pick of the InstallPlan components table migration to PatternFly v6 Table components to the release-4.19 branch.

This PR:

  • Replaces HTML table markup with PatternFly Table components (PFTable, Thead, Tr, Th, Tbody, Td) in the InstallPlanPreview component
  • Replaces raw co-m-pane__body div wrapper with the proper PaneBody component for consistency
  • Resolves merge conflict by ensuring both PatternFly Table imports and classNames utility are included

Related Issues

  • OCPBUGS-78253

Test Plan

  • Verify InstallPlan preview page renders correctly
  • Verify table displays components with proper styling
  • Verify approve/deny actions work as expected
  • Verify no console errors

🤖 Generated with Claude Code

Replace HTML table markup with PatternFly Table components in the
InstallPlanPreview component. Also replace the raw co-m-pane__body div
wrapper with the proper PaneBody component for consistency.

Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Apr 6, 2026
@openshift-ci-robot
Copy link
Copy Markdown
Contributor

@rhamilto: This pull request references Jira Issue OCPBUGS-78253, which is invalid:

  • expected the bug to target either version "4.19." or "openshift-4.19.", but it targets "4.22.0" instead
  • expected the bug to be in one of the following states: NEW, ASSIGNED, POST, but it is Verified instead
  • expected Jira Issue OCPBUGS-78253 to depend on a bug targeting a version in 4.20.0, 4.20.z and in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

Summary

Cherry-pick of the InstallPlan components table migration to PatternFly v6 Table components to the release-4.19 branch.

This PR:

  • Replaces HTML table markup with PatternFly Table components (PFTable, Thead, Tr, Th, Tbody, Td) in the InstallPlanPreview component
  • Replaces raw co-m-pane__body div wrapper with the proper PaneBody component for consistency
  • Resolves merge conflict by ensuring both PatternFly Table imports and classNames utility are included

Related Issues

  • OCPBUGS-78253

Test Plan

  • Verify InstallPlan preview page renders correctly
  • Verify table displays components with proper styling
  • Verify approve/deny actions work as expected
  • Verify no console errors

🤖 Generated with Claude Code

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested review from TheRealJon and spadgett April 6, 2026 12:52
@openshift-ci openshift-ci bot added component/olm Related to OLM approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Apr 6, 2026
@rhamilto rhamilto changed the title OCPBUGS-78253: Migrate InstallPlan components table to PatternFly Table [release-4.19] OCPBUGS-78253: Migrate InstallPlan components table to PatternFly Table Apr 6, 2026
@rhamilto rhamilto changed the title [release-4.19] OCPBUGS-78253: Migrate InstallPlan components table to PatternFly Table [release-4.19] OCPBUGS-81736: Migrate InstallPlan components table to PatternFly Table Apr 6, 2026
@openshift-ci-robot
Copy link
Copy Markdown
Contributor

@rhamilto: This pull request references Jira Issue OCPBUGS-81736, which is invalid:

  • expected dependent Jira Issue OCPBUGS-81322 to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but it is ON_QA instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

Summary

Cherry-pick of the InstallPlan components table migration to PatternFly v6 Table components to the release-4.19 branch.

This PR:

  • Replaces HTML table markup with PatternFly Table components (PFTable, Thead, Tr, Th, Tbody, Td) in the InstallPlanPreview component
  • Replaces raw co-m-pane__body div wrapper with the proper PaneBody component for consistency
  • Resolves merge conflict by ensuring both PatternFly Table imports and classNames utility are included

Related Issues

  • OCPBUGS-78253

Test Plan

  • Verify InstallPlan preview page renders correctly
  • Verify table displays components with proper styling
  • Verify approve/deny actions work as expected
  • Verify no console errors

🤖 Generated with Claude Code

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@rhamilto
Copy link
Copy Markdown
Member Author

rhamilto commented Apr 6, 2026

/jira refresh
/approve
/label backport-risk-assessed

@openshift-ci openshift-ci bot added the backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. label Apr 6, 2026
@openshift-ci-robot
Copy link
Copy Markdown
Contributor

@rhamilto: This pull request references Jira Issue OCPBUGS-81736, which is invalid:

  • expected dependent Jira Issue OCPBUGS-81322 to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but it is ON_QA instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

/jira refresh
/approve
/label backport-risk-assessed

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Apr 6, 2026

Important

Review skipped

Auto reviews are limited based on label configuration.

🚫 Review skipped — only excluded labels are configured. (1)
  • do-not-merge/work-in-progress

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 14c1b106-997b-4092-9adb-d76570c5ed21

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands and usage tips.

@sg00dwin
Copy link
Copy Markdown
Member

sg00dwin commented Apr 6, 2026

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Apr 6, 2026
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci bot commented Apr 6, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rhamilto, sg00dwin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci bot commented Apr 6, 2026

@rhamilto: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@rhamilto
Copy link
Copy Markdown
Member Author

rhamilto commented Apr 7, 2026

/jira refresh

@openshift-ci-robot
Copy link
Copy Markdown
Contributor

@rhamilto: This pull request references Jira Issue OCPBUGS-81736, which is invalid:

  • expected dependent Jira Issue OCPBUGS-81322 to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but it is ON_QA instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. component/olm Related to OLM jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants