Skip to content

[release-4.19] OCPBUGS-81738: Fix editing secrets with mixed text and binary data#16257

Open
openshift-cherrypick-robot wants to merge 1 commit intoopenshift:release-4.19from
openshift-cherrypick-robot:cherry-pick-16132-to-release-4.19
Open

[release-4.19] OCPBUGS-81738: Fix editing secrets with mixed text and binary data#16257
openshift-cherrypick-robot wants to merge 1 commit intoopenshift:release-4.19from
openshift-cherrypick-robot:cherry-pick-16132-to-release-4.19

Conversation

@openshift-cherrypick-robot
Copy link
Copy Markdown

@openshift-cherrypick-robot openshift-cherrypick-robot commented Apr 6, 2026

This is an automated cherry-pick of #16132

/assign TheRealJon

@TheRealJon @claude
Fix editing secrets with mixed text and binary data (OCPBUGS-62611)
848885b 
When a secret contained both text and binary values, the edit form would
fail due to a runtime error. The stringData initialization was returning
null when any binary field was detected, breaking text field handling.

Now binary fields are skipped during stringData initialization while text
fields are preserved, allowing proper editing of mixed-type secrets.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>
@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Apr 6, 2026
Merged
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Apr 6, 2026 •
edited
Loading

Important

Review skipped

Auto reviews are limited based on label configuration.

🚫 Review skipped — only excluded labels are configured. (1)
  • do-not-merge/work-in-progress

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 75561ec1-6a43-4e23-a53c-9b007b7320cf

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands and usage tips.

@openshift-ci openshift-ci bot requested review from jhadvig and spadgett April 6, 2026 13:19
@openshift-ci openshift-ci bot added the component/core Related to console core functionality label Apr 6, 2026
@openshift-ci-robot
Copy link
Copy Markdown
Contributor

openshift-ci-robot commented Apr 6, 2026

@openshift-cherrypick-robot: Jira Issue OCPBUGS-78295 has been cloned as Jira Issue OCPBUGS-81738. Will retitle bug to link to clone.
/retitle [release-4.19] OCPBUGS-81738: Fix editing secrets with mixed text and binary data

Details

In response to this:

This is an automated cherry-pick of #16132

/assign TheRealJon

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot changed the title [release-4.19] OCPBUGS-78295: Fix editing secrets with mixed text and binary data [release-4.19] OCPBUGS-81738: Fix editing secrets with mixed text and binary data Apr 6, 2026
@openshift-ci-robot openshift-ci-robot added jira/severity-moderate Referenced Jira bug's severity is moderate for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Apr 6, 2026
@openshift-ci-robot
Copy link
Copy Markdown
Contributor

openshift-ci-robot commented Apr 6, 2026

@openshift-cherrypick-robot: This pull request references Jira Issue OCPBUGS-81738, which is invalid:

  • expected dependent Jira Issue OCPBUGS-78295 to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but it is ON_QA instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

This is an automated cherry-pick of #16132

/assign TheRealJon

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@TheRealJon
Copy link
Copy Markdown
Member

TheRealJon commented Apr 6, 2026

/label backport-risk-assessed
/lgtm

@openshift-ci openshift-ci bot added the backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. label Apr 6, 2026
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Apr 6, 2026
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci bot commented Apr 6, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: openshift-cherrypick-robot, TheRealJon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 6, 2026
@TheRealJon
Copy link
Copy Markdown
Member

TheRealJon commented Apr 6, 2026

/retest

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci bot commented Apr 6, 2026

@openshift-cherrypick-robot: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jhadvig jhadvig Awaiting requested review from jhadvig

@spadgett spadgett Awaiting requested review from spadgett

Assignees

@yanpzhan yanpzhan

@sanketpathak sanketpathak

@yapei yapei

@TheRealJon TheRealJon

@XiyunZhao XiyunZhao

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. component/core Related to console core functionality jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. jira/severity-moderate Referenced Jira bug's severity is moderate for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@openshift-cherrypick-robot @openshift-ci-robot @TheRealJon @yanpzhan @sanketpathak @yapei @XiyunZhao