Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -20,9 +20,9 @@ import {
} from '@console/internal/components/utils';
import { VolumeSnapshotClassModel, VolumeSnapshotModel } from '@console/internal/models';
import { referenceForModel, VolumeSnapshotContentKind } from '@console/internal/module/k8s';
import { Status } from '@console/shared';
import PaneBody from '@console/shared/src/components/layout/PaneBody';
import { volumeSnapshotStatus } from '../../status';
import { Status } from '@console/shared/src/components/status/Status';
import { snapshotStatus } from '@console/shared/src/sorts/snapshot';

const { editYaml, events } = navFactory;

Expand All @@ -43,7 +43,7 @@ const Details: React.FC<DetailsProps> = ({ obj }) => {
<DescriptionListGroup>
<DescriptionListTerm>{t('console-app~Status')}</DescriptionListTerm>
<DescriptionListDescription>
<Status status={volumeSnapshotStatus(obj)} />
<Status status={snapshotStatus(obj)} />
</DescriptionListDescription>
</DescriptionListGroup>
</ResourceSummary>
Expand Down Expand Up @@ -116,7 +116,7 @@ const VolumeSnapshotContentDetailsPage: React.FC<DetailsPageProps> = (props) =>
return (
<DetailsPage
{...props}
getResourceStatus={volumeSnapshotStatus}
getResourceStatus={snapshotStatus}
menuActions={Kebab.factory.common}
pages={pages}
/>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ import {
TableColumn,
RowProps,
} from '@console/dynamic-plugin-sdk/src/lib-core';
import { TableData } from '@console/internal/components/factory';
import { sorts, TableData } from '@console/internal/components/factory';
import { useActiveColumns } from '@console/internal/components/factory/Table/active-columns-hook';
import {
ResourceLink,
Expand All @@ -28,9 +28,10 @@ import {
VolumeSnapshotContentModel,
} from '@console/internal/models';
import { referenceForModel, VolumeSnapshotContentKind } from '@console/internal/module/k8s';
import { Status } from '@console/shared';
import { snapshotStatus, Status } from '@console/shared';
import { Timestamp } from '@console/shared/src/components/datetime/Timestamp';
import { snapshotStatusFilters, volumeSnapshotStatus } from '../../status';
import { snapshotStatusFilters } from '../../status';
import { sortResourceByValue } from '@console/internal/components/factory/Table/sort';

export const tableColumnInfo = [
{ id: 'name' },
Expand All @@ -54,7 +55,7 @@ const Row: React.FC<RowProps<VolumeSnapshotContentKind>> = ({ obj }) => {
<ResourceLink kind={referenceForModel(VolumeSnapshotContentModel)} name={name} />
</TableData>
<TableData {...tableColumnInfo[1]}>
<Status status={volumeSnapshotStatus(obj)} />
<Status status={snapshotStatus(obj)} />
</TableData>
<TableData {...tableColumnInfo[2]}>{sizeMetrics}</TableData>
<TableData {...tableColumnInfo[3]}>
Expand Down Expand Up @@ -95,14 +96,16 @@ const VolumeSnapshotContentTable: React.FC<VolumeSnapshotContentTableProps> = (p
},
{
title: t('console-app~Status'),
sort: 'snapshotStatus',
sort: (data, direction) =>
data.sort(sortResourceByValue(direction, sorts.volumeSnapshotStatus)),
transforms: [sortable],
props: { className: tableColumnInfo[1].className },
id: tableColumnInfo[1].id,
},
{
title: t('console-app~Size'),
sort: 'volumeSnapshotSize',
sort: (data, direction) =>
data.sort(sortResourceByValue(direction, sorts.volumeSnapshotContentSize)),
transforms: [sortable],
props: { className: tableColumnInfo[2].className },
id: tableColumnInfo[2].id,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -31,10 +31,10 @@ import {
Status,
snapshotSource,
FLAGS,
snapshotStatus,
} from '@console/shared';
import PaneBody from '@console/shared/src/components/layout/PaneBody';
import { useFlag } from '@console/shared/src/hooks/flag';
import { volumeSnapshotStatus } from '../../status';

const { editYaml, events } = navFactory;

Expand Down Expand Up @@ -62,7 +62,7 @@ const Details: React.FC<DetailsProps> = ({ obj }) => {
<DescriptionListGroup>
<DescriptionListTerm>{t('console-app~Status')}</DescriptionListTerm>
<DescriptionListDescription>
<Status status={volumeSnapshotStatus(obj)} />
<Status status={snapshotStatus(obj)} />
</DescriptionListDescription>
</DescriptionListGroup>
</ResourceSummary>
Expand Down Expand Up @@ -146,7 +146,7 @@ const VolumeSnapshotDetailsPage: React.FC<DetailsPageProps> = (props) => {
<DetailsPage
{...props}
customActionMenu={customActionMenu}
getResourceStatus={volumeSnapshotStatus}
getResourceStatus={snapshotStatus}
pages={pages}
/>
);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ import {
TableColumn,
RowProps,
} from '@console/dynamic-plugin-sdk/src/lib-core';
import { TableData } from '@console/internal/components/factory';
import { sorts, TableData } from '@console/internal/components/factory';
import { useActiveColumns } from '@console/internal/components/factory/Table/active-columns-hook';
import {
ResourceLink,
Expand Down Expand Up @@ -45,10 +45,12 @@ import {
getNamespace,
snapshotSource,
FLAGS,
snapshotStatus,
} from '@console/shared';
import { Timestamp } from '@console/shared/src/components/datetime/Timestamp';
import { useFlag } from '@console/shared/src/hooks/flag';
import { snapshotStatusFilters, volumeSnapshotStatus } from '../../status';
import { snapshotStatusFilters } from '../../status';
import { sortResourceByValue } from '@console/internal/components/factory/Table/sort';

const tableColumnInfo = [
{ id: 'name' },
Expand Down Expand Up @@ -78,21 +80,24 @@ const getTableColumns = (t: TFunction, disableItems = {}): TableColumn<VolumeSna
},
{
title: t('console-app~Status'),
sort: 'snapshotStatus',
sort: (data, direction) =>
data.sort(sortResourceByValue(direction, sorts.volumeSnapshotStatus)),
transforms: [sortable],
props: { className: tableColumnInfo[2].className },
id: tableColumnInfo[2].id,
},
{
title: t('console-app~Size'),
sort: 'volumeSnapshotSize',
sort: (data, direction) =>
data.sort(sortResourceByValue(direction, sorts.volumeSnapshotSize)),
transforms: [sortable],
props: { className: tableColumnInfo[3].className },
id: tableColumnInfo[3].id,
},
{
title: t('console-app~Source'),
sort: 'volumeSnapshotSource',
sort: (data, direction) =>
data.sort(sortResourceByValue(direction, sorts.volumeSnapshotSource)),
transforms: [sortable],
props: { className: tableColumnInfo[4].className },
id: tableColumnInfo[4].id,
Expand Down Expand Up @@ -154,7 +159,7 @@ const Row: React.FC<RowProps<VolumeSnapshotKind, VolumeSnapshotRowProsCustomData
<ResourceLink kind={NamespaceModel.kind} name={namespace} />
</TableData>
<TableData {...tableColumnInfo[2]}>
<Status status={volumeSnapshotStatus(obj)} />
<Status status={snapshotStatus(obj)} />
</TableData>
<TableData {...tableColumnInfo[3]}>{sizeMetrics}</TableData>
{!customData?.disableItems?.Source && (
Expand Down
14 changes: 4 additions & 10 deletions frontend/packages/console-app/src/status/snapshot.ts
Original file line number Diff line number Diff line change
@@ -1,19 +1,13 @@
import { TFunction } from 'i18next';
import { RowFilter } from '@console/dynamic-plugin-sdk/src/extensions/console-types';
import { VolumeSnapshotStatus } from '@console/internal/module/k8s';

export const volumeSnapshotStatus = ({ status }: { status?: VolumeSnapshotStatus }) => {
const readyToUse = status?.readyToUse;
const isError = !!status?.error?.message;
return readyToUse ? 'Ready' : isError ? 'Error' : 'Pending';
};
import type { TFunction } from 'i18next';
import type { RowFilter } from '@console/dynamic-plugin-sdk/src/extensions/console-types';
import { snapshotStatus } from '@console/shared/src/sorts/snapshot';

export const snapshotStatusFilters = (t: TFunction): RowFilter[] => {
return [
{
filterGroupName: t('console-app~Status'),
type: 'snapshot-status',
reducer: volumeSnapshotStatus,
reducer: snapshotStatus,
filter: () => null,
items: [
{ id: 'Ready', title: 'Ready' },
Expand Down
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
import { nodeStatus } from '@console/app/src/status/node';
import { volumeSnapshotStatus } from '@console/app/src/status/snapshot';
import { podPhaseFilterReducer } from '@console/internal/module/k8s';
import { StatusGroupMapper } from './InventoryItem';
import { snapshotStatus } from '@console/shared/src/sorts/snapshot';
import type { StatusGroupMapper } from './InventoryItem';
import { InventoryStatusGroup } from './status-group';

const POD_PHASE_GROUP_MAPPING = {
Expand Down Expand Up @@ -69,4 +69,4 @@ export const getPVCStatusGroups: StatusGroupMapper = (resources) =>
export const getPVStatusGroups: StatusGroupMapper = (resources) =>
getStatusGroups(resources, PV_STATUS_GROUP_MAPPING, (pv) => pv.status.phase, 'pv-status');
export const getVSStatusGroups: StatusGroupMapper = (resources) =>
getStatusGroups(resources, VS_STATUS_GROUP_MAPPING, volumeSnapshotStatus, 'snapshot-status');
getStatusGroups(resources, VS_STATUS_GROUP_MAPPING, snapshotStatus, 'status');
18 changes: 16 additions & 2 deletions frontend/packages/console-shared/src/sorts/snapshot.ts
Original file line number Diff line number Diff line change
@@ -1,5 +1,15 @@
import { convertToBaseValue } from '@console/internal/components/utils';
import { VolumeSnapshotKind } from '@console/internal/module/k8s';
import { convertToBaseValue } from '@console/internal/components/utils/units';
import type {
VolumeSnapshotContentKind,
VolumeSnapshotKind,
VolumeSnapshotStatus,
} from '@console/internal/module/k8s';

export const snapshotStatus = ({ status }: { status?: VolumeSnapshotStatus }): string => {
const readyToUse = status?.readyToUse;
const isError = !!status?.error?.message;
return readyToUse ? 'Ready' : isError ? 'Error' : 'Pending';
};

export const snapshotSize = (snapshot: VolumeSnapshotKind): number => {
const size = snapshot?.status?.restoreSize;
Expand All @@ -9,3 +19,7 @@ export const snapshotSize = (snapshot: VolumeSnapshotKind): number => {
export const snapshotSource = (snapshot: VolumeSnapshotKind): string =>
snapshot.spec?.source?.persistentVolumeClaimName ??
snapshot.spec?.source?.volumeSnapshotContentName;

export const snapshotContentSize = (snapshot: VolumeSnapshotContentKind): number => {
return snapshot?.status?.restoreSize ?? 0;
};
4 changes: 2 additions & 2 deletions frontend/public/components/factory/table-filters.ts
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
import * as _ from 'lodash-es';
import * as fuzzy from 'fuzzysearch';
import { nodeStatus } from '@console/app/src/status/node';
import { volumeSnapshotStatus } from '@console/app/src/status/snapshot';
import { snapshotStatus } from '@console/shared/src/sorts/snapshot';
import { getNodeRoles } from '@console/shared/src/selectors/node';
import { getLabelsAsString } from '@console/shared/src/utils/label-filter';
import { Alert, Rule } from '@console/dynamic-plugin-sdk/src/api/common-types';
Expand Down Expand Up @@ -220,7 +220,7 @@ export const tableFilters = (isExactSearch: boolean): FilterMap => {
return true;
}

const status = volumeSnapshotStatus(snapshot);
const status = snapshotStatus(snapshot);
return statuses.selected.includes(status) || !_.includes(statuses.all, status);
},
'node-disk-name': (name, disks) => matchFn(name.selected?.[0], disks?.path),
Expand Down
14 changes: 12 additions & 2 deletions frontend/public/components/factory/table.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,12 @@ import { useNavigate } from 'react-router-dom-v5-compat';
import { getMachinePhase } from '@console/shared/src/selectors/machine';
import { getMachineSetInstanceType } from '@console/shared/src/selectors/machineSet';
import { pvcUsed } from '@console/shared/src/sorts/pvc';
import { snapshotSize, snapshotSource } from '@console/shared/src/sorts/snapshot';
import {
snapshotContentSize,
snapshotSize,
snapshotSource,
snapshotStatus,
} from '@console/shared/src/sorts/snapshot';
import { ALL_NAMESPACES_KEY } from '@console/shared/src/constants/common';
import { getName } from '@console/shared/src/selectors/common';
import { useDeepCompareMemoize } from '@console/shared/src/hooks/deep-compare-memoize';
Expand All @@ -46,6 +51,7 @@ import {
MachineKind,
VolumeSnapshotKind,
ClusterOperator,
VolumeSnapshotContentKind,
} from '../../module/k8s/types';
import { getClusterOperatorStatus } from '../../module/k8s/cluster-operator';
import { getClusterOperatorVersion, getJobTypeAndCompletions } from '../../module/k8s';
Expand All @@ -55,7 +61,7 @@ import { podPhase, podReadiness, podRestarts } from '../../module/k8s/pods';
import { useTableData } from './table-data-hook';
import TableHeader from './Table/TableHeader';

const sorts = {
export const sorts = {
alertingRuleStateOrder,
alertSeverityOrder,
crdLatestVersion: (crd: CustomResourceDefinitionKind): string => getLatestVersionForCRD(crd),
Expand All @@ -82,7 +88,11 @@ const sorts = {
getTemplateInstanceStatus,
machinePhase: (machine: MachineKind): string => getMachinePhase(machine),
pvcUsed: (pvc: K8sResourceKind): number => pvcUsed(pvc),
volumeSnapshotStatus: (snapshot: VolumeSnapshotKind | VolumeSnapshotContentKind): string =>
snapshotStatus(snapshot),
volumeSnapshotSize: (snapshot: VolumeSnapshotKind): number => snapshotSize(snapshot),
volumeSnapshotContentSize: (snapshot: VolumeSnapshotContentKind): number =>
snapshotContentSize(snapshot),
volumeSnapshotSource: (snapshot: VolumeSnapshotKind): string => snapshotSource(snapshot),
snapshotLastRestore: (snapshot: K8sResourceKind, { restores }) =>
restores[getName(snapshot)]?.status?.restoreTime,
Expand Down
3 changes: 2 additions & 1 deletion frontend/public/module/k8s/types.ts
Original file line number Diff line number Diff line change
Expand Up @@ -1078,6 +1078,7 @@ export type MachineHealthCheckKind = K8sResourceCommon & {
export type VolumeSnapshotKind = K8sResourceCommon & {
status?: VolumeSnapshotStatus & {
boundVolumeSnapshotContentName?: string;
restoreSize?: string;
};
spec: {
source: {
Expand All @@ -1091,6 +1092,7 @@ export type VolumeSnapshotKind = K8sResourceCommon & {
export type VolumeSnapshotContentKind = K8sResourceCommon & {
status: VolumeSnapshotStatus & {
snapshotHandle?: string;
restoreSize?: number;
};
spec: {
volumeSnapshotRef: {
Expand All @@ -1109,7 +1111,6 @@ export type VolumeSnapshotContentKind = K8sResourceCommon & {

export type VolumeSnapshotStatus = {
readyToUse: boolean;
restoreSize?: number;
error?: {
message: string;
time: string;
Expand Down