OCPBUGS-78694: backport: openstack: Disable LoadBalancer in cloud config when Octavia is unavailable

[eshulman2]

When Octavia (load-balancer) endpoint is not available in the OpenStack service catalog, explicitly set [LoadBalancer] enabled = false in the cloud provider config. This prevents the Cloud Controller Manager from crashing on startup due to an upstream change in cloud-provider-openstack that changed error handling from klog.Errorf to klog.Fatalf when the LoadBalancer client cannot be created.

The fix uses the same pattern already established in the cluster destroy code (pkg/destroy/openstack/openstack.go) to detect Octavia availability by checking for gophercloud.ErrEndpointNotFound.

Fixes: https://issues.redhat.com/browse/OCPBUGS-64842
backports #10326

[coderabbitai]

Important

Review skipped

Auto reviews are limited based on label configuration.

🚫 Review skipped — only excluded labels are configured. (1)

• do-not-merge/work-in-progress

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 41363556-747d-4148-88fe-324c64d06ff9

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

📝 Coding Plan

• Generate coding plan for human review comments

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[eshulman2]

/jira

[openshift-ci-robot]

@eshulman2: This pull request references Jira Issue OCPBUGS-78694, which is invalid:

• release note text must be set and not match the template OR release note type must be set to "Release Note Not Required". For more information you can reference the OpenShift Bug Process.
• expected Jira Issue OCPBUGS-78694 to depend on a bug targeting a version in 4.21.0, 4.21.z and in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

When Octavia (load-balancer) endpoint is not available in the OpenStack service catalog, explicitly set [LoadBalancer] enabled = false in the cloud provider config. This prevents the Cloud Controller Manager from crashing on startup due to an upstream change in cloud-provider-openstack that changed error handling from klog.Errorf to klog.Fatalf when the LoadBalancer client cannot be created.

The fix uses the same pattern already established in the cluster destroy code (pkg/destroy/openstack/openstack.go) to detect Octavia availability by checking for gophercloud.ErrEndpointNotFound.

Fixes: https://issues.redhat.com/browse/OCPBUGS-64842

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[eshulman2]

/jira refresh

[openshift-ci-robot]

@eshulman2: This pull request references Jira Issue OCPBUGS-78694, which is invalid:

• expected dependent Jira Issue OCPBUGS-78696 to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but it is POST instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[stephenfin]

/test e2e-openstack-ovn

[stephenfin]

/lgtm
/approve
/label backport-risk-assessed

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: stephenfin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• pkg/asset/manifests/openstack/OWNERS [stephenfin]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci]

@eshulman2: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-openstack-ovn	e99ff60	link	true	/test e2e-openstack-ovn

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.