AGENT-1458: Don't auto-calculate RendezvousIP in unconfigured-ignition

[pawanpinjarkar]

This reverts commit 9dc636f.

Background

Unconfigured-ignition is used in two scenarios:

1. OVE (OpenShift Virtualization) workflow

• User provides static network configs via nmstateconfig.yaml from SaaS UI
• User boots the ISO and gets a TUI where they can set/review rendezvousIP
• The TUI shows any pre-filled rendezvousIP with a timeout, allowing changes

2. Appliance workflow (config-iso)

• Network is configured via DHCP or through the config-iso later
• NMState data is typically not available at unconfigured-ignition time
• RendezvousIP comes from the config-iso

The Problem

The reverted commit tried to automatically pick rendezvousIP from NMState data if available. This doesn't work well for either use case:

• For OVE: We don't know which host should be the rendezvous node (hosts have no roles yet), so if we just pick the first IP (or ask user to select an IP from static networking) which might be wrong
• For Appliance: There's usually no NMState data anyway, so it doesn't help

The Fix

Don't automatically select rendezvousIP from NMState data. Let users explicitly provide it via agent-config.yaml or choose it in the SaaS UI/TUI.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: aff73986-e1e2-4054-a94a-3d0436210d88

📥 Commits

Reviewing files that changed from the base of the PR and between 1896803 and ca7338f.

📒 Files selected for processing (1)

• pkg/asset/agent/image/unconfigured_ignition.go

---

Walkthrough

Modified a single function call in unconfigured_ignition.go by changing the third argument passed to RetrieveRendezvousIP from nmStateConfigs.Config to nil, altering the source of rendezvous IP configuration data.

Changes

Cohort / File(s)	Summary
Rendezvous IP Configuration pkg/asset/agent/image/unconfigured_ignition.go	Changed third argument to RetrieveRendezvousIP from nmStateConfigs.Config to nil. No changes to surrounding logic or conditional handling.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

📝 Coding Plan

• Generate coding plan for human review comments

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 golangci-lint (2.11.3)

Error: can't load config: unsupported version of the configuration: "" See https://golangci-lint.run/docs/product/migration-guide for migration instructions
The command is terminated due to an error: can't load config: unsupported version of the configuration: "" See https://golangci-lint.run/docs/product/migration-guide for migration instructions

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[pawanpinjarkar]

/cc @zaneb @andfasano

[zaneb]

Reasoning for reverting makes sense to me. I consulted my notes and they don't reveal why I thought this was a good idea in the first place 🙂
/approve
/retitle AGENT-1458: Don't auto-calculate RendezvousIP in unconfigured-ignition

[openshift-ci-robot]

@pawanpinjarkar: This pull request references AGENT-1458 which is a valid jira issue.

Details

In response to this:

This reverts commit 9dc636f.

Background

Unconfigured-ignition is used in two scenarios:

1. OVE (OpenShift Virtualization) workflow

• User provides static network configs via nmstateconfig.yaml from SaaS UI
• User boots the ISO and gets a TUI where they can set/review rendezvousIP
• The TUI shows any pre-filled rendezvousIP with a timeout, allowing changes

2. Appliance workflow (config-iso)

• Network is configured via DHCP or through the config-iso later
• NMState data is typically not available at unconfigured-ignition time
• RendezvousIP comes from the config-iso

The Problem

The reverted commit tried to automatically pick rendezvousIP from NMState data if available. This doesn't work well for either use case:

• For OVE: We don't know which host should be the rendezvous node (hosts have no roles yet), so if we just pick the first IP (or ask user to select an IP from static networking) which might be wrong
• For Appliance: There's usually no NMState data anyway, so it doesn't help

The Fix

Don't automatically select rendezvousIP from NMState data. Let users explicitly provide it via agent-config.yaml or choose it in the SaaS UI/TUI.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: zaneb

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• pkg/asset/agent/OWNERS [zaneb]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[bfournie]

/lgtm

[pawanpinjarkar]

/verified later

[openshift-ci-robot]

@pawanpinjarkar: /verified later <@username> requires at least one GitHub @username to be specified (it can be a comma delimited list). It indicates the engineer(s) that will be performing the verification. See https://docs.ci.openshift.org/docs/architecture/jira/#premerge-verification for more information.

Details

In response to this:

/verified later

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[pawanpinjarkar]

/verified later @pawanpinjarkar Also, e2e-agent-compact-ipv4-appliance-diskimage verified the appliance use case.

[openshift-ci-robot]

@pawanpinjarkar: Only users can be targets for the /verified later command.

Details

In response to this:

/verified later @pawanpinjarkar Also, e2e-agent-compact-ipv4-appliance-diskimage verified the appliance use case.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[pawanpinjarkar]

/verified later @pawanpinjarkar

[openshift-ci-robot]

@pawanpinjarkar: This PR has been marked to be verified later by @pawanpinjarkar.

Details

In response to this:

/verified later @pawanpinjarkar

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[pawanpinjarkar]

/override ci/prow/okd-scos-images

[openshift-ci]

@pawanpinjarkar: Overrode contexts on behalf of pawanpinjarkar: ci/prow/okd-scos-images

Details

In response to this:

/override ci/prow/okd-scos-images

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[openshift-ci]

@pawanpinjarkar: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-agent-two-node-fencing-ipv4	ca7338f	link	false	/test e2e-agent-two-node-fencing-ipv4
ci/prow/e2e-agent-compact-ipv4-iso-no-registry	ca7338f	link	false	/test e2e-agent-compact-ipv4-iso-no-registry

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.