Skip to content

[WIP] use the default OS image from the OSImageStream#10406

Draft
cheesesashimi wants to merge 1 commit intoopenshift:mainfrom
cheesesashimi:zzlotnik/add-machine-config-osimagestream
Draft

[WIP] use the default OS image from the OSImageStream#10406
cheesesashimi wants to merge 1 commit intoopenshift:mainfrom
cheesesashimi:zzlotnik/add-machine-config-osimagestream

Conversation

@cheesesashimi
Copy link
Member

This uses the new machine-config-osimagestream helper binary to inspect the release payload and determine what the default OS image from a given payload should be. Doing this allows a release payload to ship with multiple OS images while avoiding the need to hardcode those image names.

Right now, this is still a work in progress and should not be reviewed / merged until after openshift/machine-config-operator#5770 has merged.

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 18, 2026
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 18, 2026

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@coderabbitai
Copy link

coderabbitai bot commented Mar 18, 2026

Important

Review skipped

Auto reviews are limited based on label configuration.

🚫 Review skipped — only excluded labels are configured. (1)
  • do-not-merge/work-in-progress

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 9e298490-5ddf-4820-9895-3b65216726d4

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 18, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign stephenfin for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@cheesesashimi cheesesashimi force-pushed the zzlotnik/add-machine-config-osimagestream branch from 58db82b to bc03ec7 Compare March 18, 2026 21:32
This uses the new `machine-config-osimagestream` helper binary to
inspect the release payload and determine what the default OS image for
a given payload should be. Doing this allows a release payload to ship
with multiple OS images while avoiding the need to hardcode those image
names.

Assisted-By: Claude Sonnet 4.5
@cheesesashimi cheesesashimi force-pushed the zzlotnik/add-machine-config-osimagestream branch from bc03ec7 to 9db4532 Compare March 18, 2026 21:57
@openshift-ci openshift-ci bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 21, 2026
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 21, 2026

PR needs rebase.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant