[release-4.18] OCPBUGS-78550: fix wavelength zone name regex

[tthvo]

This is a manual cherry-pick of #10391 due to git conflicts.

[coderabbitai]

Important

Review skipped

Auto reviews are limited based on label configuration.

🚫 Review skipped — only excluded labels are configured. (1)

• do-not-merge/work-in-progress

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: ad666ec2-ddfc-459f-b55b-c4ce090fc19a

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

📝 Coding Plan

• Generate coding plan for human review comments

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[openshift-ci-robot]

@tthvo: This pull request references Jira Issue OCPBUGS-77355, which is invalid:

• expected the bug to target either version "4.18." or "openshift-4.18.", but it targets "4.22.0" instead
• expected the bug to be in one of the following states: NEW, ASSIGNED, POST, but it is Verified instead
• expected Jira Issue OCPBUGS-77355 to depend on a bug targeting a version in 4.19.0, 4.19.z and in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

This is a manual cherry-pick of #10391 due to git conflicts.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[tthvo]

/retitle [release-4.18] OCPBUGS-78550: fix wavelength zone name regex

[openshift-ci-robot]

@tthvo: This pull request references Jira Issue OCPBUGS-78550, which is invalid:

• expected Jira Issue OCPBUGS-78550 to depend on a bug targeting a version in 4.19.0, 4.19.z and in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

This is a manual cherry-pick of #10391 due to git conflicts.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[tthvo]

/jira refresh

[openshift-ci-robot]

@tthvo: This pull request references Jira Issue OCPBUGS-78550, which is valid. The bug has been moved to the POST state.

7 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (4.18.z) matches configured target version for branch (4.18.z)
• bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)
• release note type set to "Release Note Not Required"
• dependent bug Jira Issue OCPBUGS-78496 is in the state Verified, which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA))
• dependent Jira Issue OCPBUGS-78496 targets the "4.19.z" version, which is one of the valid target versions: 4.19.0, 4.19.z
• bug has dependents

Requesting review from QA contact:
/cc @liweinan

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci]

@tthvo: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-aws-ovn-edge-zones	015d1ef	link	false	/test e2e-aws-ovn-edge-zones

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[patrickdillon]

/approve
/lgtm
/label backport-risk-assessed

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: patrickdillon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• pkg/asset/installconfig/aws/OWNERS [patrickdillon]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[liweinan]

I'll verify it today.

[liweinan]

OCPBUGS-78550 Verification Report: PR #10409 (4.18 Backport)

Test Date: 2026-03-19
Test Method: Unit Tests + Permissions Policy Generation
Result: ✅ PASSED

---

Test Environment

Installer Version:

$ ./bin/openshift-install version
./bin/openshift-install unreleased-master-11485-g015d1ef0cb80859dfa4c24a518b5bdb88b0b6704
built from commit 015d1ef0cb80859dfa4c24a518b5bdb88b0b6704
release image registry.ci.openshift.org/origin/release:4.18

Branch: OCPBUGS-78550

---

Test Procedure

1. Build Installer

git fetch origin pull/10409/head:pr-10409-4.18
git checkout pr-10409-4.18
SKIP_TERRAFORM=y hack/build.sh

✅ Build completed successfully

---

2. Run Unit Tests

$ go test -v ./pkg/asset/installconfig/aws -run TestIncludesWavelengthZones
=== RUN   TestIncludesWavelengthZones
=== RUN   TestIncludesWavelengthZones/Should_be_true_when_edge_compute_specified_with_WL_zones
=== RUN   TestIncludesWavelengthZones/Should_be_true_when_edge_compute_specified_with_WL_zones/with_common_wavelength_zone_format
=== RUN   TestIncludesWavelengthZones/Should_be_true_when_edge_compute_specified_with_WL_zones/with_irregular_wavelength_zone_format
=== RUN   TestIncludesWavelengthZones/Should_be_false_when
=== RUN   TestIncludesWavelengthZones/Should_be_false_when/edge_compute_specified_without_WL_zones
=== RUN   TestIncludesWavelengthZones/Should_be_false_when/edge_compute_not_specified
--- PASS: TestIncludesWavelengthZones (0.00s)
PASS
ok  	github.com/openshift/installer/pkg/asset/installconfig/aws	0.798s

✅ All unit tests passed

---

3. Generate Permissions Policy with New WL Zone Format

Install config (using new WL Zone format us-east-1-foe-wlz-1a):

compute:
- name: edge
  platform:
    aws:
      zones:
      - us-east-1-foe-wlz-1a  # New format

Command:

./bin/openshift-install create permissions-policy --dir /tmp/test-pr-10409/new-wlz

Output:

level=info msg=Credentials loaded from the "default" profile in file "/Users/weli/.aws/credentials"
level=info msg=Consuming Install Config from target directory
level=info msg=Permissions-Policy created in: /tmp/test-pr-10409/new-wlz

---

4. Verify Carrier Gateway Permissions

$ jq '.Statement[] | select(.Sid == "PermissionCreateCarrierGateway")' \
    /tmp/test-pr-10409/new-wlz/aws-permissions-policy-creds.json

Result:

{
  "Sid": "PermissionCreateCarrierGateway",
  "Effect": "Allow",
  "Action": [
    "ec2:DescribeCarrierGateways",
    "ec2:CreateCarrierGateway",
    "ec2:DeleteCarrierGateway"
  ],
  "Resource": [
    "*"
  ]
}

✅ Carrier Gateway permissions present in generated policy

$ jq '.Statement | length' /tmp/test-pr-10409/new-wlz/aws-permissions-policy-creds.json
12

---

5. Verify Backward Compatibility (Traditional WL Zone)

Install config (using traditional format us-west-2-wl1-sea-wlz-1):

compute:
- name: edge
  platform:
    aws:
      zones:
      - us-west-2-wl1-sea-wlz-1  # Traditional format

Result:

{
  "Sid": "PermissionCreateCarrierGateway",
  "Effect": "Allow",
  "Action": [
    "ec2:DescribeCarrierGateways",
    "ec2:CreateCarrierGateway",
    "ec2:DeleteCarrierGateway"
  ],
  "Resource": ["*"]
}

✅ Traditional format still works correctly

---

Test Results

Test Item	Status	Details
Installer Build	✅ PASS	release 4.18
Unit tests	✅ PASS	New format WL Zone correctly identified
Policy generation	✅ PASS	Policy file created successfully
CAGW permissions	✅ PASS	All 3 permissions included
Statement count	✅ PASS	12 statements
Backward compatibility	✅ PASS	Traditional zones still work

---

Conclusion

✅ PR #10409 successfully backports the Wavelength Zone fix to 4.18

• New format Wavelength Zone (us-east-1-foe-wlz-1a) is correctly recognized
• Generated IAM policy includes required Carrier Gateway permissions
• Unit tests confirm regex pattern fix works as expected
• Backward compatibility maintained for traditional WL zone formats

---

Verified by: @liweinan
Related PRs:

• Upstream: OCPBUGS-77355: fix wavelength zone name regex #10338
• Backport (4.21): [release-4.21] OCPBUGS-77504: fix wavelength zone name regex #10343
• Backport (4.20): [release-4.20] OCPBUGS-78091: fix wavelength zone name regex #10373
• Backport (4.19): [release-4.19] OCPBUGS-78496: fix wavelength zone name regex #10391

[liweinan]

/verified by liweinan

[openshift-ci-robot]

@liweinan: This PR has been marked as verified by liweinan.

Details

In response to this:

/verified by liweinan

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci-robot]

@tthvo: Jira Issue Verification Checks: Jira Issue OCPBUGS-78550
✔️ This pull request was pre-merge verified.
✔️ All associated pull requests have merged.
✔️ All associated, merged pull requests were pre-merge verified.

Jira Issue OCPBUGS-78550 has been moved to the MODIFIED state and will move to the VERIFIED state when the change is available in an accepted nightly payload. 🕓

Details

In response to this:

This is a manual cherry-pick of #10391 due to git conflicts.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.