Skip to content

OCPBUGS-81622: Collect bootstrap service records in agent-gather#10457

Merged
openshift-merge-bot[bot] merged 2 commits intoopenshift:mainfrom
zaneb:agent-gather-bootstrap
Apr 7, 2026
Merged

OCPBUGS-81622: Collect bootstrap service records in agent-gather#10457
openshift-merge-bot[bot] merged 2 commits intoopenshift:mainfrom
zaneb:agent-gather-bootstrap

Conversation

@zaneb
Copy link
Copy Markdown
Member

@zaneb zaneb commented Apr 2, 2026

No description provided.

@openshift-ci-robot openshift-ci-robot added jira/severity-low Referenced Jira bug's severity is low for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. labels Apr 2, 2026
@openshift-ci-robot
Copy link
Copy Markdown
Contributor

@zaneb: This pull request references Jira Issue OCPBUGS-81622, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.22.0) matches configured target version for branch (4.22.0)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Apr 2, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: df2b7021-8010-4791-82f1-1440a345060e

📥 Commits

Reviewing files that changed from the base of the PR and between a9e3fd2 and 9dcc783.

📒 Files selected for processing (1)
  • data/data/agent/files/usr/local/bin/agent-gather

Walkthrough

Modified the agent data-gathering script to refine data collection. Updated gather_agent_data to copy only /etc/assisted directory. Added a new gather_bootstrap_status function that conditionally copies /var/log/openshift logs. Integrated the new function into the main data-collection workflow.

Changes

Cohort / File(s) Summary
Agent Data Gathering Script
data/data/agent/files/usr/local/bin/agent-gather
Modified gather_agent_data to narrow scope of copied configuration to /etc/assisted only. Extended gather_systemd_units with completion output. Added new gather_bootstrap_status function that conditionally copies /var/log/openshift directory to artifacts when present, and integrated it into main collection sequence.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~12 minutes

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands and usage tips.

@openshift-ci openshift-ci bot requested review from pawanpinjarkar and rwsu April 2, 2026 00:10
@zaneb
Copy link
Copy Markdown
Member Author

zaneb commented Apr 2, 2026

Luckily jobs are failing due to https://redhat.atlassian.net/browse/OCPBUGS-81627 so we can see that this is correct 😄
/verified by @zaneb

@openshift-ci-robot openshift-ci-robot added the verified Signifies that the PR passed pre-merge verification criteria label Apr 2, 2026
@openshift-ci-robot
Copy link
Copy Markdown
Contributor

@zaneb: This PR has been marked as verified by @zaneb.

Details

In response to this:

Luckily jobs are failing due to https://redhat.atlassian.net/browse/OCPBUGS-81627 so we can see that this is correct 😄
/verified by @zaneb

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@sadasu
Copy link
Copy Markdown
Contributor

sadasu commented Apr 2, 2026

/retest-required

@sadasu
Copy link
Copy Markdown
Contributor

sadasu commented Apr 2, 2026

/approve

@sadasu
Copy link
Copy Markdown
Contributor

sadasu commented Apr 2, 2026

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Apr 2, 2026
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci bot commented Apr 2, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sadasu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 2, 2026
@sadasu
Copy link
Copy Markdown
Contributor

sadasu commented Apr 2, 2026

/test

@sadasu
Copy link
Copy Markdown
Contributor

sadasu commented Apr 2, 2026

/testwith e2e-agent-compact-ipv4-iso-no-registry openshift/api#2791

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci bot commented Apr 2, 2026

@sadasu, testwith: Error processing request. ERROR:

could not determine job runs: requested job is invalid. needs to be formatted like: <org>/<repo>/<branch>/<variant?>/<job>. instead it was: e2e-agent-compact-ipv4-iso-no-registry

@sadasu
Copy link
Copy Markdown
Contributor

sadasu commented Apr 2, 2026

/testwith openshift/installer/main/e2e-agent-compact-ipv4-iso-no-registry openshift/api#2791

@openshift-merge-bot
Copy link
Copy Markdown
Contributor

/retest-required

Remaining retests: 0 against base HEAD 30edf44 and 2 for PR HEAD 9dcc783 in total

@openshift-merge-bot
Copy link
Copy Markdown
Contributor

/retest-required

Remaining retests: 0 against base HEAD 460a9d0 and 1 for PR HEAD 9dcc783 in total

@openshift-merge-bot
Copy link
Copy Markdown
Contributor

/retest-required

Remaining retests: 0 against base HEAD 860d2b6 and 0 for PR HEAD 9dcc783 in total

@openshift-merge-bot
Copy link
Copy Markdown
Contributor

/hold

Revision 9dcc783 was retested 3 times: holding

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 3, 2026
@andfasano
Copy link
Copy Markdown
Contributor

/testwith openshift/installer/main/e2e-agent-compact-ipv4-iso-no-registry openshift/api#2791

@sadasu
Copy link
Copy Markdown
Contributor

sadasu commented Apr 3, 2026

/retest-required

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci bot commented Apr 3, 2026

@zaneb: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-agent-ha-dualstack 9dcc783 link false /test e2e-agent-ha-dualstack
ci/prow/e2e-agent-compact-ipv4-iso-no-registry 9dcc783 link false /test e2e-agent-compact-ipv4-iso-no-registry

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@zaneb
Copy link
Copy Markdown
Member Author

zaneb commented Apr 6, 2026

/override ci/prow/e2e-agent-compact-ipv4
/hold cancel

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 6, 2026
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci bot commented Apr 6, 2026

@zaneb: Overrode contexts on behalf of zaneb: ci/prow/e2e-agent-compact-ipv4

Details

In response to this:

/override ci/prow/e2e-agent-compact-ipv4
/hold cancel

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-merge-bot openshift-merge-bot bot merged commit d516a1e into openshift:main Apr 7, 2026
25 of 28 checks passed
@openshift-ci-robot
Copy link
Copy Markdown
Contributor

@zaneb: Jira Issue Verification Checks: Jira Issue OCPBUGS-81622
✔️ This pull request was pre-merge verified.
✔️ All associated pull requests have merged.
✔️ All associated, merged pull requests were pre-merge verified.

Jira Issue OCPBUGS-81622 has been moved to the MODIFIED state and will move to the VERIFIED state when the change is available in an accepted nightly payload. 🕓

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/severity-low Referenced Jira bug's severity is low for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. verified Signifies that the PR passed pre-merge verification criteria

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants