Skip to content

AGENT-1428: Add e2e extended tests for NoRegistryClusterInstall#5620

Closed
pawanpinjarkar wants to merge 1 commit intoopenshift:mainfrom
pawanpinjarkar:e2e-extended-tests-for-NoRegistryClusterInstall-feature-promotion
Closed

AGENT-1428: Add e2e extended tests for NoRegistryClusterInstall#5620
pawanpinjarkar wants to merge 1 commit intoopenshift:mainfrom
pawanpinjarkar:e2e-extended-tests-for-NoRegistryClusterInstall-feature-promotion

Conversation

@pawanpinjarkar
Copy link
Copy Markdown

@pawanpinjarkar pawanpinjarkar commented Feb 4, 2026

- What I did
Added e2e tests for the InternalReleaseImage (IRI) resource to support the NoRegistryClusterInstall feature promotion.

- How to verify it

Prerequisites:

  1. Deploy an OVE (OpenShift Virtualization Environment) compact IPv4 cluster using Agent Installer for NoRegistryClusterInstall feature
  2. Verify IRI resource exists.oc get internalreleaseimage

Running the tests locally:
(requires code modification) Refer #5619. Temporarily comment out line 104 exutil.InitStandardFlags() in cmd/machine-config-tests-ext/main.go

Build test binary go build ./cmd/machine-config-tests-ext/
Export kubeconfig export KUBECONFIG=/path/to/kubeconfig
Run IRI test suite ./machine-config-tests-ext run-suite openshift/abi/noregistry

Expected results:

  • All tests from IRI test suite should pass
  • Tests should skip on clusters without NoRegistryClusterInstall feature

- Description for the changelog
Add e2e tests for InternalReleaseImage resource (NoRegistryClusterInstall feature)


Assisted by: https://claude.ai/claude-code (Claude Sonnet 4.5)

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Feb 4, 2026
@openshift-ci-robot
Copy link
Copy Markdown
Contributor

openshift-ci-robot commented Feb 4, 2026

@pawanpinjarkar: This pull request references AGENT-1428 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.22.0" version, but no target version was set.

Details

In response to this:

- What I did
Added e2e tests for the InternalReleaseImage (IRI) resource to support the NoRegistryClusterInstall feature promotion.

- How to verify it

Prerequisites:

  1. Deploy an OVE (OpenShift Virtualization Environment) compact IPv4 cluster using Agent Installer for NoRegistryClusterInstall feature
  2. Verify IRI resource exists.oc get internalreleaseimage

Running the tests locally:
(requires code modification) Refer #5619. Temporarily comment out line 104 exutil.InitStandardFlags() in cmd/machine-config-tests-ext/main.go

Build test binary go build ./cmd/machine-config-tests-ext/
Export kubeconfig export KUBECONFIG=/path/to/kubeconfig
Run IRI test suite ./machine-config-tests-ext run-suite openshift/machine-config-operator/iri

Expected results:

  • All tests from IRI test suite should pass
  • Tests should skip on clusters without NoRegistryClusterInstall feature

- Description for the changelog
Add e2e tests for InternalReleaseImage resource (NoRegistryClusterInstall feature)


Assisted by: https://claude.ai/claude-code (Claude Sonnet 4.5)

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Feb 4, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: pawanpinjarkar
Once this PR has been reviewed and has the lgtm label, please assign pablintino for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@pawanpinjarkar pawanpinjarkar marked this pull request as draft February 4, 2026 18:32
@openshift-ci openshift-ci Bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 4, 2026
@pawanpinjarkar pawanpinjarkar marked this pull request as ready for review February 4, 2026 19:42
@openshift-ci openshift-ci Bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 4, 2026
@openshift-ci openshift-ci Bot requested a review from yuqi-zhang February 4, 2026 19:43
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Feb 5, 2026

@pawanpinjarkar: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/images acef02b link true /test images
ci/prow/e2e-hypershift acef02b link true /test e2e-hypershift
ci/prow/e2e-aws-ovn acef02b link true /test e2e-aws-ovn
ci/prow/e2e-aws-ovn-upgrade acef02b link true /test e2e-aws-ovn-upgrade

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@pawanpinjarkar pawanpinjarkar marked this pull request as draft February 5, 2026 20:36
@openshift-ci openshift-ci Bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 5, 2026
@pawanpinjarkar pawanpinjarkar force-pushed the e2e-extended-tests-for-NoRegistryClusterInstall-feature-promotion branch 2 times, most recently from c9a094f to 49b4c63 Compare February 6, 2026 20:21
@pawanpinjarkar pawanpinjarkar force-pushed the e2e-extended-tests-for-NoRegistryClusterInstall-feature-promotion branch from 49b4c63 to 5442774 Compare February 6, 2026 20:21
@openshift-ci-robot
Copy link
Copy Markdown
Contributor

openshift-ci-robot commented Feb 6, 2026

@pawanpinjarkar: This pull request references AGENT-1428 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.22.0" version, but no target version was set.

Details

In response to this:

- What I did
Added e2e tests for the InternalReleaseImage (IRI) resource to support the NoRegistryClusterInstall feature promotion.

- How to verify it

Prerequisites:

  1. Deploy an OVE (OpenShift Virtualization Environment) compact IPv4 cluster using Agent Installer for NoRegistryClusterInstall feature
  2. Verify IRI resource exists.oc get internalreleaseimage

Running the tests locally:
(requires code modification) Refer #5619. Temporarily comment out line 104 exutil.InitStandardFlags() in cmd/machine-config-tests-ext/main.go

Build test binary go build ./cmd/machine-config-tests-ext/
Export kubeconfig export KUBECONFIG=/path/to/kubeconfig
Run IRI test suite ./machine-config-tests-ext run-suite openshift/abi/noregistry

Expected results:

  • All tests from IRI test suite should pass
  • Tests should skip on clusters without NoRegistryClusterInstall feature

- Description for the changelog
Add e2e tests for InternalReleaseImage resource (NoRegistryClusterInstall feature)


Assisted by: https://claude.ai/claude-code (Claude Sonnet 4.5)

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@pawanpinjarkar
Copy link
Copy Markdown
Author

cc @andfasano

@pawanpinjarkar
Copy link
Copy Markdown
Author

Closing this PR. The tests will be moved to openshift/origin repo

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants